From: Yosry Ahmed <yosryahmed@google.com> To: "Tejun Heo" <tj@kernel.org>, "Josef Bacik" <josef@toxicpanda.com>, "Jens Axboe" <axboe@kernel.dk>, "Zefan Li" <lizefan.x@bytedance.com>, "Johannes Weiner" <hannes@cmpxchg.org>, "Michal Hocko" <mhocko@kernel.org>, "Roman Gushchin" <roman.gushchin@linux.dev>, "Shakeel Butt" <shakeelb@google.com>, "Muchun Song" <muchun.song@linux.dev>, "Andrew Morton" <akpm@linux-foundation.org>, "Michal Koutný" <mkoutny@suse.com> Cc: Vasily Averin <vasily.averin@linux.dev>, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, Yosry Ahmed <yosryahmed@google.com> Subject: [PATCH v1 8/9] vmscan: memcg: sleep when flushing stats during reclaim Date: Tue, 28 Mar 2023 06:16:37 +0000 [thread overview] Message-ID: <20230328061638.203420-9-yosryahmed@google.com> (raw) In-Reply-To: <20230328061638.203420-1-yosryahmed@google.com> Memory reclaim is a sleepable context. Allow sleeping when flushing memcg stats to avoid unnecessarily performing a lot of work without sleeping. This can slow down reclaim code if flushing stats is taking too long, but there is already multiple cond_resched()'s in reclaim code. Signed-off-by: Yosry Ahmed <yosryahmed@google.com> --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index a9511ccb936f..9c1c5e8b24b8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2845,7 +2845,7 @@ static void prepare_scan_count(pg_data_t *pgdat, struct scan_control *sc) * Flush the memory cgroup stats, so that we read accurate per-memcg * lruvec stats for heuristics. */ - mem_cgroup_flush_stats_atomic(); + mem_cgroup_flush_stats(); /* * Determine the scan balance between anon and file LRUs. -- 2.40.0.348.gf938b09366-goog
WARNING: multiple messages have this Message-ID (diff)
From: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> To: "Tejun Heo" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Josef Bacik" <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>, "Jens Axboe" <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>, "Zefan Li" <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>, "Johannes Weiner" <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, "Michal Hocko" <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Roman Gushchin" <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>, "Shakeel Butt" <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Muchun Song" <muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>, "Andrew Morton" <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org> Cc: Vasily Averin <vasily.averin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, bpf-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Subject: [PATCH v1 8/9] vmscan: memcg: sleep when flushing stats during reclaim Date: Tue, 28 Mar 2023 06:16:37 +0000 [thread overview] Message-ID: <20230328061638.203420-9-yosryahmed@google.com> (raw) In-Reply-To: <20230328061638.203420-1-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Memory reclaim is a sleepable context. Allow sleeping when flushing memcg stats to avoid unnecessarily performing a lot of work without sleeping. This can slow down reclaim code if flushing stats is taking too long, but there is already multiple cond_resched()'s in reclaim code. Signed-off-by: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index a9511ccb936f..9c1c5e8b24b8 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2845,7 +2845,7 @@ static void prepare_scan_count(pg_data_t *pgdat, struct scan_control *sc) * Flush the memory cgroup stats, so that we read accurate per-memcg * lruvec stats for heuristics. */ - mem_cgroup_flush_stats_atomic(); + mem_cgroup_flush_stats(); /* * Determine the scan balance between anon and file LRUs. -- 2.40.0.348.gf938b09366-goog
next prev parent reply other threads:[~2023-03-28 6:17 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-28 6:16 [PATCH v1 0/9] memcg: make rstat flushing irq and sleep friendly Yosry Ahmed 2023-03-28 6:16 ` Yosry Ahmed 2023-03-28 6:16 ` [PATCH v1 1/9] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic" Yosry Ahmed 2023-03-28 6:16 ` Yosry Ahmed 2023-03-28 13:24 ` Shakeel Butt 2023-03-28 13:24 ` Shakeel Butt 2023-03-28 17:42 ` Johannes Weiner 2023-03-28 17:42 ` Johannes Weiner 2023-03-28 6:16 ` [PATCH v1 2/9] memcg: rename mem_cgroup_flush_stats_"delayed" to "ratelimited" Yosry Ahmed 2023-03-28 13:25 ` Shakeel Butt 2023-03-28 13:25 ` Shakeel Butt 2023-03-28 17:42 ` Johannes Weiner 2023-03-28 17:42 ` Johannes Weiner 2023-03-28 6:16 ` [PATCH v1 3/9] memcg: do not flush stats in irq context Yosry Ahmed 2023-03-28 13:26 ` Shakeel Butt 2023-03-28 13:26 ` Shakeel Butt 2023-03-28 17:43 ` Johannes Weiner 2023-03-28 6:16 ` [PATCH v1 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context Yosry Ahmed 2023-03-28 14:59 ` Shakeel Butt 2023-03-28 14:59 ` Shakeel Butt 2023-03-28 17:49 ` Johannes Weiner 2023-03-28 18:59 ` Yosry Ahmed 2023-03-28 18:59 ` Yosry Ahmed 2023-03-28 22:18 ` Yosry Ahmed 2023-03-28 22:18 ` Yosry Ahmed 2023-03-28 6:16 ` [PATCH v1 5/9] memcg: replace stats_flush_lock with an atomic Yosry Ahmed 2023-03-28 14:15 ` Shakeel Butt 2023-03-28 14:15 ` Shakeel Butt 2023-03-28 18:52 ` Yosry Ahmed 2023-03-28 18:52 ` Yosry Ahmed 2023-03-28 19:28 ` Shakeel Butt 2023-03-28 19:28 ` Shakeel Butt 2023-03-28 19:34 ` Yosry Ahmed 2023-03-28 19:34 ` Yosry Ahmed 2023-03-28 19:42 ` Yosry Ahmed 2023-03-28 17:53 ` Johannes Weiner 2023-03-28 17:53 ` Johannes Weiner 2023-03-28 6:16 ` [PATCH v1 6/9] memcg: sleep during flushing stats in safe contexts Yosry Ahmed 2023-03-28 15:09 ` Shakeel Butt 2023-03-28 15:09 ` Shakeel Butt 2023-03-28 18:35 ` Johannes Weiner 2023-03-28 18:45 ` Yosry Ahmed 2023-03-28 18:45 ` Yosry Ahmed 2023-03-28 19:06 ` Johannes Weiner 2023-03-28 19:06 ` Johannes Weiner 2023-03-28 19:26 ` Yosry Ahmed 2023-03-28 19:26 ` Yosry Ahmed 2023-03-28 6:16 ` [PATCH v1 7/9] workingset: memcg: sleep when flushing stats in workingset_refault() Yosry Ahmed 2023-03-28 15:18 ` Shakeel Butt 2023-03-28 15:18 ` Shakeel Butt 2023-03-28 18:47 ` Johannes Weiner 2023-03-28 18:47 ` Johannes Weiner 2023-03-28 19:25 ` Yosry Ahmed 2023-03-28 18:43 ` Johannes Weiner 2023-03-28 18:43 ` Johannes Weiner 2023-03-28 6:16 ` Yosry Ahmed [this message] 2023-03-28 6:16 ` [PATCH v1 8/9] vmscan: memcg: sleep when flushing stats during reclaim Yosry Ahmed 2023-03-28 15:19 ` Shakeel Butt 2023-03-28 15:19 ` Shakeel Butt 2023-03-28 19:01 ` Yosry Ahmed 2023-03-28 19:01 ` Yosry Ahmed 2023-03-28 19:29 ` Shakeel Butt 2023-03-28 19:29 ` Shakeel Butt 2023-03-28 18:49 ` Johannes Weiner 2023-03-28 6:16 ` [PATCH v1 9/9] memcg: do not modify rstat tree for zero updates Yosry Ahmed 2023-03-28 15:20 ` Shakeel Butt 2023-03-28 15:20 ` Shakeel Butt 2023-03-28 18:50 ` Johannes Weiner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230328061638.203420-9-yosryahmed@google.com \ --to=yosryahmed@google.com \ --cc=akpm@linux-foundation.org \ --cc=axboe@kernel.dk \ --cc=bpf@vger.kernel.org \ --cc=cgroups@vger.kernel.org \ --cc=hannes@cmpxchg.org \ --cc=josef@toxicpanda.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lizefan.x@bytedance.com \ --cc=mhocko@kernel.org \ --cc=mkoutny@suse.com \ --cc=muchun.song@linux.dev \ --cc=roman.gushchin@linux.dev \ --cc=shakeelb@google.com \ --cc=tj@kernel.org \ --cc=vasily.averin@linux.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.