From: Shakeel Butt <shakeelb@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: "Tejun Heo" <tj@kernel.org>, "Josef Bacik" <josef@toxicpanda.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Muchun Song" <muchun.song@linux.dev>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Vasily Averin" <vasily.averin@linux.dev>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v1 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context
Date: Tue, 28 Mar 2023 07:59:04 -0700 [thread overview]
Message-ID: <CALvZod4zLhgjd3Tr5Qauz+OwF7Gj-NwDZPMpYAsxaMSUvu3F4g@mail.gmail.com> (raw)
In-Reply-To: <20230328061638.203420-5-yosryahmed@google.com>
On Mon, Mar 27, 2023 at 11:16 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> rstat flushing is too expensive to perform in irq context.
> The previous patch removed the only context that may invoke an rstat
> flush from irq context, add a WARN_ON_ONCE() to detect future
> violations, or those that we are not aware of.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: Shakeel Butt <shakeelb@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: "Tejun Heo" <tj@kernel.org>, "Josef Bacik" <josef@toxicpanda.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Muchun Song" <muchun.song@linux.dev>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Vasily Averin" <vasily.averin@linux.dev>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v1 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context
Date: Tue, 28 Mar 2023 07:59:04 -0700 [thread overview]
Message-ID: <CALvZod4zLhgjd3Tr5Qauz+OwF7Gj-NwDZPMpYAsxaMSUvu3F4g@mail.gmail.com> (raw)
In-Reply-To: <20230328061638.203420-5-yosryahmed@google.com>
On Mon, Mar 27, 2023 at 11:16 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> rstat flushing is too expensive to perform in irq context.
> The previous patch removed the only context that may invoke an rstat
> flush from irq context, add a WARN_ON_ONCE() to detect future
> violations, or those that we are not aware of.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
next prev parent reply other threads:[~2023-03-28 14:59 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 6:16 [PATCH v1 0/9] memcg: make rstat flushing irq and sleep friendly Yosry Ahmed
2023-03-28 6:16 ` Yosry Ahmed
2023-03-28 6:16 ` [PATCH v1 1/9] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic" Yosry Ahmed
2023-03-28 6:16 ` Yosry Ahmed
2023-03-28 13:24 ` Shakeel Butt
2023-03-28 13:24 ` Shakeel Butt
2023-03-28 17:42 ` Johannes Weiner
2023-03-28 17:42 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 2/9] memcg: rename mem_cgroup_flush_stats_"delayed" to "ratelimited" Yosry Ahmed
2023-03-28 13:25 ` Shakeel Butt
2023-03-28 13:25 ` Shakeel Butt
2023-03-28 17:42 ` Johannes Weiner
2023-03-28 17:42 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 3/9] memcg: do not flush stats in irq context Yosry Ahmed
2023-03-28 13:26 ` Shakeel Butt
2023-03-28 13:26 ` Shakeel Butt
2023-03-28 17:43 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 4/9] cgroup: rstat: add WARN_ON_ONCE() if flushing outside task context Yosry Ahmed
2023-03-28 14:59 ` Shakeel Butt [this message]
2023-03-28 14:59 ` Shakeel Butt
2023-03-28 17:49 ` Johannes Weiner
2023-03-28 18:59 ` Yosry Ahmed
2023-03-28 18:59 ` Yosry Ahmed
2023-03-28 22:18 ` Yosry Ahmed
2023-03-28 22:18 ` Yosry Ahmed
2023-03-28 6:16 ` [PATCH v1 5/9] memcg: replace stats_flush_lock with an atomic Yosry Ahmed
2023-03-28 14:15 ` Shakeel Butt
2023-03-28 14:15 ` Shakeel Butt
2023-03-28 18:52 ` Yosry Ahmed
2023-03-28 18:52 ` Yosry Ahmed
2023-03-28 19:28 ` Shakeel Butt
2023-03-28 19:28 ` Shakeel Butt
2023-03-28 19:34 ` Yosry Ahmed
2023-03-28 19:34 ` Yosry Ahmed
2023-03-28 19:42 ` Yosry Ahmed
2023-03-28 17:53 ` Johannes Weiner
2023-03-28 17:53 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 6/9] memcg: sleep during flushing stats in safe contexts Yosry Ahmed
2023-03-28 15:09 ` Shakeel Butt
2023-03-28 15:09 ` Shakeel Butt
2023-03-28 18:35 ` Johannes Weiner
2023-03-28 18:45 ` Yosry Ahmed
2023-03-28 18:45 ` Yosry Ahmed
2023-03-28 19:06 ` Johannes Weiner
2023-03-28 19:06 ` Johannes Weiner
2023-03-28 19:26 ` Yosry Ahmed
2023-03-28 19:26 ` Yosry Ahmed
2023-03-28 6:16 ` [PATCH v1 7/9] workingset: memcg: sleep when flushing stats in workingset_refault() Yosry Ahmed
2023-03-28 15:18 ` Shakeel Butt
2023-03-28 15:18 ` Shakeel Butt
2023-03-28 18:47 ` Johannes Weiner
2023-03-28 18:47 ` Johannes Weiner
2023-03-28 19:25 ` Yosry Ahmed
2023-03-28 18:43 ` Johannes Weiner
2023-03-28 18:43 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 8/9] vmscan: memcg: sleep when flushing stats during reclaim Yosry Ahmed
2023-03-28 6:16 ` Yosry Ahmed
2023-03-28 15:19 ` Shakeel Butt
2023-03-28 15:19 ` Shakeel Butt
2023-03-28 19:01 ` Yosry Ahmed
2023-03-28 19:01 ` Yosry Ahmed
2023-03-28 19:29 ` Shakeel Butt
2023-03-28 19:29 ` Shakeel Butt
2023-03-28 18:49 ` Johannes Weiner
2023-03-28 6:16 ` [PATCH v1 9/9] memcg: do not modify rstat tree for zero updates Yosry Ahmed
2023-03-28 15:20 ` Shakeel Butt
2023-03-28 15:20 ` Shakeel Butt
2023-03-28 18:50 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod4zLhgjd3Tr5Qauz+OwF7Gj-NwDZPMpYAsxaMSUvu3F4g@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tj@kernel.org \
--cc=vasily.averin@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.