From: Parav Pandit <parav@nvidia.com> To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <pasic@linux.ibm.com>, <cohuck@redhat.com> Cc: <sgarzare@redhat.com>, <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>, Parav Pandit <parav@nvidia.com> Subject: [virtio-dev] [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports Date: Tue, 28 Mar 2023 23:17:51 +0300 [thread overview] Message-ID: <20230328201754.440974-6-parav@nvidia.com> (raw) In-Reply-To: <20230328201754.440974-1-parav@nvidia.com> max_num field reflects the maximum queue size/depth. Hence align name of this field with similar field in PCI and MMIO transport to max_queue_size. Similarly rename 'num' to 'size'. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 Signed-off-by: Parav Pandit <parav@nvidia.com> --- changelog: v8->v9: - replaced 'named' as 'known' v3->v4: - moved note to comment --- transport-ccw.tex | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/transport-ccw.tex b/transport-ccw.tex index c492cb9..488c46c 100644 --- a/transport-ccw.tex +++ b/transport-ccw.tex @@ -237,12 +237,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir \begin{lstlisting} struct vq_config_block { be16 index; - be16 max_num; + be16 max_queue_size; /* Previously known as max_num */ }; \end{lstlisting} The requested number of buffers for queue \field{index} is returned in -\field{max_num}. +\field{max_queue_size}. Afterwards, CCW_CMD_SET_VQ is issued by the driver to inform the device about the location used for its queue. The transmitted @@ -253,7 +253,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir be64 desc; be32 res0; be16 index; - be16 num; + be16 size; /* Previously known as num */ be64 driver; be64 device; }; @@ -262,7 +262,8 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir \field{desc}, \field{driver} and \field{device} contain the guest addresses for the descriptor area, available area and used area for queue \field{index}, respectively. The actual -virtqueue size (number of allocated buffers) is transmitted in \field{num}. +virtqueue size (number of allocated buffers) is transmitted in +\field{size}. \devicenormative{\paragraph}{Configuring a Virtqueue}{Virtio Transport Options / Virtio over channel I/O / Device Initialization / Configuring a Virtqueue} @@ -278,11 +279,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir be64 queue; be32 align; be16 index; - be16 num; + be16 size; /* Previously known as num */ }; \end{lstlisting} -\field{queue} contains the guest address for queue \field{index}, \field{num} the number of buffers +\field{queue} contains the guest address for queue \field{index}, +\field{size} the number of buffers and \field{align} the alignment. The queue layout follows \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}. \subsubsection{Communicating Status Information}\label{sec:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Communicating Status Information} -- 2.26.2 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com> To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <pasic@linux.ibm.com>, <cohuck@redhat.com> Cc: <sgarzare@redhat.com>, <virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>, Parav Pandit <parav@nvidia.com> Subject: [virtio-comment] [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports Date: Tue, 28 Mar 2023 23:17:51 +0300 [thread overview] Message-ID: <20230328201754.440974-6-parav@nvidia.com> (raw) In-Reply-To: <20230328201754.440974-1-parav@nvidia.com> max_num field reflects the maximum queue size/depth. Hence align name of this field with similar field in PCI and MMIO transport to max_queue_size. Similarly rename 'num' to 'size'. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 Signed-off-by: Parav Pandit <parav@nvidia.com> --- changelog: v8->v9: - replaced 'named' as 'known' v3->v4: - moved note to comment --- transport-ccw.tex | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/transport-ccw.tex b/transport-ccw.tex index c492cb9..488c46c 100644 --- a/transport-ccw.tex +++ b/transport-ccw.tex @@ -237,12 +237,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir \begin{lstlisting} struct vq_config_block { be16 index; - be16 max_num; + be16 max_queue_size; /* Previously known as max_num */ }; \end{lstlisting} The requested number of buffers for queue \field{index} is returned in -\field{max_num}. +\field{max_queue_size}. Afterwards, CCW_CMD_SET_VQ is issued by the driver to inform the device about the location used for its queue. The transmitted @@ -253,7 +253,7 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir be64 desc; be32 res0; be16 index; - be16 num; + be16 size; /* Previously known as num */ be64 driver; be64 device; }; @@ -262,7 +262,8 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir \field{desc}, \field{driver} and \field{device} contain the guest addresses for the descriptor area, available area and used area for queue \field{index}, respectively. The actual -virtqueue size (number of allocated buffers) is transmitted in \field{num}. +virtqueue size (number of allocated buffers) is transmitted in +\field{size}. \devicenormative{\paragraph}{Configuring a Virtqueue}{Virtio Transport Options / Virtio over channel I/O / Device Initialization / Configuring a Virtqueue} @@ -278,11 +279,12 @@ \subsubsection{Configuring a Virtqueue}\label{sec:Virtio Transport Options / Vir be64 queue; be32 align; be16 index; - be16 num; + be16 size; /* Previously known as num */ }; \end{lstlisting} -\field{queue} contains the guest address for queue \field{index}, \field{num} the number of buffers +\field{queue} contains the guest address for queue \field{index}, +\field{size} the number of buffers and \field{align} the alignment. The queue layout follows \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}~\nameref{sec:Basic Facilities of a Virtio Device / Virtqueues / Legacy Interfaces: A Note on Virtqueue Layout}. \subsubsection{Communicating Status Information}\label{sec:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Communicating Status Information} -- 2.26.2 This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-03-28 20:18 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-28 20:17 [virtio-dev] [PATCH v9 0/8] Rename queue index to queue number Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit 2023-03-28 20:17 ` [virtio-dev] [PATCH v9 1/8] content: Add vq number text Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit 2023-03-29 9:01 ` [virtio-dev] " Cornelia Huck 2023-03-29 9:01 ` [virtio-comment] " Cornelia Huck 2023-03-28 20:17 ` [virtio-dev] [PATCH v9 2/8] transport-pci: Refer to the vq by its number Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit 2023-03-29 9:06 ` [virtio-dev] " Cornelia Huck 2023-03-29 9:06 ` [virtio-comment] " Cornelia Huck 2023-03-28 20:17 ` [virtio-dev] [PATCH v9 3/8] transport-mmio: Rename QueueNum register Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit 2023-03-29 9:15 ` [virtio-dev] " Cornelia Huck 2023-03-29 9:15 ` [virtio-comment] " Cornelia Huck 2023-03-29 12:59 ` [virtio-dev] " Parav Pandit 2023-03-29 12:59 ` [virtio-comment] " Parav Pandit 2023-03-29 13:16 ` [virtio-dev] " Cornelia Huck 2023-03-29 13:16 ` [virtio-comment] " Cornelia Huck 2023-03-28 20:17 ` [virtio-dev] [PATCH v9 4/8] transport-mmio: Refer to the vq by its number Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit 2023-03-29 9:18 ` [virtio-dev] " Cornelia Huck 2023-03-29 9:18 ` [virtio-comment] " Cornelia Huck 2023-03-28 20:17 ` Parav Pandit [this message] 2023-03-28 20:17 ` [virtio-comment] [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports Parav Pandit 2023-03-29 9:23 ` [virtio-dev] " Cornelia Huck 2023-03-29 9:23 ` [virtio-comment] " Cornelia Huck 2023-03-28 20:17 ` [virtio-dev] [PATCH v9 6/8] transport-ccw: Refer to the vq by its number Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit 2023-03-29 9:30 ` [virtio-dev] " Cornelia Huck 2023-03-29 9:30 ` [virtio-comment] " Cornelia Huck 2023-03-29 13:01 ` [virtio-dev] " Parav Pandit 2023-03-29 13:01 ` [virtio-comment] " Parav Pandit 2023-03-29 13:18 ` [virtio-dev] " Cornelia Huck 2023-03-29 13:18 ` [virtio-comment] " Cornelia Huck 2023-03-28 20:17 ` [virtio-dev] [PATCH v9 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit 2023-03-28 20:17 ` [virtio-dev] [PATCH v9 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit 2023-03-28 20:17 ` [virtio-comment] " Parav Pandit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230328201754.440974-6-parav@nvidia.com \ --to=parav@nvidia.com \ --cc=cohuck@redhat.com \ --cc=mst@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=sgarzare@redhat.com \ --cc=shahafs@nvidia.com \ --cc=virtio-comment@lists.oasis-open.org \ --cc=virtio-dev@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.