All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"pasic@linux.ibm.com" <pasic@linux.ibm.com>
Cc: "sgarzare@redhat.com" <sgarzare@redhat.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-dev] RE: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number
Date: Wed, 29 Mar 2023 15:18:11 +0200	[thread overview]
Message-ID: <87fs9nn1bg.fsf@redhat.com> (raw)
In-Reply-To: <PH0PR12MB54814459EB692BD78D1D093FDC899@PH0PR12MB5481.namprd12.prod.outlook.com>

On Wed, Mar 29 2023, Parav Pandit <parav@nvidia.com> wrote:

>> From: Cornelia Huck <cohuck@redhat.com>
>> Sent: Wednesday, March 29, 2023 5:30 AM
>> 
>> Same comment regarding s/Previously/previously/ as for the last patch.
>>
> Will change.
>  
>> Also, I'm not that happy with the name "queue_select". Sure, it matches what
>> pci and mmio use, but ccw does not quite use the same mechanism:
>> vq_config_block is not a structure that always exists where the meaning of the
>> fields is controlled by a selector field, but a structure that is provided by the
>> caller and then filled to refer to a certain vq. I'd prefer this field to be named
>> "vq_num" or something like that.
>
> Rest of the spec uses "vqn" at places. 
> So I will change queue_select to vqn.
> Are you ok with "vqn"?

vqn works for me.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"pasic@linux.ibm.com" <pasic@linux.ibm.com>
Cc: "sgarzare@redhat.com" <sgarzare@redhat.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-comment] RE: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number
Date: Wed, 29 Mar 2023 15:18:11 +0200	[thread overview]
Message-ID: <87fs9nn1bg.fsf@redhat.com> (raw)
In-Reply-To: <PH0PR12MB54814459EB692BD78D1D093FDC899@PH0PR12MB5481.namprd12.prod.outlook.com>

On Wed, Mar 29 2023, Parav Pandit <parav@nvidia.com> wrote:

>> From: Cornelia Huck <cohuck@redhat.com>
>> Sent: Wednesday, March 29, 2023 5:30 AM
>> 
>> Same comment regarding s/Previously/previously/ as for the last patch.
>>
> Will change.
>  
>> Also, I'm not that happy with the name "queue_select". Sure, it matches what
>> pci and mmio use, but ccw does not quite use the same mechanism:
>> vq_config_block is not a structure that always exists where the meaning of the
>> fields is controlled by a selector field, but a structure that is provided by the
>> caller and then filled to refer to a certain vq. I'd prefer this field to be named
>> "vq_num" or something like that.
>
> Rest of the spec uses "vqn" at places. 
> So I will change queue_select to vqn.
> Are you ok with "vqn"?

vqn works for me.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


  reply	other threads:[~2023-03-29 13:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 20:17 [virtio-dev] [PATCH v9 0/8] Rename queue index to queue number Parav Pandit
2023-03-28 20:17 ` [virtio-comment] " Parav Pandit
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 1/8] content: Add vq number text Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit
2023-03-29  9:01   ` [virtio-dev] " Cornelia Huck
2023-03-29  9:01     ` [virtio-comment] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 2/8] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit
2023-03-29  9:06   ` [virtio-dev] " Cornelia Huck
2023-03-29  9:06     ` [virtio-comment] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 3/8] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit
2023-03-29  9:15   ` [virtio-dev] " Cornelia Huck
2023-03-29  9:15     ` [virtio-comment] " Cornelia Huck
2023-03-29 12:59     ` [virtio-dev] " Parav Pandit
2023-03-29 12:59       ` [virtio-comment] " Parav Pandit
2023-03-29 13:16       ` [virtio-dev] " Cornelia Huck
2023-03-29 13:16         ` [virtio-comment] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 4/8] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit
2023-03-29  9:18   ` [virtio-dev] " Cornelia Huck
2023-03-29  9:18     ` [virtio-comment] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit
2023-03-29  9:23   ` [virtio-dev] " Cornelia Huck
2023-03-29  9:23     ` [virtio-comment] " Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 6/8] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit
2023-03-29  9:30   ` [virtio-dev] " Cornelia Huck
2023-03-29  9:30     ` [virtio-comment] " Cornelia Huck
2023-03-29 13:01     ` [virtio-dev] " Parav Pandit
2023-03-29 13:01       ` [virtio-comment] " Parav Pandit
2023-03-29 13:18       ` Cornelia Huck [this message]
2023-03-29 13:18         ` Cornelia Huck
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit
2023-03-28 20:17 ` [virtio-dev] [PATCH v9 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-03-28 20:17   ` [virtio-comment] " Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs9nn1bg.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=pasic@linux.ibm.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.