* [linux-next:master 6897/13075] drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid'.
@ 2023-04-19 23:32 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-04-19 23:32 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Etienne Carriere <etienne.carriere@linaro.org>
CC: Jens Wiklander <jens.wiklander@linaro.org>
CC: Alexandre Torgue <alexandre.torgue@foss.st.com>
CC: Sumit Garg <sumit.garg@linaro.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 3cdbc01c40e34c57697f8934f2727a88551696be
commit: b3b4ced12c1bc829888803ce07fff317e590ec1c [6897/13075] optee: add per cpu asynchronous notification
:::::: branch date: 4 hours ago
:::::: commit date: 3 weeks ago
config: arm64-randconfig-m041-20230419 (https://download.01.org/0day-ci/archive/20230420/202304200755.OoiuclDZ-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304200755.OoiuclDZ-lkp@intel.com/
smatch warnings:
drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid'.
drivers/tee/optee/smc_abi.c:1028 irq_handler() error: uninitialized symbol 'value_pending'.
vim +/value_valid +1021 drivers/tee/optee/smc_abi.c
6749e69c4dadd3 Jens Wiklander 2021-06-15 1010
b3b4ced12c1bc8 Etienne Carriere 2023-03-22 1011 static irqreturn_t irq_handler(struct optee *optee)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1012 {
6749e69c4dadd3 Jens Wiklander 2021-06-15 1013 bool do_bottom_half = false;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1014 bool value_valid;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1015 bool value_pending;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1016 u32 value;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1017
6749e69c4dadd3 Jens Wiklander 2021-06-15 1018 do {
6749e69c4dadd3 Jens Wiklander 2021-06-15 1019 value = get_async_notif_value(optee->smc.invoke_fn,
6749e69c4dadd3 Jens Wiklander 2021-06-15 1020 &value_valid, &value_pending);
6749e69c4dadd3 Jens Wiklander 2021-06-15 @1021 if (!value_valid)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1022 break;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1023
6749e69c4dadd3 Jens Wiklander 2021-06-15 1024 if (value == OPTEE_SMC_ASYNC_NOTIF_VALUE_DO_BOTTOM_HALF)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1025 do_bottom_half = true;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1026 else
6749e69c4dadd3 Jens Wiklander 2021-06-15 1027 optee_notif_send(optee, value);
6749e69c4dadd3 Jens Wiklander 2021-06-15 @1028 } while (value_pending);
6749e69c4dadd3 Jens Wiklander 2021-06-15 1029
6749e69c4dadd3 Jens Wiklander 2021-06-15 1030 if (do_bottom_half)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1031 return IRQ_WAKE_THREAD;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1032 return IRQ_HANDLED;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1033 }
6749e69c4dadd3 Jens Wiklander 2021-06-15 1034
:::::: The code at line 1021 was first introduced by commit
:::::: 6749e69c4dadd352bdfdb306513aa48cc15fbdd6 optee: add asynchronous notifications
:::::: TO: Jens Wiklander <jens.wiklander@linaro.org>
:::::: CC: Jens Wiklander <jens.wiklander@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 2+ messages in thread
* [linux-next:master 6897/13075] drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid'.
@ 2023-04-20 6:03 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-04-20 6:03 UTC (permalink / raw)
To: oe-kbuild, Etienne Carriere
Cc: lkp, oe-kbuild-all, Jens Wiklander, Alexandre Torgue, Sumit Garg
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 3cdbc01c40e34c57697f8934f2727a88551696be
commit: b3b4ced12c1bc829888803ce07fff317e590ec1c [6897/13075] optee: add per cpu asynchronous notification
config: arm64-randconfig-m041-20230419 (https://download.01.org/0day-ci/archive/20230420/202304200755.OoiuclDZ-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304200755.OoiuclDZ-lkp@intel.com/
smatch warnings:
drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid'.
drivers/tee/optee/smc_abi.c:1028 irq_handler() error: uninitialized symbol 'value_pending'.
vim +/value_valid +1021 drivers/tee/optee/smc_abi.c
b3b4ced12c1bc8 Etienne Carriere 2023-03-22 1011 static irqreturn_t irq_handler(struct optee *optee)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1012 {
6749e69c4dadd3 Jens Wiklander 2021-06-15 1013 bool do_bottom_half = false;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1014 bool value_valid;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1015 bool value_pending;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1016 u32 value;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1017
6749e69c4dadd3 Jens Wiklander 2021-06-15 1018 do {
6749e69c4dadd3 Jens Wiklander 2021-06-15 1019 value = get_async_notif_value(optee->smc.invoke_fn,
6749e69c4dadd3 Jens Wiklander 2021-06-15 1020 &value_valid, &value_pending);
The get_async_notif_value() function can return zero without initializing
*valid_value or *value_pending.
6749e69c4dadd3 Jens Wiklander 2021-06-15 @1021 if (!value_valid)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1022 break;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1023
6749e69c4dadd3 Jens Wiklander 2021-06-15 1024 if (value == OPTEE_SMC_ASYNC_NOTIF_VALUE_DO_BOTTOM_HALF)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1025 do_bottom_half = true;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1026 else
6749e69c4dadd3 Jens Wiklander 2021-06-15 1027 optee_notif_send(optee, value);
6749e69c4dadd3 Jens Wiklander 2021-06-15 @1028 } while (value_pending);
6749e69c4dadd3 Jens Wiklander 2021-06-15 1029
6749e69c4dadd3 Jens Wiklander 2021-06-15 1030 if (do_bottom_half)
6749e69c4dadd3 Jens Wiklander 2021-06-15 1031 return IRQ_WAKE_THREAD;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1032 return IRQ_HANDLED;
6749e69c4dadd3 Jens Wiklander 2021-06-15 1033 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-20 6:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-19 23:32 [linux-next:master 6897/13075] drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid' kernel test robot
2023-04-20 6:03 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.