Re: [PATCH v2 1/4] dt-bindings: arm: qcom: Add Samsung Galaxy Express

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On Sun, May 28, 2023 at 09:36:37AM -0400, Rudraksha Gupta wrote:
> > Where did the "att" come from in the compatible. Is this some carrier
> specific model of the phone?
> 
> This is the code name for the device. Since there are usually multiple
> variants of a device, using the code name differentiates between those
> variants. For example, if I left this as "samsung,express", it would be
> unclear if I am referring to the GT-I8730 (code name: expresslte) or the
> SGH-I437 model. This is typically done in postmarketOS:
> https://wiki.postmarketos.org/wiki/Devices and XDA developers. I believe it
> is a carrier specific model of the Samsung Galaxy Express.

Okay, thanks for the information. I'll not dispute the codename, was
wondering whether there were other devices or not. I'll let the qcom
folks decide whether or not that is the right codename..
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]