All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	soc@kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: Add qcom,usb-hs-phy-msm8960
Date: Wed, 31 May 2023 05:56:29 +0300	[thread overview]
Message-ID: <CAA8EJppVHW845p-JJ-9qP6x8pJz64nEN2t2Da+u=yHc6+4pyBA@mail.gmail.com> (raw)
In-Reply-To: <CT04D1K5GOBT.29Y5DO5HHS57V@Latitude-E6420>

On Wed, 31 May 2023 at 05:49, Rudraksha Gupta <guptarud@gmail.com> wrote:
>
> On Tue May 30, 2023 at 9:22 AM EDT, Krzysztof Kozlowski wrote:
> > On 28/05/2023 02:10, Rudraksha Gupta wrote:
> > > Adds qcom,usb-hs-phy-msm8960 compatible
> > >
> >
> > Please use subject prefixes matching the subsystem. You can get them for
> > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> > your patch is touching.
> >
> > Best regards,
> > Krzysztof
>
> It seems like "dt-bindings:" is the subject prefix for this file. Would
> you like me to use another prefix instead?

At least it should be "dt-bindings: phy: ". However as this change
covers existing file, it probably should be "dt-bindings: phy:
qcom,usb-hs-phy: "

-- 
With best wishes
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,  Olof Johansson <olof@lixom.net>,
	soc@kernel.org, linux-arm-msm@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: Add qcom,usb-hs-phy-msm8960
Date: Wed, 31 May 2023 05:56:29 +0300	[thread overview]
Message-ID: <CAA8EJppVHW845p-JJ-9qP6x8pJz64nEN2t2Da+u=yHc6+4pyBA@mail.gmail.com> (raw)
In-Reply-To: <CT04D1K5GOBT.29Y5DO5HHS57V@Latitude-E6420>

On Wed, 31 May 2023 at 05:49, Rudraksha Gupta <guptarud@gmail.com> wrote:
>
> On Tue May 30, 2023 at 9:22 AM EDT, Krzysztof Kozlowski wrote:
> > On 28/05/2023 02:10, Rudraksha Gupta wrote:
> > > Adds qcom,usb-hs-phy-msm8960 compatible
> > >
> >
> > Please use subject prefixes matching the subsystem. You can get them for
> > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> > your patch is touching.
> >
> > Best regards,
> > Krzysztof
>
> It seems like "dt-bindings:" is the subject prefix for this file. Would
> you like me to use another prefix instead?

At least it should be "dt-bindings: phy: ". However as this change
covers existing file, it probably should be "dt-bindings: phy:
qcom,usb-hs-phy: "

-- 
With best wishes
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,  Olof Johansson <olof@lixom.net>,
	soc@kernel.org, linux-arm-msm@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: Add qcom,usb-hs-phy-msm8960
Date: Wed, 31 May 2023 05:56:29 +0300	[thread overview]
Message-ID: <CAA8EJppVHW845p-JJ-9qP6x8pJz64nEN2t2Da+u=yHc6+4pyBA@mail.gmail.com> (raw)
In-Reply-To: <CT04D1K5GOBT.29Y5DO5HHS57V@Latitude-E6420>

On Wed, 31 May 2023 at 05:49, Rudraksha Gupta <guptarud@gmail.com> wrote:
>
> On Tue May 30, 2023 at 9:22 AM EDT, Krzysztof Kozlowski wrote:
> > On 28/05/2023 02:10, Rudraksha Gupta wrote:
> > > Adds qcom,usb-hs-phy-msm8960 compatible
> > >
> >
> > Please use subject prefixes matching the subsystem. You can get them for
> > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> > your patch is touching.
> >
> > Best regards,
> > Krzysztof
>
> It seems like "dt-bindings:" is the subject prefix for this file. Would
> you like me to use another prefix instead?

At least it should be "dt-bindings: phy: ". However as this change
covers existing file, it probably should be "dt-bindings: phy:
qcom,usb-hs-phy: "

-- 
With best wishes
Dmitry

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2023-05-31  2:56 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 23:04 [PATCH 1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi Rudraksha Gupta
2023-05-24 23:04 ` [PATCH 2/5] ARM: Add samsung,expressatt to qcom.yaml Rudraksha Gupta
2023-05-30 13:19   ` Krzysztof Kozlowski
2023-05-24 23:04 ` [PATCH 3/5] ARM: Add qcom,usb-hs-phy-msm8960 to qcom,usb-hs-phy.yaml Rudraksha Gupta
2023-05-24 23:04   ` Rudraksha Gupta
2023-05-30 13:19   ` Krzysztof Kozlowski
2023-05-30 13:19     ` Krzysztof Kozlowski
2023-05-24 23:04 ` [PATCH 4/5] ARM: Blindly copy the usb node from apq8064.dtsi Rudraksha Gupta
2023-05-26 23:30   ` Konrad Dybcio
2023-05-24 23:04 ` [PATCH 5/5] ARM: Add Samsung Galaxy Express support Rudraksha Gupta
2023-05-24 23:04   ` Rudraksha Gupta
2023-05-26 23:36   ` Konrad Dybcio
2023-05-26 23:36     ` Konrad Dybcio
2023-05-30 13:20   ` Krzysztof Kozlowski
2023-05-30 13:20     ` Krzysztof Kozlowski
2023-05-27  4:09 ` [PATCH 1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi Bjorn Andersson
2023-05-28  0:10   ` [PATCH v2 0/4] Samsung Galaxy Express SGH-I437 Support Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-30 13:21     ` Krzysztof Kozlowski
2023-05-30 13:21       ` Krzysztof Kozlowski
2023-05-30 13:21       ` Krzysztof Kozlowski
2023-05-28  0:10   ` [PATCH v2 1/4] dt-bindings: arm: qcom: Add Samsung Galaxy Express Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-28  8:51     ` Conor Dooley
2023-05-28  8:51       ` Conor Dooley
2023-05-28  8:51       ` Conor Dooley
2023-05-28 13:36       ` Rudraksha Gupta
2023-05-28 13:36         ` Rudraksha Gupta
2023-05-28 13:36         ` Rudraksha Gupta
2023-05-28 19:10         ` Conor Dooley
2023-05-28 19:10           ` Conor Dooley
2023-05-28 19:10           ` Conor Dooley
2023-05-29  7:41         ` Konrad Dybcio
2023-05-29  7:41           ` Konrad Dybcio
2023-05-29  7:41           ` Konrad Dybcio
2023-05-29 22:28           ` Rudraksha Gupta
2023-05-29 22:28             ` Rudraksha Gupta
2023-05-29 22:28             ` Rudraksha Gupta
2023-05-29 22:37             ` Conor Dooley
2023-05-29 22:37               ` Conor Dooley
2023-05-29 22:37               ` Conor Dooley
2023-05-29 22:50               ` Rudraksha Gupta
2023-05-29 22:50                 ` Rudraksha Gupta
2023-05-29 22:50                 ` Rudraksha Gupta
2023-05-30 12:57     ` Krzysztof Kozlowski
2023-05-30 12:57       ` Krzysztof Kozlowski
2023-05-30 12:57       ` Krzysztof Kozlowski
2023-05-28  0:10   ` [PATCH v2 2/4] dt-bindings: Add qcom,usb-hs-phy-msm8960 Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-28  8:47     ` Conor Dooley
2023-05-28  8:47       ` Conor Dooley
2023-05-28  8:47       ` Conor Dooley
2023-05-30 13:22     ` Krzysztof Kozlowski
2023-05-30 13:22       ` Krzysztof Kozlowski
2023-05-30 13:22       ` Krzysztof Kozlowski
2023-05-31  2:49       ` Rudraksha Gupta
2023-05-31  2:49         ` Rudraksha Gupta
2023-05-31  2:49         ` Rudraksha Gupta
2023-05-31  2:56         ` Dmitry Baryshkov [this message]
2023-05-31  2:56           ` Dmitry Baryshkov
2023-05-31  2:56           ` Dmitry Baryshkov
2023-05-28  0:10   ` [PATCH v2 3/4] ARM: dts: qcom: msm8960: Add USB node Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-30 13:22     ` Krzysztof Kozlowski
2023-05-30 13:22       ` Krzysztof Kozlowski
2023-05-30 13:22       ` Krzysztof Kozlowski
2023-05-28  0:10   ` [PATCH v2 4/4] ARM: dts: qcom: Add Samsung Galaxy Express support Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-28  0:10     ` Rudraksha Gupta
2023-05-30 13:24     ` Krzysztof Kozlowski
2023-05-30 13:24       ` Krzysztof Kozlowski
2023-05-30 13:24       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA8EJppVHW845p-JJ-9qP6x8pJz64nEN2t2Da+u=yHc6+4pyBA@mail.gmail.com' \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guptarud@gmail.com \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=soc@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.