All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
	slp@redhat.com, mst@redhat.com, marcandre.lureau@redhat.com,
	viresh.kumar@linaro.org, sgarzare@redhat.com,
	takahiro.akashi@linaro.org, erik.schilling@linaro.org,
	manos.pitsidianakis@linaro.org, mathieu.poirier@linaro.org
Subject: Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user
Date: Thu, 20 Jul 2023 15:32:34 -0400	[thread overview]
Message-ID: <20230720193234.GG210977@fedora> (raw)
In-Reply-To: <20230704123600.1808604-1-alex.bennee@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote:
> Currently QEMU has to know some details about the back-end to be able
> to setup the guest. While various parts of the setup can be delegated
> to the backend (for example config handling) this is a very piecemeal
> approach.
> 
> This patch suggests a new feature flag (VHOST_USER_PROTOCOL_F_STANDALONE)
> which the back-end can advertise which allows a probe message to be
> sent to get all the details QEMU needs to know in one message.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> Initial RFC for discussion. I intend to prototype this work with QEMU
> and one of the rust-vmm vhost-user daemons.
> ---
>  docs/interop/vhost-user.rst | 37 +++++++++++++++++++++++++++++++++++++
>  hw/virtio/vhost-user.c      |  8 ++++++++
>  2 files changed, 45 insertions(+)
> 
> diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
> index 5a070adbc1..85b1b1583a 100644
> --- a/docs/interop/vhost-user.rst
> +++ b/docs/interop/vhost-user.rst
> @@ -275,6 +275,21 @@ Inflight description
>  
>  :queue size: a 16-bit size of virtqueues
>  
> +Backend specifications
> +^^^^^^^^^^^^^^^^^^^^^^
> +
> ++-----------+-------------+------------+------------+
> +| device id | config size |   min_vqs  |   max_vqs  |
> ++-----------+-------------+------------+------------+
> +
> +:device id: a 32-bit value holding the VirtIO device ID
> +
> +:config size: a 32-bit value holding the config size (see ``VHOST_USER_GET_CONFIG``)
> +
> +:min_vqs: a 32-bit value holding the minimum number of vqs supported

What is the purpose of min_vqs? I'm not sure why the front-end needs to
know this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
	slp@redhat.com, mst@redhat.com, marcandre.lureau@redhat.com,
	viresh.kumar@linaro.org, sgarzare@redhat.com,
	takahiro.akashi@linaro.org, erik.schilling@linaro.org,
	manos.pitsidianakis@linaro.org, mathieu.poirier@linaro.org
Subject: [virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user
Date: Thu, 20 Jul 2023 15:32:34 -0400	[thread overview]
Message-ID: <20230720193234.GG210977@fedora> (raw)
In-Reply-To: <20230704123600.1808604-1-alex.bennee@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote:
> Currently QEMU has to know some details about the back-end to be able
> to setup the guest. While various parts of the setup can be delegated
> to the backend (for example config handling) this is a very piecemeal
> approach.
> 
> This patch suggests a new feature flag (VHOST_USER_PROTOCOL_F_STANDALONE)
> which the back-end can advertise which allows a probe message to be
> sent to get all the details QEMU needs to know in one message.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> Initial RFC for discussion. I intend to prototype this work with QEMU
> and one of the rust-vmm vhost-user daemons.
> ---
>  docs/interop/vhost-user.rst | 37 +++++++++++++++++++++++++++++++++++++
>  hw/virtio/vhost-user.c      |  8 ++++++++
>  2 files changed, 45 insertions(+)
> 
> diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
> index 5a070adbc1..85b1b1583a 100644
> --- a/docs/interop/vhost-user.rst
> +++ b/docs/interop/vhost-user.rst
> @@ -275,6 +275,21 @@ Inflight description
>  
>  :queue size: a 16-bit size of virtqueues
>  
> +Backend specifications
> +^^^^^^^^^^^^^^^^^^^^^^
> +
> ++-----------+-------------+------------+------------+
> +| device id | config size |   min_vqs  |   max_vqs  |
> ++-----------+-------------+------------+------------+
> +
> +:device id: a 32-bit value holding the VirtIO device ID
> +
> +:config size: a 32-bit value holding the config size (see ``VHOST_USER_GET_CONFIG``)
> +
> +:min_vqs: a 32-bit value holding the minimum number of vqs supported

What is the purpose of min_vqs? I'm not sure why the front-end needs to
know this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2023-07-20 19:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04 12:36 [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user Alex Bennée
2023-07-04 12:36 ` [virtio-dev] " Alex Bennée
2023-07-04 14:54 ` Stefano Garzarella
2023-07-04 14:54   ` Stefano Garzarella
2023-07-04 15:02   ` Alex Bennée
2023-07-04 15:02     ` Alex Bennée
2023-07-07 10:27     ` Stefano Garzarella
2023-07-07 10:27       ` Stefano Garzarella
2023-07-20 19:36       ` Stefan Hajnoczi
2023-07-26 16:01         ` Michael S. Tsirkin
2023-07-26 16:01           ` Michael S. Tsirkin
2023-07-26 14:33   ` Erik Schilling
2023-07-26 15:51     ` Stefan Hajnoczi
2023-07-06 16:31 ` Alex Bennée
2023-07-06 16:31   ` [virtio-dev] " Alex Bennée
2023-07-07 10:35   ` Stefano Garzarella
2023-07-07 10:35     ` [virtio-dev] " Stefano Garzarella
2023-07-06 16:48 ` Michael S. Tsirkin
2023-07-06 16:48   ` Michael S. Tsirkin
2023-07-07  7:58   ` [virtio-dev] " Alex Bennée
2023-07-07  7:58     ` Alex Bennée
2023-07-07  9:57     ` [virtio-dev] " Michael S. Tsirkin
2023-07-07  9:57       ` Michael S. Tsirkin
2023-07-07 13:12       ` Alex Bennée
2023-07-07 13:12         ` [virtio-dev] " Alex Bennée
2023-07-20 19:58   ` Stefan Hajnoczi
2023-07-20 19:58     ` Stefan Hajnoczi
2023-07-20 21:14     ` [virtio-dev] " Michael S. Tsirkin
2023-07-20 21:14       ` Michael S. Tsirkin
2023-07-20 21:31       ` Stefan Hajnoczi
2023-07-20 22:22         ` [virtio-dev] " Michael S. Tsirkin
2023-07-20 22:22           ` Michael S. Tsirkin
2023-07-24 18:08           ` [virtio-dev] " Stefan Hajnoczi
2023-07-24 18:08             ` Stefan Hajnoczi
2023-07-26 16:02             ` [virtio-dev] " Michael S. Tsirkin
2023-07-26 16:02               ` Michael S. Tsirkin
2023-07-26 17:37               ` [virtio-dev] " Stefan Hajnoczi
2023-07-26 17:37                 ` Stefan Hajnoczi
2023-07-20 19:32 ` Stefan Hajnoczi [this message]
2023-07-20 19:32   ` [virtio-dev] " Stefan Hajnoczi
2023-07-20 19:34 ` Stefan Hajnoczi
2023-07-20 19:34   ` [virtio-dev] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720193234.GG210977@fedora \
    --to=stefanha@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=erik.schilling@linaro.org \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=slp@redhat.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.