From: Rob Herring <robh@kernel.org> To: Peter Griffin <peter.griffin@linaro.org> Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board Date: Fri, 6 Oct 2023 15:52:04 -0500 [thread overview] Message-ID: <20231006205204.GA269353-robh@kernel.org> (raw) In-Reply-To: <20231005155618.700312-20-peter.griffin@linaro.org> On Thu, Oct 05, 2023 at 04:56:16PM +0100, Peter Griffin wrote: > The LK bootloader on Pixel6 searches for a dt overlay in the > dtbo partition with a board_id and board_rev that matches > what is baked into the device. If this overlay is not present > then the phone will bootloop in fastboot and you can't boot > the upstream kernel. > > This commit adds a dtbo for the production oriole variant. > The other pre-production board overlays are not included > at this time. > > Adding the dtbo here allows for a better experience when > building/booting the upstream kernel on Pixel devices > as all the DT required to boot the device will be created > as part of the kernel build process. Rather than having to > fetch the dtbo from some other repo. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > arch/arm64/boot/dts/google/Makefile | 1 + > arch/arm64/boot/dts/google/gs101-oriole.dtso | 21 ++++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dtso > > diff --git a/arch/arm64/boot/dts/google/Makefile b/arch/arm64/boot/dts/google/Makefile > index 6d2026a767d4..3f1761f8daa9 100644 > --- a/arch/arm64/boot/dts/google/Makefile > +++ b/arch/arm64/boot/dts/google/Makefile > @@ -2,5 +2,6 @@ > > dtb-$(CONFIG_ARCH_GOOGLE_TENSOR) += \ > gs101-oriole.dtb \ > + gs101-oriole.dtbo Overlays in the kernel must be able to be applied to a base DT in the kernel. Add a rule to apply this (hint: a '-dtbs' variable does this similar to -objs variables). > diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dtso b/arch/arm64/boot/dts/google/gs101-oriole.dtso > new file mode 100644 > index 000000000000..50832fd94204 > --- /dev/null > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Oriole DVT Device Tree Doesn't DVT mean pre-production? Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Peter Griffin <peter.griffin@linaro.org> Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board Date: Fri, 6 Oct 2023 15:52:04 -0500 [thread overview] Message-ID: <20231006205204.GA269353-robh@kernel.org> (raw) In-Reply-To: <20231005155618.700312-20-peter.griffin@linaro.org> On Thu, Oct 05, 2023 at 04:56:16PM +0100, Peter Griffin wrote: > The LK bootloader on Pixel6 searches for a dt overlay in the > dtbo partition with a board_id and board_rev that matches > what is baked into the device. If this overlay is not present > then the phone will bootloop in fastboot and you can't boot > the upstream kernel. > > This commit adds a dtbo for the production oriole variant. > The other pre-production board overlays are not included > at this time. > > Adding the dtbo here allows for a better experience when > building/booting the upstream kernel on Pixel devices > as all the DT required to boot the device will be created > as part of the kernel build process. Rather than having to > fetch the dtbo from some other repo. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > arch/arm64/boot/dts/google/Makefile | 1 + > arch/arm64/boot/dts/google/gs101-oriole.dtso | 21 ++++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dtso > > diff --git a/arch/arm64/boot/dts/google/Makefile b/arch/arm64/boot/dts/google/Makefile > index 6d2026a767d4..3f1761f8daa9 100644 > --- a/arch/arm64/boot/dts/google/Makefile > +++ b/arch/arm64/boot/dts/google/Makefile > @@ -2,5 +2,6 @@ > > dtb-$(CONFIG_ARCH_GOOGLE_TENSOR) += \ > gs101-oriole.dtb \ > + gs101-oriole.dtbo Overlays in the kernel must be able to be applied to a base DT in the kernel. Add a rule to apply this (hint: a '-dtbs' variable does this similar to -objs variables). > diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dtso b/arch/arm64/boot/dts/google/gs101-oriole.dtso > new file mode 100644 > index 000000000000..50832fd94204 > --- /dev/null > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Oriole DVT Device Tree Doesn't DVT mean pre-production? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-06 20:52 UTC|newest] Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-05 15:55 [PATCH 00/21] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board Peter Griffin 2023-10-05 15:55 ` Peter Griffin 2023-10-05 15:55 ` [PATCH 01/21] dt-bindings: interrupt-controller: Add gs101 interrupt controller Peter Griffin 2023-10-05 15:55 ` Peter Griffin 2023-10-05 16:04 ` Krzysztof Kozlowski 2023-10-05 16:04 ` Krzysztof Kozlowski 2023-10-06 21:52 ` Linus Walleij 2023-10-06 21:52 ` Linus Walleij 2023-10-05 15:55 ` [PATCH 02/21] dt-bindings: soc: samsung: exynos-pmu: Add gs101 compatible Peter Griffin 2023-10-05 15:55 ` Peter Griffin 2023-10-05 16:05 ` Krzysztof Kozlowski 2023-10-05 16:05 ` Krzysztof Kozlowski 2023-10-05 15:56 ` [PATCH 03/21] dt-bindings: clock: Add Google gs101 clock management unit bindings Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:06 ` Krzysztof Kozlowski 2023-10-05 16:06 ` Krzysztof Kozlowski 2023-10-05 15:56 ` [PATCH 04/21] dt-bindings: soc: google: exynos-sysreg: add dedicated SYSREG compatibles to GS101 Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:07 ` Krzysztof Kozlowski 2023-10-05 16:07 ` Krzysztof Kozlowski 2023-10-06 12:41 ` Peter Griffin 2023-10-06 12:41 ` Peter Griffin 2023-10-06 12:43 ` Krzysztof Kozlowski 2023-10-06 12:43 ` Krzysztof Kozlowski 2023-10-05 15:56 ` [PATCH 05/21] dt-bindings: watchdog: Document Google gs101 & gs201 watchdog bindings Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:08 ` Krzysztof Kozlowski 2023-10-05 16:08 ` Krzysztof Kozlowski 2023-10-05 17:37 ` William McVicker 2023-10-05 17:37 ` William McVicker 2023-10-05 15:56 ` [PATCH 06/21] dt-bindings: arm: google: Add bindings for Google ARM platforms Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-06 20:44 ` Rob Herring 2023-10-06 20:44 ` Rob Herring 2023-10-05 15:56 ` [PATCH 07/21] dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:10 ` Krzysztof Kozlowski 2023-10-05 16:10 ` Krzysztof Kozlowski 2023-10-05 15:56 ` [PATCH 08/21] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:10 ` Krzysztof Kozlowski 2023-10-05 16:10 ` Krzysztof Kozlowski 2023-10-05 15:56 ` [PATCH 09/21] dt-bindings: clock: gs101: Add cmu_top clock indices Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:11 ` Krzysztof Kozlowski 2023-10-05 16:11 ` Krzysztof Kozlowski 2023-10-08 22:48 ` Chanwoo Choi 2023-10-08 22:48 ` Chanwoo Choi 2023-10-05 15:56 ` [PATCH 10/21] dt-bindings: clock: gs101: Add cmu_apm " Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:11 ` Krzysztof Kozlowski 2023-10-05 16:11 ` Krzysztof Kozlowski 2023-10-05 15:56 ` [PATCH 11/21] dt-bindings: clock: gs101: Add cmu_misc " Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 15:56 ` [PATCH 12/21] clk: samsung: clk-pll: Add support for pll_{0516,0517,518} Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 17:39 ` William McVicker 2023-10-05 17:39 ` William McVicker 2023-10-08 22:51 ` Chanwoo Choi 2023-10-08 22:51 ` Chanwoo Choi 2023-10-05 15:56 ` [PATCH 13/21] clk: samsung: clk-gs101: Add cmu_top registers, plls, mux and gates Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 17:42 ` William McVicker 2023-10-05 17:42 ` William McVicker 2023-10-05 17:45 ` Krzysztof Kozlowski 2023-10-05 17:45 ` Krzysztof Kozlowski 2023-10-06 4:16 ` kernel test robot 2023-10-06 4:16 ` kernel test robot 2023-10-14 6:37 ` kernel test robot 2023-10-14 6:37 ` kernel test robot 2023-10-05 15:56 ` [PATCH 14/21] clk: samsung: clk-gs101: add CMU_APM support Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 17:43 ` William McVicker 2023-10-05 17:43 ` William McVicker 2023-10-05 17:45 ` William McVicker 2023-10-05 17:45 ` William McVicker 2023-10-05 15:56 ` [PATCH 15/21] clk: google: gs101: Add support for CMU_MISC clock unit Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-06 5:20 ` kernel test robot 2023-10-06 5:20 ` kernel test robot 2023-10-05 15:56 ` [PATCH 16/21] pinctrl: samsung: Add gs101 SoC pinctrl configuration Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-06 6:33 ` Krzysztof Kozlowski 2023-10-06 6:33 ` Krzysztof Kozlowski 2023-10-09 7:49 ` Peter Griffin 2023-10-09 7:49 ` Peter Griffin 2023-10-05 15:56 ` [PATCH 17/21] watchdog: s3c2410_wdt: Add support for Google tensor SoCs Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 18:58 ` Guenter Roeck 2023-10-05 18:58 ` Guenter Roeck 2023-10-09 11:56 ` Peter Griffin 2023-10-09 11:56 ` Peter Griffin 2023-10-05 15:56 ` [PATCH 18/21] arm64: dts: google: Add initial Google gs101 SoC support Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:21 ` Krzysztof Kozlowski 2023-10-05 16:21 ` Krzysztof Kozlowski 2023-10-05 17:59 ` William McVicker 2023-10-05 17:59 ` William McVicker 2023-10-05 18:05 ` Greg KH 2023-10-05 18:05 ` Greg KH 2023-10-05 19:18 ` Krzysztof Kozlowski 2023-10-05 19:18 ` Krzysztof Kozlowski 2023-10-05 19:23 ` Greg KH 2023-10-05 19:23 ` Greg KH 2023-10-05 19:29 ` Krzysztof Kozlowski 2023-10-05 19:29 ` Krzysztof Kozlowski 2023-10-05 23:19 ` William McVicker 2023-10-05 23:19 ` William McVicker 2023-10-06 6:06 ` Krzysztof Kozlowski 2023-10-06 6:06 ` Krzysztof Kozlowski 2023-10-06 8:48 ` Arnd Bergmann 2023-10-06 8:48 ` Arnd Bergmann 2023-10-06 16:33 ` William McVicker 2023-10-06 16:33 ` William McVicker 2023-10-07 14:34 ` Krzysztof Kozlowski 2023-10-07 14:34 ` Krzysztof Kozlowski 2023-10-09 16:10 ` William McVicker 2023-10-09 16:10 ` William McVicker 2023-10-05 19:21 ` Krzysztof Kozlowski 2023-10-05 19:21 ` Krzysztof Kozlowski 2023-10-05 19:22 ` Krzysztof Kozlowski 2023-10-05 19:22 ` Krzysztof Kozlowski 2023-10-05 19:26 ` William McVicker 2023-10-05 19:26 ` William McVicker 2023-10-09 12:01 ` Tudor Ambarus 2023-10-09 12:01 ` Tudor Ambarus 2023-10-05 15:56 ` [PATCH 19/21] google/gs101: Add dt overlay for oriole board Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:33 ` Krzysztof Kozlowski 2023-10-05 16:33 ` Krzysztof Kozlowski 2023-10-09 20:03 ` William McVicker 2023-10-09 20:03 ` William McVicker 2023-10-06 7:08 ` Geert Uytterhoeven 2023-10-06 7:08 ` Geert Uytterhoeven 2023-10-06 20:52 ` Rob Herring [this message] 2023-10-06 20:52 ` Rob Herring 2023-10-10 12:09 ` Peter Griffin 2023-10-10 12:09 ` Peter Griffin 2023-10-05 15:56 ` [PATCH 20/21] arm64: defconfig: Enable Google Tensor SoC Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 15:56 ` [PATCH 21/21] MAINTAINERS: add entry for " Peter Griffin 2023-10-05 15:56 ` Peter Griffin 2023-10-05 16:32 ` [PATCH 00/21] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board Krzysztof Kozlowski 2023-10-05 16:32 ` Krzysztof Kozlowski 2023-10-09 11:39 ` Peter Griffin 2023-10-09 11:39 ` Peter Griffin 2023-10-09 11:10 ` Krzysztof Kozlowski 2023-10-09 11:10 ` Krzysztof Kozlowski 2023-10-09 11:40 ` Peter Griffin 2023-10-09 11:40 ` Peter Griffin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231006205204.GA269353-robh@kernel.org \ --to=robh@kernel.org \ --cc=andre.draszik@linaro.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mturquette@baylibre.com \ --cc=olof@lixom.net \ --cc=peter.griffin@linaro.org \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=soc@kernel.org \ --cc=tomasz.figa@gmail.com \ --cc=tudor.ambarus@linaro.org \ --cc=will@kernel.org \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.