From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
joe@perches.com, peng.fan@nxp.com,
alexander.stein@ew.tq-group.com, haibo.chen@nxp.com,
ping.bai@nxp.com, xiaoning.wang@nxp.com, sherry.sun@nxp.com,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2
Date: Tue, 17 Oct 2023 15:14:04 -0500 [thread overview]
Message-ID: <20231017201404.GA2570433-robh@kernel.org> (raw)
In-Reply-To: <20231016152450.2850498-2-Frank.Li@nxp.com>
On Mon, Oct 16, 2023 at 11:24:50AM -0400, Frank Li wrote:
> Add I3C1 and I3C2.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 26 ++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 6f85a05ee7e1..4d9ed0b32853 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -242,6 +242,19 @@ tpm2: pwm@44320000 {
> status = "disabled";
> };
>
> + i3c1: i3c-master@44330000 {
> + compatible = "silvaco,i3c-master";
The real problem here is not whether we have "v1" or not, but you need
an SoC specific compatible. Unless there's a public spec where we can
know exactly how many resets, clocks, interrupts, etc.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
joe@perches.com, peng.fan@nxp.com,
alexander.stein@ew.tq-group.com, haibo.chen@nxp.com,
ping.bai@nxp.com, xiaoning.wang@nxp.com, sherry.sun@nxp.com,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2
Date: Tue, 17 Oct 2023 15:14:04 -0500 [thread overview]
Message-ID: <20231017201404.GA2570433-robh@kernel.org> (raw)
In-Reply-To: <20231016152450.2850498-2-Frank.Li@nxp.com>
On Mon, Oct 16, 2023 at 11:24:50AM -0400, Frank Li wrote:
> Add I3C1 and I3C2.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 26 ++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 6f85a05ee7e1..4d9ed0b32853 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -242,6 +242,19 @@ tpm2: pwm@44320000 {
> status = "disabled";
> };
>
> + i3c1: i3c-master@44330000 {
> + compatible = "silvaco,i3c-master";
The real problem here is not whether we have "v1" or not, but you need
an SoC specific compatible. Unless there's a public spec where we can
know exactly how many resets, clocks, interrupts, etc.
Rob
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
joe@perches.com, peng.fan@nxp.com,
alexander.stein@ew.tq-group.com, haibo.chen@nxp.com,
ping.bai@nxp.com, xiaoning.wang@nxp.com, sherry.sun@nxp.com,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2
Date: Tue, 17 Oct 2023 15:14:04 -0500 [thread overview]
Message-ID: <20231017201404.GA2570433-robh@kernel.org> (raw)
In-Reply-To: <20231016152450.2850498-2-Frank.Li@nxp.com>
On Mon, Oct 16, 2023 at 11:24:50AM -0400, Frank Li wrote:
> Add I3C1 and I3C2.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 26 ++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 6f85a05ee7e1..4d9ed0b32853 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -242,6 +242,19 @@ tpm2: pwm@44320000 {
> status = "disabled";
> };
>
> + i3c1: i3c-master@44330000 {
> + compatible = "silvaco,i3c-master";
The real problem here is not whether we have "v1" or not, but you need
an SoC specific compatible. Unless there's a public spec where we can
know exactly how many resets, clocks, interrupts, etc.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-17 20:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 15:24 [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-16 15:24 ` [PATCH 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2 Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-17 20:14 ` Rob Herring [this message]
2023-10-17 20:14 ` Rob Herring
2023-10-17 20:14 ` Rob Herring
2023-10-16 17:30 ` [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string Conor Dooley
2023-10-16 17:30 ` Conor Dooley
2023-10-16 17:30 ` Conor Dooley
2023-10-16 19:32 ` Frank Li
2023-10-16 19:32 ` Frank Li
2023-10-16 19:32 ` Frank Li
2023-10-16 19:57 ` Krzysztof Kozlowski
2023-10-16 19:57 ` Krzysztof Kozlowski
2023-10-16 19:57 ` Krzysztof Kozlowski
2023-10-16 20:10 ` Frank Li
2023-10-16 20:10 ` Frank Li
2023-10-16 20:10 ` Frank Li
2023-10-16 20:43 ` Krzysztof Kozlowski
2023-10-16 20:43 ` Krzysztof Kozlowski
2023-10-16 20:43 ` Krzysztof Kozlowski
2023-10-17 14:15 ` Miquel Raynal
2023-10-17 14:15 ` Miquel Raynal
2023-10-17 14:15 ` Miquel Raynal
2023-10-16 21:18 [PATCH 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc Frank Li
2023-10-16 21:18 ` [PATCH 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2 Frank Li
2023-10-16 21:18 ` Frank Li
2023-10-16 21:18 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017201404.GA2570433-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=conor.culhane@silvaco.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sherry.sun@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.