From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>, Conor Dooley <conor@kernel.org>
Cc: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
joe@perches.com, peng.fan@nxp.com,
alexander.stein@ew.tq-group.com, haibo.chen@nxp.com,
ping.bai@nxp.com, xiaoning.wang@nxp.com, sherry.sun@nxp.com,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string
Date: Mon, 16 Oct 2023 21:57:18 +0200 [thread overview]
Message-ID: <6110c58a-8003-4889-9a4b-6a7d1821c00e@linaro.org> (raw)
In-Reply-To: <ZS2Pz1HxUgrx4+0R@lizhi-Precision-Tower-5810>
On 16/10/2023 21:32, Frank Li wrote:
> On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote:
>> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
>>> In driver, compatible string is silvaco,i3c-master instead of
>>> silvaco,i3c-master-v1.
>>
>> And what makes the driver right & the binding wrong? AFAICT, this is an
>> IP sold by silvaco & the -v1 suffix was explicitly requested during
>> review of the binding.
>
> The driver existed for the long time. DTS files already use
> silvaco,i3c-master.
>
> There are two options, one change doc, the other change dts and drivers.
> I think change doc is easiest ways.
>
> If there are v2 in future, we can added silvaco,i3c-master-v2 in future.
>
> If everyone prefer change drivers and dts, I can work on new patch. Just
> break back compatiblity.
No, because Rob explicitly pointed out too generic name.
https://lore.kernel.org/all/20210111200821.GA2978830@robh.at.kernel.org/
Is it some way to avoid implementing feedback or how does it work?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>, Conor Dooley <conor@kernel.org>
Cc: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
joe@perches.com, peng.fan@nxp.com,
alexander.stein@ew.tq-group.com, haibo.chen@nxp.com,
ping.bai@nxp.com, xiaoning.wang@nxp.com, sherry.sun@nxp.com,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string
Date: Mon, 16 Oct 2023 21:57:18 +0200 [thread overview]
Message-ID: <6110c58a-8003-4889-9a4b-6a7d1821c00e@linaro.org> (raw)
In-Reply-To: <ZS2Pz1HxUgrx4+0R@lizhi-Precision-Tower-5810>
On 16/10/2023 21:32, Frank Li wrote:
> On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote:
>> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
>>> In driver, compatible string is silvaco,i3c-master instead of
>>> silvaco,i3c-master-v1.
>>
>> And what makes the driver right & the binding wrong? AFAICT, this is an
>> IP sold by silvaco & the -v1 suffix was explicitly requested during
>> review of the binding.
>
> The driver existed for the long time. DTS files already use
> silvaco,i3c-master.
>
> There are two options, one change doc, the other change dts and drivers.
> I think change doc is easiest ways.
>
> If there are v2 in future, we can added silvaco,i3c-master-v2 in future.
>
> If everyone prefer change drivers and dts, I can work on new patch. Just
> break back compatiblity.
No, because Rob explicitly pointed out too generic name.
https://lore.kernel.org/all/20210111200821.GA2978830@robh.at.kernel.org/
Is it some way to avoid implementing feedback or how does it work?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>, Conor Dooley <conor@kernel.org>
Cc: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
joe@perches.com, peng.fan@nxp.com,
alexander.stein@ew.tq-group.com, haibo.chen@nxp.com,
ping.bai@nxp.com, xiaoning.wang@nxp.com, sherry.sun@nxp.com,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string
Date: Mon, 16 Oct 2023 21:57:18 +0200 [thread overview]
Message-ID: <6110c58a-8003-4889-9a4b-6a7d1821c00e@linaro.org> (raw)
In-Reply-To: <ZS2Pz1HxUgrx4+0R@lizhi-Precision-Tower-5810>
On 16/10/2023 21:32, Frank Li wrote:
> On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote:
>> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
>>> In driver, compatible string is silvaco,i3c-master instead of
>>> silvaco,i3c-master-v1.
>>
>> And what makes the driver right & the binding wrong? AFAICT, this is an
>> IP sold by silvaco & the -v1 suffix was explicitly requested during
>> review of the binding.
>
> The driver existed for the long time. DTS files already use
> silvaco,i3c-master.
>
> There are two options, one change doc, the other change dts and drivers.
> I think change doc is easiest ways.
>
> If there are v2 in future, we can added silvaco,i3c-master-v2 in future.
>
> If everyone prefer change drivers and dts, I can work on new patch. Just
> break back compatiblity.
No, because Rob explicitly pointed out too generic name.
https://lore.kernel.org/all/20210111200821.GA2978830@robh.at.kernel.org/
Is it some way to avoid implementing feedback or how does it work?
Best regards,
Krzysztof
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-10-16 19:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 15:24 [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-16 15:24 ` [PATCH 2/2] arm64: dts: freescale: imx93: add i3c1 and i3c2 Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-16 15:24 ` Frank Li
2023-10-17 20:14 ` Rob Herring
2023-10-17 20:14 ` Rob Herring
2023-10-17 20:14 ` Rob Herring
2023-10-16 17:30 ` [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string Conor Dooley
2023-10-16 17:30 ` Conor Dooley
2023-10-16 17:30 ` Conor Dooley
2023-10-16 19:32 ` Frank Li
2023-10-16 19:32 ` Frank Li
2023-10-16 19:32 ` Frank Li
2023-10-16 19:57 ` Krzysztof Kozlowski [this message]
2023-10-16 19:57 ` Krzysztof Kozlowski
2023-10-16 19:57 ` Krzysztof Kozlowski
2023-10-16 20:10 ` Frank Li
2023-10-16 20:10 ` Frank Li
2023-10-16 20:10 ` Frank Li
2023-10-16 20:43 ` Krzysztof Kozlowski
2023-10-16 20:43 ` Krzysztof Kozlowski
2023-10-16 20:43 ` Krzysztof Kozlowski
2023-10-17 14:15 ` Miquel Raynal
2023-10-17 14:15 ` Miquel Raynal
2023-10-17 14:15 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6110c58a-8003-4889-9a4b-6a7d1821c00e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.li@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=conor.culhane@silvaco.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sherry.sun@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.