* [PATCH] dt-bindings: crypto: qcom-qce: document the SM8650 crypto engine
@ 2023-12-12 8:54 ` Om Prakash Singh
0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2023-10-25 7:28 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Thara Gopinath,
Herbert Xu, David S. Miller, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bhupesh Sharma
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, Neil Armstrong
Document the crypto engine on the SM8650 Platform.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
For convenience, a regularly refreshed linux-next based git tree containing
all the SM8650 related work is available at:
https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index 8e665d910e6e..eeb8a956d7cb 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -48,6 +48,7 @@ properties:
- qcom,sm8350-qce
- qcom,sm8450-qce
- qcom,sm8550-qce
+ - qcom,sm8650-qce
- const: qcom,sm8150-qce
- const: qcom,qce
---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231016-topic-sm8650-upstream-bindings-qce-c6ae7eda5cba
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: crypto: qcom-qce: document the SM8650 crypto engine
2023-12-12 8:54 ` Om Prakash Singh
(?)
@ 2023-10-26 21:30 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2023-10-26 21:30 UTC (permalink / raw)
To: Neil Armstrong
Cc: Bjorn Andersson, devicetree, David S. Miller, Thara Gopinath,
Konrad Dybcio, Andy Gross, Rob Herring, linux-arm-msm,
Bhupesh Sharma, linux-crypto, Herbert Xu, linux-kernel,
Conor Dooley, Krzysztof Kozlowski
On Wed, 25 Oct 2023 09:28:22 +0200, Neil Armstrong wrote:
> Document the crypto engine on the SM8650 Platform.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> For convenience, a regularly refreshed linux-next based git tree containing
> all the SM8650 related work is available at:
> https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: crypto: qcom-qce: document the SM8650 crypto engine
2023-12-12 8:54 ` Om Prakash Singh
(?)
(?)
@ 2023-11-17 11:19 ` Herbert Xu
-1 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2023-11-17 11:19 UTC (permalink / raw)
To: Neil Armstrong
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Thara Gopinath,
David S. Miller, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bhupesh Sharma, linux-arm-msm, linux-crypto, devicetree,
linux-kernel
On Wed, Oct 25, 2023 at 09:28:22AM +0200, Neil Armstrong wrote:
> Document the crypto engine on the SM8650 Platform.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> For convenience, a regularly refreshed linux-next based git tree containing
> all the SM8650 related work is available at:
> https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V1 0/2] Add QCrypto support for SC7280
@ 2023-12-12 8:54 Om Prakash Singh
2023-12-12 8:54 ` Om Prakash Singh
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Om Prakash Singh @ 2023-12-12 8:54 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul, cros-qcom-dts-watchers
Document SC7280 support for QCrypto driver and add QCE and Crypto BAM DMA nodes
Om Prakash Singh (2):
dt-bindings: crypto: qcom-qce: document the SC7280 crypto engine
arm64: dts: qcom: sc7280: add QCrypto nodes
.../devicetree/bindings/crypto/qcom-qce.yaml | 1 +
arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 +++++++++++++++++++
2 files changed, 23 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V1 1/2] dt-bindings: crypto: qcom-qce: document the SC7280 crypto engine
2023-12-12 8:54 [PATCH V1 0/2] Add QCrypto support for SC7280 Om Prakash Singh
2023-12-12 8:54 ` Om Prakash Singh
@ 2023-12-12 8:54 ` Om Prakash Singh
2023-12-12 10:01 ` Krzysztof Kozlowski
2023-12-12 8:54 ` [PATCH V1 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes Om Prakash Singh
2 siblings, 1 reply; 10+ messages in thread
From: Om Prakash Singh @ 2023-12-12 8:54 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul, cros-qcom-dts-watchers
Document the crypto engine on the SM7280 Platform.
Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index eeb8a956d7cb..1797699cf454 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -44,6 +44,7 @@ properties:
- items:
- enum:
+ - qcom,sc7280-qce
- qcom,sm8250-qce
- qcom,sm8350-qce
- qcom,sm8450-qce
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH V1 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes
2023-12-12 8:54 [PATCH V1 0/2] Add QCrypto support for SC7280 Om Prakash Singh
2023-12-12 8:54 ` Om Prakash Singh
2023-12-12 8:54 ` [PATCH V1 1/2] dt-bindings: crypto: qcom-qce: document the SC7280 " Om Prakash Singh
@ 2023-12-12 8:54 ` Om Prakash Singh
2023-12-12 10:03 ` Krzysztof Kozlowski
2 siblings, 1 reply; 10+ messages in thread
From: Om Prakash Singh @ 2023-12-12 8:54 UTC (permalink / raw)
To: quic_omprsing
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul, cros-qcom-dts-watchers
Add the QCE and Crypto BAM DMA nodes.
Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 66f1eb83cca7..7b705df21f4e 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 {
status = "disabled";
};
+ cryptobam: dma-controller@1dc4000 {
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+ reg = <0x0 0x01dc4000 0x0 0x28000>;
+ interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ qcom,ee = <0>;
+ qcom,controlled-remotely;
+ iommus = <&apps_smmu 0x4E4 0x0011>,
+ <&apps_smmu 0x4E6 0x0011>;
+ };
+
+ crypto: crypto@1dfa000 {
+ compatible = "qcom,sc7280-qce", "qcom,sm8150-qce", "qcom,qce";
+ reg = <0x0 0x01dfa000 0x0 0x6000>;
+ dmas = <&cryptobam 4>, <&cryptobam 5>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x4E4 0x0011>,
+ <&apps_smmu 0x4E4 0x0011>;
+ interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
+ interconnect-names = "memory";
+ };
+
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
reg = <0 0x01f40000 0 0x20000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] dt-bindings: crypto: qcom-qce: document the SM8650 crypto engine
@ 2023-12-12 8:54 ` Om Prakash Singh
0 siblings, 0 replies; 10+ messages in thread
From: Om Prakash Singh @ 2023-12-12 8:54 UTC (permalink / raw)
To: quic_omprsing, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bhupesh Sharma
Cc: neil.armstrong, devicetree, linux-arm-msm, linux-crypto,
linux-kernel, marijn.suijten, vkoul, cros-qcom-dts-watchers,
Rob Herring
From: Neil Armstrong <neil.armstrong@linaro.org>
Document the crypto engine on the SM8650 Platform.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
---
For convenience, a regularly refreshed linux-next based git tree containing
all the SM8650 related work is available at:
https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
1 file changed, 1 insertion(+)
---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231016-topic-sm8650-upstream-bindings-qce-c6ae7eda5cba
Best regards,
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index 8e665d910e6e..eeb8a956d7cb 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -48,6 +48,7 @@ properties:
- qcom,sm8350-qce
- qcom,sm8450-qce
- qcom,sm8550-qce
+ - qcom,sm8650-qce
- const: qcom,sm8150-qce
- const: qcom,qce
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] dt-bindings: crypto: qcom-qce: document the SM8650 crypto engine
2023-12-12 8:54 ` Om Prakash Singh
` (2 preceding siblings ...)
(?)
@ 2023-12-12 9:46 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-12 9:46 UTC (permalink / raw)
To: Om Prakash Singh, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bhupesh Sharma
Cc: neil.armstrong, devicetree, linux-arm-msm, linux-crypto,
linux-kernel, marijn.suijten, vkoul, cros-qcom-dts-watchers,
Rob Herring
On 12/12/2023 09:54, Om Prakash Singh wrote:
> From: Neil Armstrong <neil.armstrong@linaro.org>
>
> Document the crypto engine on the SM8650 Platform.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
This patch can be ignored. It was already applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V1 1/2] dt-bindings: crypto: qcom-qce: document the SC7280 crypto engine
2023-12-12 8:54 ` [PATCH V1 1/2] dt-bindings: crypto: qcom-qce: document the SC7280 " Om Prakash Singh
@ 2023-12-12 10:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-12 10:01 UTC (permalink / raw)
To: Om Prakash Singh
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul, cros-qcom-dts-watchers
On 12/12/2023 09:54, Om Prakash Singh wrote:
> Document the crypto engine on the SM7280 Platform.
>
> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V1 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes
2023-12-12 8:54 ` [PATCH V1 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes Om Prakash Singh
@ 2023-12-12 10:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-12 10:03 UTC (permalink / raw)
To: Om Prakash Singh
Cc: neil.armstrong, konrad.dybcio, agross, andersson, conor+dt,
davem, devicetree, herbert, krzysztof.kozlowski+dt,
linux-arm-msm, linux-crypto, linux-kernel, marijn.suijten,
robh+dt, vkoul, cros-qcom-dts-watchers
On 12/12/2023 09:54, Om Prakash Singh wrote:
> Add the QCE and Crypto BAM DMA nodes.
>
> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 66f1eb83cca7..7b705df21f4e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 {
> status = "disabled";
> };
>
> + cryptobam: dma-controller@1dc4000 {
Are you sure you placed it in correct place? 1e4 looks higher than 1dc.
> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> + reg = <0x0 0x01dc4000 0x0 0x28000>;
> + interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + qcom,ee = <0>;
> + qcom,controlled-remotely;
These two properties go to the end (vendor properties are after generic
ones).
> + iommus = <&apps_smmu 0x4E4 0x0011>,
> + <&apps_smmu 0x4E6 0x0011>;
Lowercase hex
> + };
> +
> + crypto: crypto@1dfa000 {
> + compatible = "qcom,sc7280-qce", "qcom,sm8150-qce", "qcom,qce";
> + reg = <0x0 0x01dfa000 0x0 0x6000>;
> + dmas = <&cryptobam 4>, <&cryptobam 5>;
> + dma-names = "rx", "tx";
> + iommus = <&apps_smmu 0x4E4 0x0011>,
> + <&apps_smmu 0x4E4 0x0011>;
Lowercase hex
> + interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
> + interconnect-names = "memory";
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-12-12 10:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-12 8:54 [PATCH V1 0/2] Add QCrypto support for SC7280 Om Prakash Singh
2023-10-25 7:28 ` [PATCH] dt-bindings: crypto: qcom-qce: document the SM8650 crypto engine Neil Armstrong
2023-12-12 8:54 ` Om Prakash Singh
2023-10-26 21:30 ` Rob Herring
2023-11-17 11:19 ` Herbert Xu
2023-12-12 9:46 ` Krzysztof Kozlowski
2023-12-12 8:54 ` [PATCH V1 1/2] dt-bindings: crypto: qcom-qce: document the SC7280 " Om Prakash Singh
2023-12-12 10:01 ` Krzysztof Kozlowski
2023-12-12 8:54 ` [PATCH V1 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes Om Prakash Singh
2023-12-12 10:03 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.