* [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
@ 2023-11-12 18:43 Krzysztof Kozlowski
2023-11-12 18:44 ` [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention Krzysztof Kozlowski
` (6 more replies)
0 siblings, 7 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12 18:43 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Compatibles should not use quotes in the bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
index d60626ffb28e..18bf44e06e8f 100644
--- a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
+++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
@@ -12,10 +12,11 @@ maintainers:
properties:
compatible:
enum:
- - "samsung,s5pv210-rotator"
- - "samsung,exynos4210-rotator"
- - "samsung,exynos4212-rotator"
- - "samsung,exynos5250-rotator"
+ - samsung,s5pv210-rotator
+ - samsung,exynos4210-rotator
+ - samsung,exynos4212-rotator
+ - samsung,exynos5250-rotator
+
reg:
maxItems: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
@ 2023-11-12 18:44 ` Krzysztof Kozlowski
2023-11-13 13:50 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12 18:44 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The Devicetree bindings coding convention, as used in most of the files
and expressed in Documentation/devicetree/bindings/example-schema.yaml,
expects "allOf:" block with if-statements after "required:" block.
Re-order few schemas to match the convention to avoid repeating review
comments for new patches using existing code as template. No functional
changes.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/gpu/samsung-g2d.yaml | 53 +++++++++--------
.../bindings/gpu/samsung-scaler.yaml | 59 +++++++++----------
2 files changed, 56 insertions(+), 56 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
index e7daae862578..b6951acc7643 100644
--- a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
+++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
@@ -27,32 +27,6 @@ properties:
iommus: {}
power-domains: {}
-if:
- properties:
- compatible:
- contains:
- const: samsung,exynos5250-g2d
-
-then:
- properties:
- clocks:
- items:
- - description: fimg2d clock
- clock-names:
- items:
- - const: fimg2d
-
-else:
- properties:
- clocks:
- items:
- - description: sclk_fimg2d clock
- - description: fimg2d clock
- clock-names:
- items:
- - const: sclk_fimg2d
- - const: fimg2d
-
required:
- compatible
- reg
@@ -60,6 +34,33 @@ required:
- clocks
- clock-names
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: samsung,exynos5250-g2d
+
+ then:
+ properties:
+ clocks:
+ items:
+ - description: fimg2d clock
+ clock-names:
+ items:
+ - const: fimg2d
+
+ else:
+ properties:
+ clocks:
+ items:
+ - description: sclk_fimg2d clock
+ - description: fimg2d clock
+ clock-names:
+ items:
+ - const: sclk_fimg2d
+ - const: fimg2d
+
additionalProperties: false
examples:
diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
index 5317ac64426a..97d86a002a90 100644
--- a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
+++ b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
@@ -26,36 +26,6 @@ properties:
iommus: {}
power-domains: {}
-if:
- properties:
- compatible:
- contains:
- const: samsung,exynos5420-scaler
-
-then:
- properties:
- clocks:
- items:
- - description: mscl clock
-
- clock-names:
- items:
- - const: mscl
-
-else:
- properties:
- clocks:
- items:
- - description: pclk clock
- - description: aclk clock
- - description: aclk_xiu clock
-
- clock-names:
- items:
- - const: pclk
- - const: aclk
- - const: aclk_xiu
-
required:
- compatible
- reg
@@ -63,6 +33,35 @@ required:
- clocks
- clock-names
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: samsung,exynos5420-scaler
+
+ then:
+ properties:
+ clocks:
+ items:
+ - description: mscl clock
+ clock-names:
+ items:
+ - const: mscl
+
+ else:
+ properties:
+ clocks:
+ items:
+ - description: pclk clock
+ - description: aclk clock
+ - description: aclk_xiu clock
+ clock-names:
+ items:
+ - const: pclk
+ - const: aclk
+ - const: aclk_xiu
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
2023-11-12 18:44 ` [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention Krzysztof Kozlowski
@ 2023-11-12 18:44 ` Krzysztof Kozlowski
2023-11-13 13:51 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains Krzysztof Kozlowski
` (4 subsequent siblings)
6 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12 18:44 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
When number of clock varies between variants, the Devicetree bindings
coding convention expects to have widest constraints in top-level
definition of the properties and narrow them in allOf:if:then block.
This is more readable and sometimes allows to spot some errors in the
bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/gpu/samsung-g2d.yaml | 10 ++++++++--
.../devicetree/bindings/gpu/samsung-scaler.yaml | 10 ++++++++--
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
index b6951acc7643..f368966cf83a 100644
--- a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
+++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
@@ -22,8 +22,14 @@ properties:
interrupts:
maxItems: 1
- clocks: {}
- clock-names: {}
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ minItems: 1
+ maxItems: 2
+
iommus: {}
power-domains: {}
diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
index 97d86a002a90..e08fc1e4115f 100644
--- a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
+++ b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
@@ -21,8 +21,14 @@ properties:
interrupts:
maxItems: 1
- clocks: {}
- clock-names: {}
+ clocks:
+ minItems: 1
+ maxItems: 3
+
+ clock-names:
+ minItems: 1
+ maxItems: 3
+
iommus: {}
power-domains: {}
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
2023-11-12 18:44 ` [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention Krzysztof Kozlowski
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
@ 2023-11-12 18:44 ` Krzysztof Kozlowski
2023-11-13 13:49 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 5/5] dt-bindings: gpu: samsung-scaler: " Krzysztof Kozlowski
` (3 subsequent siblings)
6 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12 18:44 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Provide specific constraints for iommus and power-domains, based on
current DTS.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/gpu/samsung-g2d.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
index f368966cf83a..132aaa49597b 100644
--- a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
+++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
@@ -30,8 +30,12 @@ properties:
minItems: 1
maxItems: 2
- iommus: {}
- power-domains: {}
+ iommus:
+ minItems: 1
+ maxItems: 2
+
+ power-domains:
+ maxItems: 1
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH 5/5] dt-bindings: gpu: samsung-scaler: constrain iommus and power-domains
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-11-12 18:44 ` [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains Krzysztof Kozlowski
@ 2023-11-12 18:44 ` Krzysztof Kozlowski
2023-11-13 13:49 ` Conor Dooley
2023-11-13 13:48 ` Conor Dooley
` (2 subsequent siblings)
6 siblings, 1 reply; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-12 18:44 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Provide specific constraints for iommus and power-domains, based on
current DTS.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/gpu/samsung-scaler.yaml | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
index e08fc1e4115f..9fb530e65d0e 100644
--- a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
+++ b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
@@ -29,8 +29,12 @@ properties:
minItems: 1
maxItems: 3
- iommus: {}
- power-domains: {}
+ iommus:
+ minItems: 1
+ maxItems: 2
+
+ power-domains:
+ maxItems: 1
required:
- compatible
@@ -54,6 +58,8 @@ allOf:
clock-names:
items:
- const: mscl
+ iommus:
+ minItems: 2
else:
properties:
@@ -67,6 +73,8 @@ allOf:
- const: pclk
- const: aclk
- const: aclk_xiu
+ iommus:
+ maxItems: 1
additionalProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
@ 2023-11-13 13:48 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote:
> Compatibles should not use quotes in the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers…
Conor.
> ---
> .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
> index d60626ffb28e..18bf44e06e8f 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
> +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
> @@ -12,10 +12,11 @@ maintainers:
> properties:
> compatible:
> enum:
> - - "samsung,s5pv210-rotator"
> - - "samsung,exynos4210-rotator"
> - - "samsung,exynos4212-rotator"
> - - "samsung,exynos5250-rotator"
> + - samsung,s5pv210-rotator
> + - samsung,exynos4210-rotator
> + - samsung,exynos4212-rotator
> + - samsung,exynos5250-rotator
> +
> reg:
> maxItems: 1
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
@ 2023-11-13 13:48 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski,
linux-kernel, Maxime Ripard, Rob Herring, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote:
> Compatibles should not use quotes in the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers…
Conor.
> ---
> .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
> index d60626ffb28e..18bf44e06e8f 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
> +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml
> @@ -12,10 +12,11 @@ maintainers:
> properties:
> compatible:
> enum:
> - - "samsung,s5pv210-rotator"
> - - "samsung,exynos4210-rotator"
> - - "samsung,exynos4212-rotator"
> - - "samsung,exynos5250-rotator"
> + - samsung,s5pv210-rotator
> + - samsung,exynos4210-rotator
> + - samsung,exynos4212-rotator
> + - samsung,exynos5250-rotator
> +
> reg:
> maxItems: 1
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 5/5] dt-bindings: gpu: samsung-scaler: constrain iommus and power-domains
2023-11-12 18:44 ` [PATCH 5/5] dt-bindings: gpu: samsung-scaler: " Krzysztof Kozlowski
@ 2023-11-13 13:49 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
On Sun, Nov 12, 2023 at 07:44:03PM +0100, Krzysztof Kozlowski wrote:
> Provide specific constraints for iommus and power-domains, based on
> current DTS.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 5/5] dt-bindings: gpu: samsung-scaler: constrain iommus and power-domains
@ 2023-11-13 13:49 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski,
linux-kernel, Maxime Ripard, Rob Herring, dri-devel
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
On Sun, Nov 12, 2023 at 07:44:03PM +0100, Krzysztof Kozlowski wrote:
> Provide specific constraints for iommus and power-domains, based on
> current DTS.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains
2023-11-12 18:44 ` [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains Krzysztof Kozlowski
@ 2023-11-13 13:49 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Sun, Nov 12, 2023 at 07:44:02PM +0100, Krzysztof Kozlowski wrote:
> Provide specific constraints for iommus and power-domains, based on
> current DTS.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains
@ 2023-11-13 13:49 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski,
linux-kernel, Maxime Ripard, Rob Herring, dri-devel
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Sun, Nov 12, 2023 at 07:44:02PM +0100, Krzysztof Kozlowski wrote:
> Provide specific constraints for iommus and power-domains, based on
> current DTS.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention
2023-11-12 18:44 ` [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention Krzysztof Kozlowski
@ 2023-11-13 13:50 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 4418 bytes --]
On Sun, Nov 12, 2023 at 07:44:00PM +0100, Krzysztof Kozlowski wrote:
> The Devicetree bindings coding convention, as used in most of the files
> and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> expects "allOf:" block with if-statements after "required:" block.
>
> Re-order few schemas to match the convention to avoid repeating review
> comments for new patches using existing code as template. No functional
> changes.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
thanks,
Conor,
> ---
> .../devicetree/bindings/gpu/samsung-g2d.yaml | 53 +++++++++--------
> .../bindings/gpu/samsung-scaler.yaml | 59 +++++++++----------
> 2 files changed, 56 insertions(+), 56 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> index e7daae862578..b6951acc7643 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> @@ -27,32 +27,6 @@ properties:
> iommus: {}
> power-domains: {}
>
> -if:
> - properties:
> - compatible:
> - contains:
> - const: samsung,exynos5250-g2d
> -
> -then:
> - properties:
> - clocks:
> - items:
> - - description: fimg2d clock
> - clock-names:
> - items:
> - - const: fimg2d
> -
> -else:
> - properties:
> - clocks:
> - items:
> - - description: sclk_fimg2d clock
> - - description: fimg2d clock
> - clock-names:
> - items:
> - - const: sclk_fimg2d
> - - const: fimg2d
> -
> required:
> - compatible
> - reg
> @@ -60,6 +34,33 @@ required:
> - clocks
> - clock-names
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: samsung,exynos5250-g2d
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: fimg2d clock
> + clock-names:
> + items:
> + - const: fimg2d
> +
> + else:
> + properties:
> + clocks:
> + items:
> + - description: sclk_fimg2d clock
> + - description: fimg2d clock
> + clock-names:
> + items:
> + - const: sclk_fimg2d
> + - const: fimg2d
> +
> additionalProperties: false
>
> examples:
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
> index 5317ac64426a..97d86a002a90 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
> +++ b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
> @@ -26,36 +26,6 @@ properties:
> iommus: {}
> power-domains: {}
>
> -if:
> - properties:
> - compatible:
> - contains:
> - const: samsung,exynos5420-scaler
> -
> -then:
> - properties:
> - clocks:
> - items:
> - - description: mscl clock
> -
> - clock-names:
> - items:
> - - const: mscl
> -
> -else:
> - properties:
> - clocks:
> - items:
> - - description: pclk clock
> - - description: aclk clock
> - - description: aclk_xiu clock
> -
> - clock-names:
> - items:
> - - const: pclk
> - - const: aclk
> - - const: aclk_xiu
> -
> required:
> - compatible
> - reg
> @@ -63,6 +33,35 @@ required:
> - clocks
> - clock-names
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: samsung,exynos5420-scaler
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: mscl clock
> + clock-names:
> + items:
> + - const: mscl
> +
> + else:
> + properties:
> + clocks:
> + items:
> + - description: pclk clock
> + - description: aclk clock
> + - description: aclk_xiu clock
> + clock-names:
> + items:
> + - const: pclk
> + - const: aclk
> + - const: aclk_xiu
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention
@ 2023-11-13 13:50 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski,
linux-kernel, Maxime Ripard, Rob Herring, dri-devel
[-- Attachment #1: Type: text/plain, Size: 4418 bytes --]
On Sun, Nov 12, 2023 at 07:44:00PM +0100, Krzysztof Kozlowski wrote:
> The Devicetree bindings coding convention, as used in most of the files
> and expressed in Documentation/devicetree/bindings/example-schema.yaml,
> expects "allOf:" block with if-statements after "required:" block.
>
> Re-order few schemas to match the convention to avoid repeating review
> comments for new patches using existing code as template. No functional
> changes.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
thanks,
Conor,
> ---
> .../devicetree/bindings/gpu/samsung-g2d.yaml | 53 +++++++++--------
> .../bindings/gpu/samsung-scaler.yaml | 59 +++++++++----------
> 2 files changed, 56 insertions(+), 56 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> index e7daae862578..b6951acc7643 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.yaml
> @@ -27,32 +27,6 @@ properties:
> iommus: {}
> power-domains: {}
>
> -if:
> - properties:
> - compatible:
> - contains:
> - const: samsung,exynos5250-g2d
> -
> -then:
> - properties:
> - clocks:
> - items:
> - - description: fimg2d clock
> - clock-names:
> - items:
> - - const: fimg2d
> -
> -else:
> - properties:
> - clocks:
> - items:
> - - description: sclk_fimg2d clock
> - - description: fimg2d clock
> - clock-names:
> - items:
> - - const: sclk_fimg2d
> - - const: fimg2d
> -
> required:
> - compatible
> - reg
> @@ -60,6 +34,33 @@ required:
> - clocks
> - clock-names
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: samsung,exynos5250-g2d
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: fimg2d clock
> + clock-names:
> + items:
> + - const: fimg2d
> +
> + else:
> + properties:
> + clocks:
> + items:
> + - description: sclk_fimg2d clock
> + - description: fimg2d clock
> + clock-names:
> + items:
> + - const: sclk_fimg2d
> + - const: fimg2d
> +
> additionalProperties: false
>
> examples:
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
> index 5317ac64426a..97d86a002a90 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
> +++ b/Documentation/devicetree/bindings/gpu/samsung-scaler.yaml
> @@ -26,36 +26,6 @@ properties:
> iommus: {}
> power-domains: {}
>
> -if:
> - properties:
> - compatible:
> - contains:
> - const: samsung,exynos5420-scaler
> -
> -then:
> - properties:
> - clocks:
> - items:
> - - description: mscl clock
> -
> - clock-names:
> - items:
> - - const: mscl
> -
> -else:
> - properties:
> - clocks:
> - items:
> - - description: pclk clock
> - - description: aclk clock
> - - description: aclk_xiu clock
> -
> - clock-names:
> - items:
> - - const: pclk
> - - const: aclk
> - - const: aclk_xiu
> -
> required:
> - compatible
> - reg
> @@ -63,6 +33,35 @@ required:
> - clocks
> - clock-names
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: samsung,exynos5420-scaler
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: mscl clock
> + clock-names:
> + items:
> + - const: mscl
> +
> + else:
> + properties:
> + clocks:
> + items:
> + - description: pclk clock
> + - description: aclk clock
> + - description: aclk_xiu clock
> + clock-names:
> + items:
> + - const: pclk
> + - const: aclk
> + - const: aclk_xiu
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
@ 2023-11-13 13:51 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Inki Dae, dri-devel, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> When number of clock varies between variants, the Devicetree bindings
> coding convention expects to have widest constraints in top-level
> definition of the properties and narrow them in allOf:if:then block.
>
> This is more readable and sometimes allows to spot some errors in the
> bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Åcked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
@ 2023-11-13 13:51 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-13 13:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski,
linux-kernel, Maxime Ripard, Rob Herring, dri-devel
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> When number of clock varies between variants, the Devicetree bindings
> coding convention expects to have widest constraints in top-level
> definition of the properties and narrow them in allOf:if:then block.
>
> This is more readable and sometimes allows to spot some errors in the
> bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Åcked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
@ 2023-11-14 15:21 ` Rob Herring
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 0 replies; 25+ messages in thread
From: Rob Herring @ 2023-11-14 15:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Krzysztof Kozlowski, Conor Dooley,
Inki Dae, dri-devel, devicetree, linux-kernel
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote:
> Compatibles should not use quotes in the bindings.
Unfortunately yamllint skips checking these due to a bug handling
bracketed lists. There's an open issue for it[1].
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
[1] https://github.com/adrienverge/yamllint/issues/516
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
@ 2023-11-14 15:21 ` Rob Herring
0 siblings, 0 replies; 25+ messages in thread
From: Rob Herring @ 2023-11-14 15:21 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Conor Dooley, Krzysztof Kozlowski, Thomas Zimmermann,
linux-kernel, Maxime Ripard, dri-devel
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote:
> Compatibles should not use quotes in the bindings.
Unfortunately yamllint skips checking these due to a bug handling
bracketed lists. There's an open issue for it[1].
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
[1] https://github.com/adrienverge/yamllint/issues/516
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
2023-11-13 13:51 ` Conor Dooley
@ 2023-11-16 16:28 ` Rob Herring
-1 siblings, 0 replies; 25+ messages in thread
From: Rob Herring @ 2023-11-16 16:28 UTC (permalink / raw)
To: Conor Dooley
Cc: Krzysztof Kozlowski, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, Conor Dooley, Inki Dae, dri-devel,
devicetree, linux-kernel
On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> > When number of clock varies between variants, the Devicetree bindings
> > coding convention expects to have widest constraints in top-level
> > definition of the properties and narrow them in allOf:if:then block.
> >
> > This is more readable and sometimes allows to spot some errors in the
> > bindings.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
^
Not an 'A'. I only caught this because I go thru everything
Acked/Reviewed-by first and this one was missed.
Rob
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
@ 2023-11-16 16:28 ` Rob Herring
0 siblings, 0 replies; 25+ messages in thread
From: Rob Herring @ 2023-11-16 16:28 UTC (permalink / raw)
To: Conor Dooley
Cc: devicetree, Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski,
linux-kernel, Maxime Ripard, Krzysztof Kozlowski, dri-devel
On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> > When number of clock varies between variants, the Devicetree bindings
> > coding convention expects to have widest constraints in top-level
> > definition of the properties and narrow them in allOf:if:then block.
> >
> > This is more readable and sometimes allows to spot some errors in the
> > bindings.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
^
Not an 'A'. I only caught this because I go thru everything
Acked/Reviewed-by first and this one was missed.
Rob
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
2023-11-16 16:28 ` Rob Herring
@ 2023-11-16 17:17 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-16 17:17 UTC (permalink / raw)
To: Rob Herring, Conor Dooley
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Krzysztof Kozlowski, Conor Dooley,
Inki Dae, dri-devel, devicetree, linux-kernel
On 16/11/2023 17:28, Rob Herring wrote:
> On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
>> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
>>> When number of clock varies between variants, the Devicetree bindings
>>> coding convention expects to have widest constraints in top-level
>>> definition of the properties and narrow them in allOf:if:then block.
>>>
>>> This is more readable and sometimes allows to spot some errors in the
>>> bindings.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>>
>> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
>
> ^
>
> Not an 'A'. I only caught this because I go thru everything
> Acked/Reviewed-by first and this one was missed.
And in Norwegian it is pronounced as "o", so this would be ocked-by :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
@ 2023-11-16 17:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 25+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-16 17:17 UTC (permalink / raw)
To: Rob Herring, Conor Dooley
Cc: devicetree, Conor Dooley, Krzysztof Kozlowski, Thomas Zimmermann,
linux-kernel, Maxime Ripard, dri-devel
On 16/11/2023 17:28, Rob Herring wrote:
> On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
>> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
>>> When number of clock varies between variants, the Devicetree bindings
>>> coding convention expects to have widest constraints in top-level
>>> definition of the properties and narrow them in allOf:if:then block.
>>>
>>> This is more readable and sometimes allows to spot some errors in the
>>> bindings.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>>
>> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
>
> ^
>
> Not an 'A'. I only caught this because I go thru everything
> Acked/Reviewed-by first and this one was missed.
And in Norwegian it is pronounced as "o", so this would be ocked-by :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
2023-11-16 17:17 ` Krzysztof Kozlowski
@ 2023-11-16 17:24 ` Conor Dooley
-1 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-16 17:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Krzysztof Kozlowski, Conor Dooley,
Inki Dae, dri-devel, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]
On Thu, Nov 16, 2023 at 06:17:31PM +0100, Krzysztof Kozlowski wrote:
> On 16/11/2023 17:28, Rob Herring wrote:
> > On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
> >> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> >>> When number of clock varies between variants, the Devicetree bindings
> >>> coding convention expects to have widest constraints in top-level
> >>> definition of the properties and narrow them in allOf:if:then block.
> >>>
> >>> This is more readable and sometimes allows to spot some errors in the
> >>> bindings.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >>
> >> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > ^
> >
> > Not an 'A'. I only caught this because I go thru everything
> > Acked/Reviewed-by first and this one was missed.
>
> And in Norwegian it is pronounced as "o", so this would be ocked-by :)
What on earth! The fedora install on this macbook I've been travelling
with does some odd things (clearly there's some setting I need to
disable) if I type something incorrectly and hit a backspace, but I use
a vim keybind to "type" my acks etc, so I am not sure that could have
been affected. FWIW,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
@ 2023-11-16 17:24 ` Conor Dooley
0 siblings, 0 replies; 25+ messages in thread
From: Conor Dooley @ 2023-11-16 17:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski, devicetree,
linux-kernel, Maxime Ripard, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]
On Thu, Nov 16, 2023 at 06:17:31PM +0100, Krzysztof Kozlowski wrote:
> On 16/11/2023 17:28, Rob Herring wrote:
> > On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
> >> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> >>> When number of clock varies between variants, the Devicetree bindings
> >>> coding convention expects to have widest constraints in top-level
> >>> definition of the properties and narrow them in allOf:if:then block.
> >>>
> >>> This is more readable and sometimes allows to spot some errors in the
> >>> bindings.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >>
> >> Åcked-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > ^
> >
> > Not an 'A'. I only caught this because I go thru everything
> > Acked/Reviewed-by first and this one was missed.
>
> And in Norwegian it is pronounced as "o", so this would be ocked-by :)
What on earth! The fedora install on this macbook I've been travelling
with does some odd things (clearly there's some setting I need to
disable) if I type something incorrectly and hit a backspace, but I use
a vim keybind to "type" my acks etc, so I am not sure that could have
been affected. FWIW,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
@ 2023-12-08 13:20 ` Rob Herring
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 0 replies; 25+ messages in thread
From: Rob Herring @ 2023-12-08 13:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, Maxime Ripard, Conor Dooley, Inki Dae, devicetree,
dri-devel, Daniel Vetter, Thomas Zimmermann, Krzysztof Kozlowski,
Rob Herring, Maarten Lankhorst, David Airlie
On Sun, 12 Nov 2023 19:43:59 +0100, Krzysztof Kozlowski wrote:
> Compatibles should not use quotes in the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes
@ 2023-12-08 13:20 ` Rob Herring
0 siblings, 0 replies; 25+ messages in thread
From: Rob Herring @ 2023-12-08 13:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Conor Dooley, Thomas Zimmermann, Krzysztof Kozlowski,
linux-kernel, dri-devel, Rob Herring, Maxime Ripard
On Sun, 12 Nov 2023 19:43:59 +0100, Krzysztof Kozlowski wrote:
> Compatibles should not use quotes in the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2023-12-08 13:20 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
2023-11-12 18:44 ` [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention Krzysztof Kozlowski
2023-11-13 13:50 ` Conor Dooley
2023-11-13 13:50 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
2023-11-13 13:51 ` Conor Dooley
2023-11-13 13:51 ` Conor Dooley
2023-11-16 16:28 ` Rob Herring
2023-11-16 16:28 ` Rob Herring
2023-11-16 17:17 ` Krzysztof Kozlowski
2023-11-16 17:17 ` Krzysztof Kozlowski
2023-11-16 17:24 ` Conor Dooley
2023-11-16 17:24 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains Krzysztof Kozlowski
2023-11-13 13:49 ` Conor Dooley
2023-11-13 13:49 ` Conor Dooley
2023-11-12 18:44 ` [PATCH 5/5] dt-bindings: gpu: samsung-scaler: " Krzysztof Kozlowski
2023-11-13 13:49 ` Conor Dooley
2023-11-13 13:49 ` Conor Dooley
2023-11-13 13:48 ` [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Conor Dooley
2023-11-13 13:48 ` Conor Dooley
2023-11-14 15:21 ` Rob Herring
2023-11-14 15:21 ` Rob Herring
2023-12-08 13:20 ` Rob Herring
2023-12-08 13:20 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.