* [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes
@ 2023-10-30 18:32 Fabio Estevam
2023-10-30 19:35 ` Tim Harvey
2023-11-27 3:20 ` Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Fabio Estevam @ 2023-10-30 18:32 UTC (permalink / raw)
To: shawnguo; +Cc: tharvey, linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Several schema warnings are seen when running:
make dtbs_check DT_SCHEMA_FILES=pci-bus.yaml
Fix them.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
.../dts/freescale/imx8mm-venice-gw72xx.dtsi | 30 ++++++++++++-------
.../dts/freescale/imx8mm-venice-gw73xx.dtsi | 30 ++++++++++++-------
.../dts/freescale/imx8mm-venice-gw7902.dts | 14 +++++----
3 files changed, 47 insertions(+), 27 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
index 3a0a10e835a2..02807c5fc979 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
@@ -152,23 +152,31 @@ &pcie0 {
pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
- pcie@1,0 {
+ pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
- pcie@2,3 {
+ pcie@3,0 {
reg = <0x1800 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
- eth1: pcie@5,0 {
+ eth1: pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
local-mac-address = [00 00 00 00 00 00];
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index 4f859d0fec69..7830b724ccd8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -172,23 +172,31 @@ &pcie0 {
pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
- pcie@1,0 {
+ pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
- pcie@2,4 {
+ pcie@4,0 {
reg = <0x2000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
- eth1: pcie@6,0 {
+ eth1: pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
local-mac-address = [00 00 00 00 00 00];
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index 06a394a41d7c..7ef17c2b0e9d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -635,13 +635,17 @@ &pcie0 {
pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
- eth1: pcie@1,0 {
+ eth1: pcie@0,0 {
reg = <0x0000 0 0 0 0>;
- #address-cells = <1>;
- #size-cells = <0>;
+ device_type = "pci";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ ranges;
local-mac-address = [00 00 00 00 00 00];
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes
2023-10-30 18:32 [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes Fabio Estevam
@ 2023-10-30 19:35 ` Tim Harvey
2023-11-27 3:20 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Tim Harvey @ 2023-10-30 19:35 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawnguo, linux-arm-kernel, Fabio Estevam
On Mon, Oct 30, 2023 at 11:32 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> Several schema warnings are seen when running:
>
> make dtbs_check DT_SCHEMA_FILES=pci-bus.yaml
>
> Fix them.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> .../dts/freescale/imx8mm-venice-gw72xx.dtsi | 30 ++++++++++++-------
> .../dts/freescale/imx8mm-venice-gw73xx.dtsi | 30 ++++++++++++-------
> .../dts/freescale/imx8mm-venice-gw7902.dts | 14 +++++----
> 3 files changed, 47 insertions(+), 27 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> index 3a0a10e835a2..02807c5fc979 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> @@ -152,23 +152,31 @@ &pcie0 {
>
> pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> - pcie@1,0 {
> + pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> - pcie@2,3 {
> + pcie@3,0 {
> reg = <0x1800 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> - eth1: pcie@5,0 {
> + eth1: pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> local-mac-address = [00 00 00 00 00 00];
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> index 4f859d0fec69..7830b724ccd8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> @@ -172,23 +172,31 @@ &pcie0 {
>
> pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> - pcie@1,0 {
> + pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> - pcie@2,4 {
> + pcie@4,0 {
> reg = <0x2000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> - eth1: pcie@6,0 {
> + eth1: pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> local-mac-address = [00 00 00 00 00 00];
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> index 06a394a41d7c..7ef17c2b0e9d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> @@ -635,13 +635,17 @@ &pcie0 {
>
> pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> - eth1: pcie@1,0 {
> + eth1: pcie@0,0 {
> reg = <0x0000 0 0 0 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + ranges;
>
> local-mac-address = [00 00 00 00 00 00];
> };
> --
> 2.34.1
>
Acked-by: Tim Harvey <tharvey@gateworks.com>
Best Regards,
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes
2023-10-30 18:32 [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes Fabio Estevam
2023-10-30 19:35 ` Tim Harvey
@ 2023-11-27 3:20 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2023-11-27 3:20 UTC (permalink / raw)
To: Fabio Estevam; +Cc: tharvey, linux-arm-kernel, Fabio Estevam
On Mon, Oct 30, 2023 at 03:32:13PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Several schema warnings are seen when running:
>
> make dtbs_check DT_SCHEMA_FILES=pci-bus.yaml
>
> Fix them.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes
2023-12-05 18:22 ` Tim Harvey
@ 2023-12-05 18:57 ` Fabio Estevam
-1 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2023-12-05 18:57 UTC (permalink / raw)
To: Tim Harvey
Cc: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, linux-kernel
Hi Tim,
On Tue, Dec 5, 2023 at 3:22 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> Several schema warnings were fixed in commit
> d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
> however the node names and the ethernet NIC node were not quite correct.
>
> Fix the node names as the ethernet device should have a node name of
> 'ethernet' and remove the device_type, #address-cells, #size-cells, and
> ranges properties that should only be on busses/bridges.
I sent this one to address the remaining issues:
https://lore.kernel.org/linux-devicetree/20231130225242.988336-1-festevam@gmail.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes
@ 2023-12-05 18:57 ` Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2023-12-05 18:57 UTC (permalink / raw)
To: Tim Harvey
Cc: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel, linux-kernel
Hi Tim,
On Tue, Dec 5, 2023 at 3:22 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> Several schema warnings were fixed in commit
> d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
> however the node names and the ethernet NIC node were not quite correct.
>
> Fix the node names as the ethernet device should have a node name of
> 'ethernet' and remove the device_type, #address-cells, #size-cells, and
> ranges properties that should only be on busses/bridges.
I sent this one to address the remaining issues:
https://lore.kernel.org/linux-devicetree/20231130225242.988336-1-festevam@gmail.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes
@ 2023-12-05 18:22 ` Tim Harvey
0 siblings, 0 replies; 7+ messages in thread
From: Tim Harvey @ 2023-12-05 18:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel, Tim Harvey
Several schema warnings were fixed in commit
d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
however the node names and the ethernet NIC node were not quite correct.
Fix the node names as the ethernet device should have a node name of
'ethernet' and remove the device_type, #address-cells, #size-cells, and
ranges properties that should only be on busses/bridges.
Fixes: d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../dts/freescale/imx8mm-venice-gw72xx.dtsi | 18 +++++++-----------
.../dts/freescale/imx8mm-venice-gw73xx.dtsi | 18 +++++++-----------
.../dts/freescale/imx8mm-venice-gw7902.dts | 10 +++-------
3 files changed, 17 insertions(+), 29 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
index a337e8f20441..31f16f7cf37c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
@@ -157,33 +157,29 @@ &pcie0 {
<&clk IMX8MM_SYS_PLL2_250M>;
status = "okay";
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@3,0 {
- reg = <0x1800 0 0 0 0>;
+ pcie@3 {
device_type = "pci";
+ reg = <0x1800 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- eth1: pcie@0,0 {
+ eth1: ethernet@0 {
reg = <0x0000 0 0 0 0>;
- device_type = "pci";
- #address-cells = <3>;
- #size-cells = <2>;
- ranges;
local-mac-address = [00 00 00 00 00 00];
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index 2247d1c4e2af..6f5a6d91c95e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -177,33 +177,29 @@ &pcie0 {
<&clk IMX8MM_SYS_PLL2_250M>;
status = "okay";
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@4,0 {
- reg = <0x2000 0 0 0 0>;
+ pcie@4 {
device_type = "pci";
+ reg = <0x2000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- eth1: pcie@0,0 {
+ eth1: ethernet@0 {
reg = <0x0000 0 0 0 0>;
- device_type = "pci";
- #address-cells = <3>;
- #size-cells = <2>;
- ranges;
local-mac-address = [00 00 00 00 00 00];
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index 7ef17c2b0e9d..4bb22fdc5d2e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -633,19 +633,15 @@ &pcie0 {
<&clk IMX8MM_SYS_PLL2_250M>;
status = "okay";
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- eth1: pcie@0,0 {
+ eth1: ethernet@0 {
reg = <0x0000 0 0 0 0>;
- device_type = "pci";
- #address-cells = <3>;
- #size-cells = <2>;
- ranges;
local-mac-address = [00 00 00 00 00 00];
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes
@ 2023-12-05 18:22 ` Tim Harvey
0 siblings, 0 replies; 7+ messages in thread
From: Tim Harvey @ 2023-12-05 18:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel, Tim Harvey
Several schema warnings were fixed in commit
d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
however the node names and the ethernet NIC node were not quite correct.
Fix the node names as the ethernet device should have a node name of
'ethernet' and remove the device_type, #address-cells, #size-cells, and
ranges properties that should only be on busses/bridges.
Fixes: d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../dts/freescale/imx8mm-venice-gw72xx.dtsi | 18 +++++++-----------
.../dts/freescale/imx8mm-venice-gw73xx.dtsi | 18 +++++++-----------
.../dts/freescale/imx8mm-venice-gw7902.dts | 10 +++-------
3 files changed, 17 insertions(+), 29 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
index a337e8f20441..31f16f7cf37c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
@@ -157,33 +157,29 @@ &pcie0 {
<&clk IMX8MM_SYS_PLL2_250M>;
status = "okay";
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@3,0 {
- reg = <0x1800 0 0 0 0>;
+ pcie@3 {
device_type = "pci";
+ reg = <0x1800 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- eth1: pcie@0,0 {
+ eth1: ethernet@0 {
reg = <0x0000 0 0 0 0>;
- device_type = "pci";
- #address-cells = <3>;
- #size-cells = <2>;
- ranges;
local-mac-address = [00 00 00 00 00 00];
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index 2247d1c4e2af..6f5a6d91c95e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -177,33 +177,29 @@ &pcie0 {
<&clk IMX8MM_SYS_PLL2_250M>;
status = "okay";
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- pcie@4,0 {
- reg = <0x2000 0 0 0 0>;
+ pcie@4 {
device_type = "pci";
+ reg = <0x2000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- eth1: pcie@0,0 {
+ eth1: ethernet@0 {
reg = <0x0000 0 0 0 0>;
- device_type = "pci";
- #address-cells = <3>;
- #size-cells = <2>;
- ranges;
local-mac-address = [00 00 00 00 00 00];
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index 7ef17c2b0e9d..4bb22fdc5d2e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -633,19 +633,15 @@ &pcie0 {
<&clk IMX8MM_SYS_PLL2_250M>;
status = "okay";
- pcie@0,0 {
- reg = <0x0000 0 0 0 0>;
+ pcie@0 {
device_type = "pci";
+ reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
ranges;
- eth1: pcie@0,0 {
+ eth1: ethernet@0 {
reg = <0x0000 0 0 0 0>;
- device_type = "pci";
- #address-cells = <3>;
- #size-cells = <2>;
- ranges;
local-mac-address = [00 00 00 00 00 00];
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-05 18:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-30 18:32 [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes Fabio Estevam
2023-10-30 19:35 ` Tim Harvey
2023-11-27 3:20 ` Shawn Guo
2023-12-05 18:22 Tim Harvey
2023-12-05 18:22 ` Tim Harvey
2023-12-05 18:57 ` Fabio Estevam
2023-12-05 18:57 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.