All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Intel Graphics <intel-gfx@lists.freedesktop.org>,
	DRI <dri-devel@lists.freedesktop.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Imre Deak <imre.deak@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the drm-intel tree with Linus' tree
Date: Tue, 9 Jan 2024 11:22:54 +1100	[thread overview]
Message-ID: <20240109112254.405d3a1a@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

Hi all,

Today's linux-next merge of the drm-intel tree got a conflict in:

  drivers/gpu/drm/i915/display/intel_dp.c

between commit:

  fc93835bb0d7 ("drm: Add HPD state to drm_connector_oob_hotplug_event()")

from Linus' tree and commit:

  cd572b3bb27e ("drm/i915: Disable hotplug detection works during driver init/shutdown")

from the drm-intel tree.

I fixed it up (maybe, see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpu/drm/i915/display/intel_dp.c
index 7d2b8ce48fda,93f9985ef75c..000000000000
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@@ -6040,21 -6062,11 +6059,21 @@@ static void intel_dp_oob_hotplug_event(
  {
  	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
  	struct drm_i915_private *i915 = to_i915(connector->dev);
 +	bool hpd_high = hpd_state == connector_status_connected;
 +	unsigned int hpd_pin = encoder->hpd_pin;
 +	bool need_work = false;
  
  	spin_lock_irq(&i915->irq_lock);
 -	i915->display.hotplug.event_bits |= BIT(encoder->hpd_pin);
 +	if (hpd_high != test_bit(hpd_pin, &i915->display.hotplug.oob_hotplug_last_state)) {
 +		i915->display.hotplug.event_bits |= BIT(hpd_pin);
 +
 +		__assign_bit(hpd_pin, &i915->display.hotplug.oob_hotplug_last_state, hpd_high);
 +		need_work = true;
 +	}
  	spin_unlock_irq(&i915->irq_lock);
 -	intel_hpd_schedule_detection(i915);
 +
 +	if (need_work)
- 		queue_delayed_work(i915->unordered_wq, &i915->display.hotplug.hotplug_work, 0);
++		intel_hpd_schedule_detection(i915);
  }
  
  static const struct drm_connector_funcs intel_dp_connector_funcs = {

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Intel Graphics <intel-gfx@lists.freedesktop.org>,
	DRI <dri-devel@lists.freedesktop.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: linux-next: manual merge of the drm-intel tree with Linus' tree
Date: Tue, 9 Jan 2024 11:22:54 +1100	[thread overview]
Message-ID: <20240109112254.405d3a1a@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

Hi all,

Today's linux-next merge of the drm-intel tree got a conflict in:

  drivers/gpu/drm/i915/display/intel_dp.c

between commit:

  fc93835bb0d7 ("drm: Add HPD state to drm_connector_oob_hotplug_event()")

from Linus' tree and commit:

  cd572b3bb27e ("drm/i915: Disable hotplug detection works during driver init/shutdown")

from the drm-intel tree.

I fixed it up (maybe, see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpu/drm/i915/display/intel_dp.c
index 7d2b8ce48fda,93f9985ef75c..000000000000
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@@ -6040,21 -6062,11 +6059,21 @@@ static void intel_dp_oob_hotplug_event(
  {
  	struct intel_encoder *encoder = intel_attached_encoder(to_intel_connector(connector));
  	struct drm_i915_private *i915 = to_i915(connector->dev);
 +	bool hpd_high = hpd_state == connector_status_connected;
 +	unsigned int hpd_pin = encoder->hpd_pin;
 +	bool need_work = false;
  
  	spin_lock_irq(&i915->irq_lock);
 -	i915->display.hotplug.event_bits |= BIT(encoder->hpd_pin);
 +	if (hpd_high != test_bit(hpd_pin, &i915->display.hotplug.oob_hotplug_last_state)) {
 +		i915->display.hotplug.event_bits |= BIT(hpd_pin);
 +
 +		__assign_bit(hpd_pin, &i915->display.hotplug.oob_hotplug_last_state, hpd_high);
 +		need_work = true;
 +	}
  	spin_unlock_irq(&i915->irq_lock);
 -	intel_hpd_schedule_detection(i915);
 +
 +	if (need_work)
- 		queue_delayed_work(i915->unordered_wq, &i915->display.hotplug.hotplug_work, 0);
++		intel_hpd_schedule_detection(i915);
  }
  
  static const struct drm_connector_funcs intel_dp_connector_funcs = {

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-01-09  0:22 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09  0:22 Stephen Rothwell [this message]
2024-01-09  0:22 ` linux-next: manual merge of the drm-intel tree with Linus' tree Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2023-11-22  0:51 Stephen Rothwell
2023-11-22  0:51 ` Stephen Rothwell
2023-11-22  1:10 ` Stephen Rothwell
2023-11-22  1:10   ` Stephen Rothwell
2023-03-06 23:09 Stephen Rothwell
2023-03-06 23:09 ` Stephen Rothwell
2022-11-13 23:23 Stephen Rothwell
2022-11-13 23:23 ` Stephen Rothwell
2022-11-14  8:19 ` Hans de Goede
2022-11-14  8:19   ` Hans de Goede
2022-11-14 10:10   ` Jani Nikula
2022-11-14 10:10     ` Jani Nikula
2022-11-14 10:35     ` Hans de Goede
2022-11-14 10:35       ` Hans de Goede
2022-11-14 11:02       ` Jani Nikula
2022-11-14 11:02         ` Jani Nikula
2022-10-17 22:05 Stephen Rothwell
2022-10-17 22:05 ` Stephen Rothwell
2022-06-07 23:59 Stephen Rothwell
2022-06-07 23:59 ` Stephen Rothwell
2022-06-07 23:53 Stephen Rothwell
2022-06-07 23:53 ` Stephen Rothwell
2022-04-05  1:00 Stephen Rothwell
2022-04-05  1:00 ` Stephen Rothwell
2022-04-05  0:53 Stephen Rothwell
2022-04-05  0:53 ` Stephen Rothwell
2022-01-24 22:39 Stephen Rothwell
2022-01-24 22:39 ` Stephen Rothwell
2022-01-24 22:33 Stephen Rothwell
2022-01-24 22:33 ` Stephen Rothwell
2021-08-02 15:29 Mark Brown
2021-05-20  0:19 Stephen Rothwell
2021-05-20  0:19 ` Stephen Rothwell
2021-05-21  1:45 ` Stephen Rothwell
2021-05-21  1:45   ` Stephen Rothwell
2021-05-12  0:28 Stephen Rothwell
2021-05-12  0:28 ` Stephen Rothwell
2020-09-08  4:00 Stephen Rothwell
2020-09-08  4:00 ` Stephen Rothwell
2020-09-08  8:22 ` Hans de Goede
2020-09-08  8:22   ` Hans de Goede
2020-09-08 11:04   ` Stephen Rothwell
2020-09-08 11:04     ` Stephen Rothwell
2020-09-08 13:20     ` Hans de Goede
2020-09-08 13:20       ` Hans de Goede
2020-06-23  1:35 Stephen Rothwell
2020-06-23  1:35 ` Stephen Rothwell
2018-03-22  2:21 Stephen Rothwell
2018-03-22  2:21 ` Stephen Rothwell
2018-03-23  0:50 ` Stephen Rothwell
2018-03-23  0:50   ` Stephen Rothwell
2017-09-19  1:42 Stephen Rothwell
2016-09-16  0:38 Stephen Rothwell
2016-09-16  0:38 ` Stephen Rothwell
2016-09-08  2:08 Stephen Rothwell
2016-09-08  2:08 ` Stephen Rothwell
2016-05-31  1:06 Stephen Rothwell
2016-05-31  1:06 ` Stephen Rothwell
2016-05-31  1:00 Stephen Rothwell
2016-05-31  1:00 ` Stephen Rothwell
2015-12-22  1:03 Stephen Rothwell
2015-12-22  1:03 ` Stephen Rothwell
2015-11-19  0:23 Stephen Rothwell
2015-11-19  0:23 ` Stephen Rothwell
2015-09-29  1:20 Stephen Rothwell
2015-09-29  1:20 ` Stephen Rothwell
2015-09-29  1:20 Stephen Rothwell
2015-09-29  1:20 ` Stephen Rothwell
2015-09-17  0:13 Stephen Rothwell
2015-09-17  0:13 ` Stephen Rothwell
2015-07-09  1:02 Stephen Rothwell
2015-07-09  1:02 ` Stephen Rothwell
2015-04-29  1:15 Stephen Rothwell
2015-04-29  1:15 ` Stephen Rothwell
2014-09-08  4:32 Stephen Rothwell
2014-09-08  4:32 ` Stephen Rothwell
2013-12-18  2:50 Stephen Rothwell
2013-12-18  2:50 ` Stephen Rothwell
2013-12-13  0:58 Stephen Rothwell
2013-12-13  0:58 ` Stephen Rothwell
2013-09-18  1:25 Stephen Rothwell
2013-09-18  1:25 ` Stephen Rothwell
2013-09-18  1:20 Stephen Rothwell
2013-09-18  1:20 ` Stephen Rothwell
2013-06-26  3:54 Stephen Rothwell
2013-06-26  3:54 ` Stephen Rothwell
2013-06-17  3:32 Stephen Rothwell
2013-06-17  3:32 ` Stephen Rothwell
2013-06-17  3:25 Stephen Rothwell
2013-06-17  3:25 ` Stephen Rothwell
2013-05-21  1:58 Stephen Rothwell
2013-05-21  1:58 ` Stephen Rothwell
2013-05-07  1:27 Stephen Rothwell
2013-05-07  1:27 ` Stephen Rothwell
2013-05-07  8:43 ` Daniel Vetter
2013-05-07  8:43   ` Daniel Vetter
2013-05-08  0:11   ` Stephen Rothwell
2013-05-08  0:11     ` Stephen Rothwell
2013-04-03  2:43 Stephen Rothwell
2013-04-03  2:43 ` Stephen Rothwell
2013-04-03  8:31 ` Daniel Vetter
2013-04-02  2:46 Stephen Rothwell
2013-04-02  2:46 ` Stephen Rothwell
2013-03-04 23:23 Stephen Rothwell
2013-03-04 23:23 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240109112254.405d3a1a@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=andersson@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.