All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
To: "Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konrad.dybcio@linaro.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Johan Hovold" <johan+linaro@kernel.org>,
	"Brian Masney" <bmasney@redhat.com>,
	"Georgi Djakov" <djakov@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <vireshk@kernel.org>,
	<quic_vbadigan@quicinc.com>, <quic_skananth@quicinc.com>,
	<quic_nitegupt@quicinc.com>, <linux-pci@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Krishna chaitanya chundru" <quic_krichai@quicinc.com>
Subject: [PATCH v6 6/6] PCI: qcom: Add OPP support to scale performance state of power domain
Date: Fri, 12 Jan 2024 19:52:05 +0530	[thread overview]
Message-ID: <20240112-opp_support-v6-6-77bbf7d0cc37@quicinc.com> (raw)
In-Reply-To: <20240112-opp_support-v6-0-77bbf7d0cc37@quicinc.com>

QCOM Resource Power Manager-hardened (RPMh) is a hardware block which
maintains hardware state of a regulator by performing max aggregation of
the requests made by all of the processors.

PCIe controller can operate on different RPMh performance state of power
domain based up on the speed of the link. And this performance state varies
from target to target.

It is manadate to scale the performance state based up on the PCIe speed
link operates so that SoC can run under optimum power conditions.

Add Operating Performance Points(OPP) support to vote for RPMh state based
upon GEN speed link is operating.

OPP can handle ICC bw voting also, so move icc bw voting through opp
framework if opp entries are present.

In PCIe certain gen speeds like GEN1x2 & GEN2X1 or GEN3x2 & GEN4x1 use
same icc bw and has frequency, so use frequency based search to reduce
number of entries in the opp table.

Don't initialize icc if opp is supported.

Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
---
 drivers/pci/controller/dwc/pcie-qcom.c | 83 ++++++++++++++++++++++++++++------
 1 file changed, 70 insertions(+), 13 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 035953f0b6d8..31512dc9d6ff 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -22,6 +22,7 @@
 #include <linux/of.h>
 #include <linux/of_gpio.h>
 #include <linux/pci.h>
+#include <linux/pm_opp.h>
 #include <linux/pm_runtime.h>
 #include <linux/platform_device.h>
 #include <linux/phy/pcie.h>
@@ -244,6 +245,7 @@ struct qcom_pcie {
 	const struct qcom_pcie_cfg *cfg;
 	struct dentry *debugfs;
 	bool suspended;
+	bool opp_supported;
 };
 
 #define to_qcom_pcie(x)		dev_get_drvdata((x)->dev)
@@ -1404,16 +1406,14 @@ static int qcom_pcie_icc_init(struct qcom_pcie *pcie)
 	return 0;
 }
 
-static void qcom_pcie_icc_update(struct qcom_pcie *pcie)
+static void qcom_pcie_icc_opp_update(struct qcom_pcie *pcie)
 {
 	struct dw_pcie *pci = pcie->pci;
-	u32 offset, status;
+	u32 offset, status, freq;
+	struct dev_pm_opp *opp;
 	int speed, width;
 	int ret;
 
-	if (!pcie->icc_mem)
-		return;
-
 	offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
 	status = readw(pci->dbi_base + offset + PCI_EXP_LNKSTA);
 
@@ -1424,11 +1424,42 @@ static void qcom_pcie_icc_update(struct qcom_pcie *pcie)
 	speed = FIELD_GET(PCI_EXP_LNKSTA_CLS, status);
 	width = FIELD_GET(PCI_EXP_LNKSTA_NLW, status);
 
-	ret = icc_set_bw(pcie->icc_mem, 0, width * QCOM_PCIE_LINK_SPEED_TO_BW(speed));
-	if (ret) {
-		dev_err(pci->dev, "failed to set interconnect bandwidth: %d\n",
-			ret);
+	if (pcie->opp_supported) {
+		switch (speed) {
+		case 1:
+			freq = 2500000;
+			break;
+		case 2:
+			freq = 5000000;
+			break;
+		case 3:
+			freq = 8000000;
+			break;
+		default:
+			WARN_ON_ONCE(1);
+			fallthrough;
+		case 4:
+			freq = 16000000;
+			break;
+		}
+
+		opp = dev_pm_opp_find_freq_exact(pci->dev, freq * width, true);
+		if (!IS_ERR(opp)) {
+			ret = dev_pm_opp_set_opp(pci->dev, opp);
+			if (ret)
+				dev_err(pci->dev, "Failed to set opp: freq %ld ret %d\n",
+					dev_pm_opp_get_freq(opp), ret);
+			dev_pm_opp_put(opp);
+		}
+	} else {
+		ret = icc_set_bw(pcie->icc_mem, 0, width * QCOM_PCIE_LINK_SPEED_TO_BW(speed));
+		if (ret) {
+			dev_err(pci->dev, "failed to set interconnect bandwidth for pcie-mem: %d\n",
+				ret);
+		}
 	}
+
+	return;
 }
 
 static int qcom_pcie_link_transition_count(struct seq_file *s, void *data)
@@ -1471,8 +1502,10 @@ static void qcom_pcie_init_debugfs(struct qcom_pcie *pcie)
 static int qcom_pcie_probe(struct platform_device *pdev)
 {
 	const struct qcom_pcie_cfg *pcie_cfg;
+	unsigned long max_freq = INT_MAX;
 	struct device *dev = &pdev->dev;
 	struct qcom_pcie *pcie;
+	struct dev_pm_opp *opp;
 	struct dw_pcie_rp *pp;
 	struct resource *res;
 	struct dw_pcie *pci;
@@ -1539,9 +1572,33 @@ static int qcom_pcie_probe(struct platform_device *pdev)
 		goto err_pm_runtime_put;
 	}
 
-	ret = qcom_pcie_icc_init(pcie);
-	if (ret)
+	 /* OPP table is optional */
+	ret = devm_pm_opp_of_add_table(dev);
+	if (ret && ret != -ENODEV) {
+		dev_err_probe(dev, ret, "Failed to add OPP table\n");
 		goto err_pm_runtime_put;
+	}
+
+	/* vote for max freq in the opp table if opp table is present */
+	if (ret != -ENODEV) {
+		opp = dev_pm_opp_find_freq_floor(dev, &max_freq);
+		if (!IS_ERR(opp)) {
+			ret = dev_pm_opp_set_opp(dev, opp);
+			if (ret)
+				dev_err_probe(pci->dev, ret,
+					      "Failed to set opp: freq %ld\n",
+					      dev_pm_opp_get_freq(opp));
+			dev_pm_opp_put(opp);
+		}
+		pcie->opp_supported = true;
+	}
+
+	/* Skip icc init if opp is supported as icc bw vote is handled by opp framework */
+	if (!pcie->opp_supported) {
+		ret = qcom_pcie_icc_init(pcie);
+		if (ret)
+			goto err_pm_runtime_put;
+	}
 
 	ret = pcie->cfg->ops->get_resources(pcie);
 	if (ret)
@@ -1561,7 +1618,7 @@ static int qcom_pcie_probe(struct platform_device *pdev)
 		goto err_phy_exit;
 	}
 
-	qcom_pcie_icc_update(pcie);
+	qcom_pcie_icc_opp_update(pcie);
 
 	if (pcie->mhi)
 		qcom_pcie_init_debugfs(pcie);
@@ -1640,7 +1697,7 @@ static int qcom_pcie_resume_noirq(struct device *dev)
 		pcie->suspended = false;
 	}
 
-	qcom_pcie_icc_update(pcie);
+	qcom_pcie_icc_opp_update(pcie);
 
 	return 0;
 }

-- 
2.42.0


  parent reply	other threads:[~2024-01-12 14:23 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 14:21 [PATCH v6 0/6] PCI: qcom: Add support for OPP Krishna chaitanya chundru
2024-01-12 14:22 ` [PATCH v6 1/6] dt-bindings: PCI: qcom: Add interconnects path as required property Krishna chaitanya chundru
2024-01-12 16:55   ` Conor Dooley
2024-01-12 17:12     ` Dmitry Baryshkov
2024-01-12 17:27       ` Conor Dooley
2024-01-19 22:34   ` Rob Herring
2024-01-29 15:22   ` Manivannan Sadhasivam
2024-01-12 14:22 ` [PATCH v6 2/6] arm64: dts: qcom: sm8450: Add interconnect path to PCIe node Krishna chaitanya chundru
2024-01-29 15:24   ` Manivannan Sadhasivam
2024-01-12 14:22 ` [PATCH v6 3/6] PCI: qcom: Add missing icc bandwidth vote for cpu to PCIe path Krishna chaitanya chundru
2024-01-12 15:17   ` Bryan O'Donoghue
2024-01-12 22:33     ` Konrad Dybcio
2024-01-16 10:52       ` Johan Hovold
2024-01-17  9:13         ` Konrad Dybcio
2024-01-16  4:52     ` Krishna Chaitanya Chundru
2024-01-16 10:06       ` Bryan O'Donoghue
2024-01-12 15:30   ` Dmitry Baryshkov
2024-01-16  4:57     ` Krishna Chaitanya Chundru
2024-01-17  6:39       ` Manivannan Sadhasivam
2024-01-29 14:10         ` Krishna Chaitanya Chundru
2024-01-12 15:59   ` Johan Hovold
2024-01-12 22:37     ` Konrad Dybcio
2024-01-16 10:54       ` Johan Hovold
2024-01-16  5:04     ` Krishna Chaitanya Chundru
2024-01-16 10:46       ` Johan Hovold
2024-01-12 16:47   ` Bjorn Helgaas
2024-01-16  5:06     ` Krishna Chaitanya Chundru
2024-01-12 14:22 ` [PATCH v6 4/6] dt-bindings: pci: qcom: Add opp table Krishna chaitanya chundru
2024-01-12 14:22 ` [PATCH v6 5/6] arm64: dts: qcom: sm8450: Add opp table support to PCIe Krishna chaitanya chundru
2024-01-29 16:04   ` Manivannan Sadhasivam
2024-01-30  6:11     ` Viresh Kumar
2024-01-30  7:14       ` Manivannan Sadhasivam
2024-01-30  8:36         ` Viresh Kumar
2024-01-30  9:48           ` Manivannan Sadhasivam
2024-01-30  9:55             ` Viresh Kumar
2024-01-30 13:16               ` Manivannan Sadhasivam
2024-01-31  5:23                 ` Viresh Kumar
2024-01-31  8:46                   ` Manivannan Sadhasivam
2024-01-31 10:00                     ` Viresh Kumar
2024-02-01 14:45                   ` Konrad Dybcio
2024-02-02  7:33                     ` Viresh Kumar
2024-02-09 21:14                       ` Konrad Dybcio
2024-02-19  7:02                         ` Krishna Chaitanya Chundru
2024-02-19 10:28                         ` Viresh Kumar
2024-02-19 12:38                           ` Manivannan Sadhasivam
2024-01-12 14:22 ` Krishna chaitanya chundru [this message]
2024-01-12 15:33   ` [PATCH v6 6/6] PCI: qcom: Add OPP support to scale performance state of power domain Dmitry Baryshkov
2024-01-16  5:17     ` Krishna Chaitanya Chundru
2024-01-16  9:55       ` Dmitry Baryshkov
2024-01-16 11:00         ` Johan Hovold
2024-02-01 11:54         ` Manivannan Sadhasivam
2024-02-01 11:58           ` Dmitry Baryshkov
2024-02-01 12:07             ` Manivannan Sadhasivam
2024-01-12 16:50   ` Bjorn Helgaas
2024-01-16  5:07     ` Krishna Chaitanya Chundru
2024-01-12 22:44   ` Konrad Dybcio
2024-01-16  5:18     ` Krishna Chaitanya Chundru
2024-01-29 16:00   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112-opp_support-v6-6-77bbf7d0cc37@quicinc.com \
    --to=quic_krichai@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=quic_nitegupt@quicinc.com \
    --cc=quic_skananth@quicinc.com \
    --cc=quic_vbadigan@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.