From: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Brian Masney" <bmasney@redhat.com>,
"Georgi Djakov" <djakov@kernel.org>,
linux-arm-msm@vger.kernel.org, vireshk@kernel.org,
quic_vbadigan@quicinc.com, quic_skananth@quicinc.com,
quic_nitegupt@quicinc.com, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/6] arm64: dts: qcom: sm8450: Add opp table support to PCIe
Date: Mon, 19 Feb 2024 12:32:52 +0530 [thread overview]
Message-ID: <f3f3329b-0dc9-4652-9f23-d55852f046d8@quicinc.com> (raw)
In-Reply-To: <8a7b63a8-0583-43cf-9876-8a964c8b77ee@linaro.org>
On 2/10/2024 2:44 AM, Konrad Dybcio wrote:
> On 2.02.2024 08:33, Viresh Kumar wrote:
>> On 01-02-24, 15:45, Konrad Dybcio wrote:
>>> I'm lukewarm on this.
>>>
>>> A *lot* of hardware has more complex requirements than "x MBps at y MHz",
>>> especially when performance counters come into the picture for dynamic
>>> bw management.
>>>
>>> OPP tables can't really handle this properly.
>>
>> There was a similar concern for voltages earlier on and we added the capability
>> of adjusting the voltage for OPPs in the OPP core. Maybe something similar can
>> be done here ?
>>
> I really don't think it's fitting.. At any moment the device may require any
> bandwidth value between 0 and MAX_BW_PER_LINK_GEN * LINK_WIDTH..
>
> Konrad
Viresh & konrad can you both come to conclusion on this.
- Krishna Chaitanya.
next prev parent reply other threads:[~2024-02-19 7:03 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 14:21 [PATCH v6 0/6] PCI: qcom: Add support for OPP Krishna chaitanya chundru
2024-01-12 14:22 ` [PATCH v6 1/6] dt-bindings: PCI: qcom: Add interconnects path as required property Krishna chaitanya chundru
2024-01-12 16:55 ` Conor Dooley
2024-01-12 17:12 ` Dmitry Baryshkov
2024-01-12 17:27 ` Conor Dooley
2024-01-19 22:34 ` Rob Herring
2024-01-29 15:22 ` Manivannan Sadhasivam
2024-01-12 14:22 ` [PATCH v6 2/6] arm64: dts: qcom: sm8450: Add interconnect path to PCIe node Krishna chaitanya chundru
2024-01-29 15:24 ` Manivannan Sadhasivam
2024-01-12 14:22 ` [PATCH v6 3/6] PCI: qcom: Add missing icc bandwidth vote for cpu to PCIe path Krishna chaitanya chundru
2024-01-12 15:17 ` Bryan O'Donoghue
2024-01-12 22:33 ` Konrad Dybcio
2024-01-16 10:52 ` Johan Hovold
2024-01-17 9:13 ` Konrad Dybcio
2024-01-16 4:52 ` Krishna Chaitanya Chundru
2024-01-16 10:06 ` Bryan O'Donoghue
2024-01-12 15:30 ` Dmitry Baryshkov
2024-01-16 4:57 ` Krishna Chaitanya Chundru
2024-01-17 6:39 ` Manivannan Sadhasivam
2024-01-29 14:10 ` Krishna Chaitanya Chundru
2024-01-12 15:59 ` Johan Hovold
2024-01-12 22:37 ` Konrad Dybcio
2024-01-16 10:54 ` Johan Hovold
2024-01-16 5:04 ` Krishna Chaitanya Chundru
2024-01-16 10:46 ` Johan Hovold
2024-01-12 16:47 ` Bjorn Helgaas
2024-01-16 5:06 ` Krishna Chaitanya Chundru
2024-01-12 14:22 ` [PATCH v6 4/6] dt-bindings: pci: qcom: Add opp table Krishna chaitanya chundru
2024-01-12 14:22 ` [PATCH v6 5/6] arm64: dts: qcom: sm8450: Add opp table support to PCIe Krishna chaitanya chundru
2024-01-29 16:04 ` Manivannan Sadhasivam
2024-01-30 6:11 ` Viresh Kumar
2024-01-30 7:14 ` Manivannan Sadhasivam
2024-01-30 8:36 ` Viresh Kumar
2024-01-30 9:48 ` Manivannan Sadhasivam
2024-01-30 9:55 ` Viresh Kumar
2024-01-30 13:16 ` Manivannan Sadhasivam
2024-01-31 5:23 ` Viresh Kumar
2024-01-31 8:46 ` Manivannan Sadhasivam
2024-01-31 10:00 ` Viresh Kumar
2024-02-01 14:45 ` Konrad Dybcio
2024-02-02 7:33 ` Viresh Kumar
2024-02-09 21:14 ` Konrad Dybcio
2024-02-19 7:02 ` Krishna Chaitanya Chundru [this message]
2024-02-19 10:28 ` Viresh Kumar
2024-02-19 12:38 ` Manivannan Sadhasivam
2024-01-12 14:22 ` [PATCH v6 6/6] PCI: qcom: Add OPP support to scale performance state of power domain Krishna chaitanya chundru
2024-01-12 15:33 ` Dmitry Baryshkov
2024-01-16 5:17 ` Krishna Chaitanya Chundru
2024-01-16 9:55 ` Dmitry Baryshkov
2024-01-16 11:00 ` Johan Hovold
2024-02-01 11:54 ` Manivannan Sadhasivam
2024-02-01 11:58 ` Dmitry Baryshkov
2024-02-01 12:07 ` Manivannan Sadhasivam
2024-01-12 16:50 ` Bjorn Helgaas
2024-01-16 5:07 ` Krishna Chaitanya Chundru
2024-01-12 22:44 ` Konrad Dybcio
2024-01-16 5:18 ` Krishna Chaitanya Chundru
2024-01-29 16:00 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f3329b-0dc9-4652-9f23-d55852f046d8@quicinc.com \
--to=quic_krichai@quicinc.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.