All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
@ 2024-02-26 13:08 ` Peng Fan (OSS)
  0 siblings, 0 replies; 16+ messages in thread
From: Peng Fan (OSS) @ 2024-02-26 13:08 UTC (permalink / raw)
  To: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel
  Cc: festevam, linux-imx, linux-iio, devicetree, linux-arm-kernel,
	linux-kernel, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
so drop it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
index dacc526dc695..dfc3f512918f 100644
--- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
@@ -31,7 +31,6 @@ properties:
       - description: normal conversion, include EOC (End of Conversion),
           ECH (End of Chain), JEOC (End of Injected Conversion) and
           JECH (End of injected Chain).
-      - description: Self-testing Interrupts.
 
   clocks:
     maxItems: 1
@@ -70,8 +69,7 @@ examples:
             reg = <0x44530000 0x10000>;
             interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
             clocks = <&clk IMX93_CLK_ADC1_GATE>;
             clock-names = "ipg";
             vref-supply = <&reg_vref_1v8>;
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
@ 2024-02-26 13:08 ` Peng Fan (OSS)
  0 siblings, 0 replies; 16+ messages in thread
From: Peng Fan (OSS) @ 2024-02-26 13:08 UTC (permalink / raw)
  To: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel
  Cc: festevam, linux-imx, linux-iio, devicetree, linux-arm-kernel,
	linux-kernel, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
so drop it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
index dacc526dc695..dfc3f512918f 100644
--- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
@@ -31,7 +31,6 @@ properties:
       - description: normal conversion, include EOC (End of Conversion),
           ECH (End of Chain), JEOC (End of Injected Conversion) and
           JECH (End of injected Chain).
-      - description: Self-testing Interrupts.
 
   clocks:
     maxItems: 1
@@ -70,8 +69,7 @@ examples:
             reg = <0x44530000 0x10000>;
             interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
-                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
             clocks = <&clk IMX93_CLK_ADC1_GATE>;
             clock-names = "ipg";
             vref-supply = <&reg_vref_1v8>;
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC
  2024-02-26 13:08 ` Peng Fan (OSS)
@ 2024-02-26 13:08   ` Peng Fan (OSS)
  -1 siblings, 0 replies; 16+ messages in thread
From: Peng Fan (OSS) @ 2024-02-26 13:08 UTC (permalink / raw)
  To: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel
  Cc: festevam, linux-imx, linux-iio, devicetree, linux-arm-kernel,
	linux-kernel, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
drop it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx93.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 601c94e1fac8..b8ef9b938856 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -509,8 +509,7 @@ adc1: adc@44530000 {
 				reg = <0x44530000 0x10000>;
 				interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
 					     <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
-					     <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
-					     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+					     <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_ADC1_GATE>;
 				clock-names = "ipg";
 				#io-channel-cells = <1>;
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC
@ 2024-02-26 13:08   ` Peng Fan (OSS)
  0 siblings, 0 replies; 16+ messages in thread
From: Peng Fan (OSS) @ 2024-02-26 13:08 UTC (permalink / raw)
  To: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel
  Cc: festevam, linux-imx, linux-iio, devicetree, linux-arm-kernel,
	linux-kernel, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
drop it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx93.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 601c94e1fac8..b8ef9b938856 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -509,8 +509,7 @@ adc1: adc@44530000 {
 				reg = <0x44530000 0x10000>;
 				interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
 					     <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
-					     <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
-					     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+					     <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clk IMX93_CLK_ADC1_GATE>;
 				clock-names = "ipg";
 				#io-channel-cells = <1>;
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
  2024-02-26 13:08 ` Peng Fan (OSS)
@ 2024-02-26 16:24   ` Conor Dooley
  -1 siblings, 0 replies; 16+ messages in thread
From: Conor Dooley @ 2024-02-26 16:24 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> so drop it.

Don't just remove it from the example, drop it from the binding too?
It does permit a 4th "self testing" interrupt.

Thanks,
Conor.

> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..dfc3f512918f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -31,7 +31,6 @@ properties:
>        - description: normal conversion, include EOC (End of Conversion),
>            ECH (End of Chain), JEOC (End of Injected Conversion) and
>            JECH (End of injected Chain).
> -      - description: Self-testing Interrupts.
>  
>    clocks:
>      maxItems: 1
> @@ -70,8 +69,7 @@ examples:
>              reg = <0x44530000 0x10000>;
>              interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>                           <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
>              clocks = <&clk IMX93_CLK_ADC1_GATE>;
>              clock-names = "ipg";
>              vref-supply = <&reg_vref_1v8>;
> -- 
> 2.37.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
@ 2024-02-26 16:24   ` Conor Dooley
  0 siblings, 0 replies; 16+ messages in thread
From: Conor Dooley @ 2024-02-26 16:24 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan


[-- Attachment #1.1: Type: text/plain, Size: 1714 bytes --]

On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> so drop it.

Don't just remove it from the example, drop it from the binding too?
It does permit a 4th "self testing" interrupt.

Thanks,
Conor.

> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..dfc3f512918f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -31,7 +31,6 @@ properties:
>        - description: normal conversion, include EOC (End of Conversion),
>            ECH (End of Chain), JEOC (End of Injected Conversion) and
>            JECH (End of injected Chain).
> -      - description: Self-testing Interrupts.
>  
>    clocks:
>      maxItems: 1
> @@ -70,8 +69,7 @@ examples:
>              reg = <0x44530000 0x10000>;
>              interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>                           <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
>              clocks = <&clk IMX93_CLK_ADC1_GATE>;
>              clock-names = "ipg";
>              vref-supply = <&reg_vref_1v8>;
> -- 
> 2.37.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
  2024-02-26 16:24   ` Conor Dooley
@ 2024-02-26 19:20     ` Jonathan Cameron
  -1 siblings, 0 replies; 16+ messages in thread
From: Jonathan Cameron @ 2024-02-26 19:20 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Peng Fan (OSS),
	haibo.chen, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

On Mon, 26 Feb 2024 16:24:47 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> > 
> > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > so drop it.  
> 
> Don't just remove it from the example, drop it from the binding too?
> It does permit a 4th "self testing" interrupt.

I'm missing something. See below...
> 
> Thanks,
> Conor.
> 
> > 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > index dacc526dc695..dfc3f512918f 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > @@ -31,7 +31,6 @@ properties:
> >        - description: normal conversion, include EOC (End of Conversion),
> >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> >            JECH (End of injected Chain).
> > -      - description: Self-testing Interrupts.

Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...

> >  
> >    clocks:
> >      maxItems: 1
> > @@ -70,8 +69,7 @@ examples:
> >              reg = <0x44530000 0x10000>;
> >              interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> >                           <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> > +                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
> >              clocks = <&clk IMX93_CLK_ADC1_GATE>;
> >              clock-names = "ipg";
> >              vref-supply = <&reg_vref_1v8>;
> > -- 
> > 2.37.1
> >   


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
@ 2024-02-26 19:20     ` Jonathan Cameron
  0 siblings, 0 replies; 16+ messages in thread
From: Jonathan Cameron @ 2024-02-26 19:20 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Peng Fan (OSS),
	haibo.chen, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

On Mon, 26 Feb 2024 16:24:47 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> > 
> > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > so drop it.  
> 
> Don't just remove it from the example, drop it from the binding too?
> It does permit a 4th "self testing" interrupt.

I'm missing something. See below...
> 
> Thanks,
> Conor.
> 
> > 
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > index dacc526dc695..dfc3f512918f 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > @@ -31,7 +31,6 @@ properties:
> >        - description: normal conversion, include EOC (End of Conversion),
> >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> >            JECH (End of injected Chain).
> > -      - description: Self-testing Interrupts.

Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...

> >  
> >    clocks:
> >      maxItems: 1
> > @@ -70,8 +69,7 @@ examples:
> >              reg = <0x44530000 0x10000>;
> >              interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
> >                           <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> > +                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
> >              clocks = <&clk IMX93_CLK_ADC1_GATE>;
> >              clock-names = "ipg";
> >              vref-supply = <&reg_vref_1v8>;
> > -- 
> > 2.37.1
> >   


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
  2024-02-26 19:20     ` Jonathan Cameron
@ 2024-02-26 21:17       ` Conor Dooley
  -1 siblings, 0 replies; 16+ messages in thread
From: Conor Dooley @ 2024-02-26 21:17 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Peng Fan (OSS),
	haibo.chen, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]

On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 16:24:47 +0000
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > > 
> > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > so drop it.  
> > 
> > Don't just remove it from the example, drop it from the binding too?
> > It does permit a 4th "self testing" interrupt.
> 
> I'm missing something. See below...
> > 
> > Thanks,
> > Conor.
> > 
> > > 
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > index dacc526dc695..dfc3f512918f 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > @@ -31,7 +31,6 @@ properties:
> > >        - description: normal conversion, include EOC (End of Conversion),
> > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > >            JECH (End of injected Chain).
> > > -      - description: Self-testing Interrupts.
> 
> Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...

Huh, wonder how I missed that. I thought I double checked...
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
@ 2024-02-26 21:17       ` Conor Dooley
  0 siblings, 0 replies; 16+ messages in thread
From: Conor Dooley @ 2024-02-26 21:17 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Peng Fan (OSS),
	haibo.chen, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan


[-- Attachment #1.1: Type: text/plain, Size: 1650 bytes --]

On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 16:24:47 +0000
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > > 
> > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > so drop it.  
> > 
> > Don't just remove it from the example, drop it from the binding too?
> > It does permit a 4th "self testing" interrupt.
> 
> I'm missing something. See below...
> > 
> > Thanks,
> > Conor.
> > 
> > > 
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > index dacc526dc695..dfc3f512918f 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > @@ -31,7 +31,6 @@ properties:
> > >        - description: normal conversion, include EOC (End of Conversion),
> > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > >            JECH (End of injected Chain).
> > > -      - description: Self-testing Interrupts.
> 
> Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...

Huh, wonder how I missed that. I thought I double checked...
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
  2024-02-26 21:17       ` Conor Dooley
@ 2024-02-26 22:06         ` Jonathan Cameron
  -1 siblings, 0 replies; 16+ messages in thread
From: Jonathan Cameron @ 2024-02-26 22:06 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Peng Fan (OSS),
	haibo.chen, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

On Mon, 26 Feb 2024 21:17:06 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> > On Mon, 26 Feb 2024 16:24:47 +0000
> > Conor Dooley <conor@kernel.org> wrote:
> >   
> > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:  
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > > 
> > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > > so drop it.    
> > > 
> > > Don't just remove it from the example, drop it from the binding too?
> > > It does permit a 4th "self testing" interrupt.  
> > 
> > I'm missing something. See below...  
> > > 
> > > Thanks,
> > > Conor.
> > >   
> > > > 
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > index dacc526dc695..dfc3f512918f 100644
> > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > @@ -31,7 +31,6 @@ properties:
> > > >        - description: normal conversion, include EOC (End of Conversion),
> > > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > > >            JECH (End of injected Chain).
> > > > -      - description: Self-testing Interrupts.  
> > 
> > Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...  
> 
> Huh, wonder how I missed that. I thought I double checked...
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Cheers,
> Conor.

Happens to us all!  Applied patch 1 to the togreg branch of iio.git and pushed
it out as testing so 0-day can poke at it.
Thanks,

Jonathan

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
@ 2024-02-26 22:06         ` Jonathan Cameron
  0 siblings, 0 replies; 16+ messages in thread
From: Jonathan Cameron @ 2024-02-26 22:06 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Peng Fan (OSS),
	haibo.chen, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

On Mon, 26 Feb 2024 21:17:06 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote:
> > On Mon, 26 Feb 2024 16:24:47 +0000
> > Conor Dooley <conor@kernel.org> wrote:
> >   
> > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:  
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > > 
> > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> > > > so drop it.    
> > > 
> > > Don't just remove it from the example, drop it from the binding too?
> > > It does permit a 4th "self testing" interrupt.  
> > 
> > I'm missing something. See below...  
> > > 
> > > Thanks,
> > > Conor.
> > >   
> > > > 
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
> > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > index dacc526dc695..dfc3f512918f 100644
> > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > > > @@ -31,7 +31,6 @@ properties:
> > > >        - description: normal conversion, include EOC (End of Conversion),
> > > >            ECH (End of Chain), JEOC (End of Injected Conversion) and
> > > >            JECH (End of injected Chain).
> > > > -      - description: Self-testing Interrupts.  
> > 
> > Eyes skipped over this maybe?  The 4th interrupt is removed from binding here...  
> 
> Huh, wonder how I missed that. I thought I double checked...
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Cheers,
> Conor.

Happens to us all!  Applied patch 1 to the togreg branch of iio.git and pushed
it out as testing so 0-day can poke at it.
Thanks,

Jonathan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* RE: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC
  2024-02-26 13:08   ` Peng Fan (OSS)
@ 2024-03-15  1:01     ` Peng Fan
  -1 siblings, 0 replies; 16+ messages in thread
From: Peng Fan @ 2024-03-15  1:01 UTC (permalink / raw)
  To: Peng Fan (OSS),
	Bough Chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel
  Cc: festevam, dl-linux-imx, linux-iio, devicetree, linux-arm-kernel,
	linux-kernel

Hi Shawn,

> Subject: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC

The Patch 1/2 has been accepted. Would you please check this dts part?

Thanks,
Peng.

> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
> drop it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 601c94e1fac8..b8ef9b938856 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -509,8 +509,7 @@ adc1: adc@44530000 {
>  				reg = <0x44530000 0x10000>;
>  				interrupts = <GIC_SPI 217
> IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 218
> IRQ_TYPE_LEVEL_HIGH>,
> -					     <GIC_SPI 219
> IRQ_TYPE_LEVEL_HIGH>,
> -					     <GIC_SPI 268
> IRQ_TYPE_LEVEL_HIGH>;
> +					     <GIC_SPI 219
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_ADC1_GATE>;
>  				clock-names = "ipg";
>  				#io-channel-cells = <1>;
> --
> 2.37.1


^ permalink raw reply	[flat|nested] 16+ messages in thread
* RE: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC
@ 2024-03-15  1:01     ` Peng Fan
  0 siblings, 0 replies; 16+ messages in thread
From: Peng Fan @ 2024-03-15  1:01 UTC (permalink / raw)
  To: Peng Fan (OSS),
	Bough Chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel
  Cc: festevam, dl-linux-imx, linux-iio, devicetree, linux-arm-kernel,
	linux-kernel

Hi Shawn,

> Subject: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC

The Patch 1/2 has been accepted. Would you please check this dts part?

Thanks,
Peng.

> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
> drop it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 601c94e1fac8..b8ef9b938856 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -509,8 +509,7 @@ adc1: adc@44530000 {
>  				reg = <0x44530000 0x10000>;
>  				interrupts = <GIC_SPI 217
> IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 218
> IRQ_TYPE_LEVEL_HIGH>,
> -					     <GIC_SPI 219
> IRQ_TYPE_LEVEL_HIGH>,
> -					     <GIC_SPI 268
> IRQ_TYPE_LEVEL_HIGH>;
> +					     <GIC_SPI 219
> IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX93_CLK_ADC1_GATE>;
>  				clock-names = "ipg";
>  				#io-channel-cells = <1>;
> --
> 2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC
  2024-02-26 13:08   ` Peng Fan (OSS)
@ 2024-03-28 12:47     ` Shawn Guo
  -1 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2024-03-28 12:47 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

On Mon, Feb 26, 2024 at 09:08:26PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
> drop it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks!


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC
@ 2024-03-28 12:47     ` Shawn Guo
  0 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2024-03-28 12:47 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: haibo.chen, jic23, lars, robh, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, linux-imx, linux-iio,
	devicetree, linux-arm-kernel, linux-kernel, Peng Fan

On Mon, Feb 26, 2024 at 09:08:26PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX93 Reference Mannual Rev.4, 12/2023, there is no interrupt 268,
> drop it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks!


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2024-03-28 14:03 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 13:08 [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt Peng Fan (OSS)
2024-02-26 13:08 ` Peng Fan (OSS)
2024-02-26 13:08 ` [PATCH 2/2] arm64: dts: imx93: drop the 4th interrupt for ADC Peng Fan (OSS)
2024-02-26 13:08   ` Peng Fan (OSS)
2024-03-15  1:01   ` Peng Fan
2024-03-15  1:01     ` Peng Fan
2024-03-28 12:47   ` Shawn Guo
2024-03-28 12:47     ` Shawn Guo
2024-02-26 16:24 ` [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt Conor Dooley
2024-02-26 16:24   ` Conor Dooley
2024-02-26 19:20   ` Jonathan Cameron
2024-02-26 19:20     ` Jonathan Cameron
2024-02-26 21:17     ` Conor Dooley
2024-02-26 21:17       ` Conor Dooley
2024-02-26 22:06       ` Jonathan Cameron
2024-02-26 22:06         ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.