From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Murali Nalajal <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Philip Derrin <quic_pderrin@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, "Fuad Tabba" <tabba@google.com>, Sean Christopherson <seanjc@google.com>, "Andrew Morton" <akpm@linux-foundation.org>, <linux-arm-msm@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mm@kvack.org> Subject: Re: [PATCH v17 11/35] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Date: Mon, 11 Mar 2024 11:09:05 +0530 [thread overview] Message-ID: <20240311053905.GN440762@quicinc.com> (raw) In-Reply-To: <20240222-gunyah-v17-11-1e9da6763d38@quicinc.com> * Elliot Berman <quic_eberman@quicinc.com> [2024-02-22 15:16:34]: > When booting a Gunyah virtual machine, the host VM may gain capabilities > to interact with resources for the guest virtual machine. Examples of > such resources are vCPUs or message queues. To use those resources, we > need to translate the RM response into a gunyah_resource structure which > are useful to Linux drivers. Presently, Linux drivers need only to know > the type of resource, the capability ID, and an interrupt. > > On ARM64 systems, the interrupt reported by Gunyah is the GIC interrupt > ID number and always a SPI or extended SPI. > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> Minor nit below. LGTM otherwise Reviewed-by: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> > +struct gunyah_resource * > +gunyah_rm_alloc_resource(struct gunyah_rm *rm, > + struct gunyah_rm_hyp_resource *hyp_resource) > +{ > + struct gunyah_resource *ghrsc; > + int ret; > + > + ghrsc = kzalloc(sizeof(*ghrsc), GFP_KERNEL); > + if (!ghrsc) > + return NULL; > + > + ghrsc->type = hyp_resource->type; > + ghrsc->capid = le64_to_cpu(hyp_resource->cap_id); > + ghrsc->irq = IRQ_NOTCONNECTED; > + ghrsc->rm_label = le32_to_cpu(hyp_resource->resource_label); > + if (hyp_resource->virq) { > + struct irq_fwspec fwspec; > + > + > + fwspec.fwnode = rm->parent_fwnode; > + ret = arch_gunyah_fill_irq_fwspec_params(le32_to_cpu(hyp_resource->virq), &fwspec); > + if (ret) { > + dev_err(rm->dev, > + "Failed to translate interrupt for resource %d label: %d: %d\n", > + ghrsc->type, ghrsc->rm_label, ret); Not bailing on error here appears wrong. Can you check? > + } > + > + ret = irq_create_fwspec_mapping(&fwspec); > + if (ret < 0) { > + dev_err(rm->dev, > + "Failed to allocate interrupt for resource %d label: %d: %d\n", > + ghrsc->type, ghrsc->rm_label, ret); > + kfree(ghrsc); > + return NULL; > + } > + ghrsc->irq = ret; > + } > + > + return ghrsc; > +}
WARNING: multiple messages have this Message-ID (diff)
From: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Murali Nalajal <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Philip Derrin <quic_pderrin@quicinc.com>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Jonathan Corbet <corbet@lwn.net>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, "Fuad Tabba" <tabba@google.com>, Sean Christopherson <seanjc@google.com>, "Andrew Morton" <akpm@linux-foundation.org>, <linux-arm-msm@vger.kernel.org>, <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mm@kvack.org> Subject: Re: [PATCH v17 11/35] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Date: Mon, 11 Mar 2024 11:09:05 +0530 [thread overview] Message-ID: <20240311053905.GN440762@quicinc.com> (raw) In-Reply-To: <20240222-gunyah-v17-11-1e9da6763d38@quicinc.com> * Elliot Berman <quic_eberman@quicinc.com> [2024-02-22 15:16:34]: > When booting a Gunyah virtual machine, the host VM may gain capabilities > to interact with resources for the guest virtual machine. Examples of > such resources are vCPUs or message queues. To use those resources, we > need to translate the RM response into a gunyah_resource structure which > are useful to Linux drivers. Presently, Linux drivers need only to know > the type of resource, the capability ID, and an interrupt. > > On ARM64 systems, the interrupt reported by Gunyah is the GIC interrupt > ID number and always a SPI or extended SPI. > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> Minor nit below. LGTM otherwise Reviewed-by: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com> > +struct gunyah_resource * > +gunyah_rm_alloc_resource(struct gunyah_rm *rm, > + struct gunyah_rm_hyp_resource *hyp_resource) > +{ > + struct gunyah_resource *ghrsc; > + int ret; > + > + ghrsc = kzalloc(sizeof(*ghrsc), GFP_KERNEL); > + if (!ghrsc) > + return NULL; > + > + ghrsc->type = hyp_resource->type; > + ghrsc->capid = le64_to_cpu(hyp_resource->cap_id); > + ghrsc->irq = IRQ_NOTCONNECTED; > + ghrsc->rm_label = le32_to_cpu(hyp_resource->resource_label); > + if (hyp_resource->virq) { > + struct irq_fwspec fwspec; > + > + > + fwspec.fwnode = rm->parent_fwnode; > + ret = arch_gunyah_fill_irq_fwspec_params(le32_to_cpu(hyp_resource->virq), &fwspec); > + if (ret) { > + dev_err(rm->dev, > + "Failed to translate interrupt for resource %d label: %d: %d\n", > + ghrsc->type, ghrsc->rm_label, ret); Not bailing on error here appears wrong. Can you check? > + } > + > + ret = irq_create_fwspec_mapping(&fwspec); > + if (ret < 0) { > + dev_err(rm->dev, > + "Failed to allocate interrupt for resource %d label: %d: %d\n", > + ghrsc->type, ghrsc->rm_label, ret); > + kfree(ghrsc); > + return NULL; > + } > + ghrsc->irq = ret; > + } > + > + return ghrsc; > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-11 5:39 UTC|newest] Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-22 23:16 [PATCH v17 00/35] Drivers for Gunyah hypervisor Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 01/35] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-05 10:53 ` Pavan Kondeti 2024-03-05 10:53 ` Pavan Kondeti 2024-03-07 15:37 ` Srivatsa Vaddagiri 2024-03-07 15:37 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 02/35] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 03/35] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 04/35] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 05/35] virt: gunyah: Add hypervisor driver Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-23 21:10 ` Konrad Dybcio 2024-02-23 21:10 ` Konrad Dybcio 2024-02-23 22:58 ` Elliot Berman 2024-02-23 22:58 ` Elliot Berman 2024-02-23 23:46 ` Konrad Dybcio 2024-02-23 23:46 ` Konrad Dybcio 2024-03-07 15:38 ` Srivatsa Vaddagiri 2024-03-07 15:38 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 06/35] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 07/35] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-07 15:38 ` Srivatsa Vaddagiri 2024-03-07 15:38 ` Srivatsa Vaddagiri 2024-03-07 16:41 ` Elliot Berman 2024-03-07 16:41 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 08/35] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-07 15:39 ` Srivatsa Vaddagiri 2024-03-07 15:39 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 09/35] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-07 15:39 ` Srivatsa Vaddagiri 2024-03-07 15:39 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 10/35] gunyah: vm_mgr: Add VM start/stop Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-11 5:38 ` Srivatsa Vaddagiri 2024-03-11 5:38 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 11/35] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-11 5:39 ` Srivatsa Vaddagiri [this message] 2024-03-11 5:39 ` Srivatsa Vaddagiri 2024-03-11 17:19 ` Elliot Berman 2024-03-11 17:19 ` Elliot Berman 2024-04-05 3:10 ` Pavan Kondeti 2024-04-05 3:10 ` Pavan Kondeti 2024-04-05 15:18 ` Elliot Berman 2024-04-05 15:18 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 12/35] virt: gunyah: Add resource tickets Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-11 5:38 ` Srivatsa Vaddagiri 2024-03-11 5:38 ` Srivatsa Vaddagiri 2024-03-11 17:13 ` Elliot Berman 2024-03-11 17:13 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 13/35] gunyah: vm_mgr: Add framework for VM Functions Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-13 9:20 ` Srivatsa Vaddagiri 2024-03-13 9:20 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 14/35] virt: gunyah: Add hypercalls for running a vCPU Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-13 9:21 ` Srivatsa Vaddagiri 2024-03-13 9:21 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 15/35] virt: gunyah: Add proxy-scheduled vCPUs Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-13 9:21 ` Srivatsa Vaddagiri 2024-03-13 9:21 ` Srivatsa Vaddagiri 2024-04-24 9:39 ` Srivatsa Vaddagiri 2024-04-24 9:39 ` Srivatsa Vaddagiri 2024-04-24 17:01 ` Elliot Berman 2024-04-24 17:01 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 16/35] gunyah: Add hypercalls for demand paging Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-13 15:35 ` Srivatsa Vaddagiri 2024-03-13 15:35 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 17/35] gunyah: rsc_mgr: Add memory parcel RPC Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-14 14:02 ` Srivatsa Vaddagiri 2024-03-14 14:02 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 18/35] mm/interval_tree: Export iter_first/iter_next Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 19/35] arch/mm: Export direct {un,}map functions Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-23 7:09 ` Christoph Hellwig 2024-02-23 7:09 ` Christoph Hellwig 2024-02-24 0:37 ` Elliot Berman 2024-02-24 0:37 ` Elliot Berman 2024-02-26 11:06 ` Christoph Hellwig 2024-02-26 11:06 ` Christoph Hellwig 2024-02-26 11:53 ` David Hildenbrand 2024-02-26 11:53 ` David Hildenbrand 2024-02-26 17:27 ` Elliot Berman 2024-02-26 17:27 ` Elliot Berman 2024-02-27 9:49 ` David Hildenbrand 2024-02-27 9:49 ` David Hildenbrand 2024-03-01 1:35 ` Elliot Berman 2024-03-01 1:35 ` Elliot Berman 2024-03-04 13:10 ` Quentin Perret 2024-03-04 13:10 ` Quentin Perret 2024-03-04 23:37 ` Elliot Berman 2024-03-04 23:37 ` Elliot Berman 2024-03-05 15:30 ` Quentin Perret 2024-03-05 15:30 ` Quentin Perret 2024-03-05 20:26 ` Elliot Berman 2024-03-05 20:26 ` Elliot Berman 2024-03-06 12:05 ` Quentin Perret 2024-03-06 12:05 ` Quentin Perret 2024-03-08 19:55 ` Elliot Berman 2024-03-08 19:55 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 20/35] virt: gunyah: Add interfaces to map memory into guest address space Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 21/35] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 22/35] virt: gunyah: Add Qualcomm Gunyah platform ops Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 23/35] virt: gunyah: Implement guestmemfd Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 24/35] virt: gunyah: Add ioctl to bind guestmem to VMs Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 25/35] virt: gunyah: guestmem: Initialize RM mem parcels from guestmem Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 26/35] virt: gunyah: Share guest VM dtb configuration to Gunyah Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 27/35] gunyah: rsc_mgr: Add RPC to enable demand paging Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 28/35] virt: gunyah: Enable " Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 29/35] gunyah: rsc_mgr: Add RPC to set VM boot context Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-14 14:02 ` Srivatsa Vaddagiri 2024-03-14 14:02 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 30/35] virt: gunyah: Allow userspace to initialize context of primary vCPU Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-03-14 14:03 ` Srivatsa Vaddagiri 2024-03-14 14:03 ` Srivatsa Vaddagiri 2024-02-22 23:16 ` [PATCH v17 31/35] virt: gunyah: Add hypercalls for sending doorbell Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 32/35] virt: gunyah: Add irqfd interface Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 33/35] virt: gunyah: Add IO handlers Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 34/35] virt: gunyah: Add ioeventfd Elliot Berman 2024-02-22 23:16 ` Elliot Berman 2024-02-22 23:16 ` [PATCH v17 35/35] MAINTAINERS: Add Gunyah hypervisor drivers section Elliot Berman 2024-02-22 23:16 ` Elliot Berman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240311053905.GN440762@quicinc.com \ --to=quic_svaddagi@quicinc.com \ --cc=akpm@linux-foundation.org \ --cc=andersson@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=elder@linaro.org \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_eberman@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pderrin@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=seanjc@google.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tabba@google.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.