From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: David Woodhouse <dwmw2@infradead.org> Cc: Peter Hilber <peter.hilber@opensynergy.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, virtio-dev@lists.oasis-open.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, "virtio-comment@lists.oasis-open.org" <virtio-comment@lists.oasis-open.org>, "Christopher S. Hall" <christopher.s.hall@intel.com>, Jason Wang <jasowang@redhat.com>, John Stultz <jstultz@google.com>, "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org, Richard Cochran <richardcochran@gmail.com>, Stephen Boyd <sboyd@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Xuan Zhuo <xuanzhuo@linux.alibaba.com>, Marc Zyngier <maz@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, "Ridoux, Julien" <ridouxj@amazon.com> Subject: Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes Date: Wed, 13 Mar 2024 15:50:54 +0100 [thread overview] Message-ID: <202403131450547f373268@mail.local> (raw) In-Reply-To: <96be7312f7bddaf06c690e082a8028fa8b511deb.camel@infradead.org> On 13/03/2024 14:06:42+0000, David Woodhouse wrote: > If you're asking why patch 7/7 in Peter's series exists to expose the > virtio clock through RTC, and you're not particularly interested in the > first six, I suppose that's a fair question. As is the question of "why > is it called virtio_rtc not virtio_ptp?". > Exactly my question, thanks :) > But let me turn it around: if the kernel has access to this virtio > device and *not* any other RTC, why *wouldn't* the kernel use the time > from it? The fact that it can optionally *also* provide paired readings > with the CPU counter doesn't actually *hurt* for the RTC use case, does > it? As long as it doesn't behave differently from the other RTC, I'm fine with this. This is important because I don't want to carry any special infrastructure for this driver or to have to special case this driver later on because it is incompatible with some evolution of the subsystem. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: David Woodhouse <dwmw2@infradead.org> Cc: Peter Hilber <peter.hilber@opensynergy.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, virtio-dev@lists.oasis-open.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, "virtio-comment@lists.oasis-open.org" <virtio-comment@lists.oasis-open.org>, "Christopher S. Hall" <christopher.s.hall@intel.com>, Jason Wang <jasowang@redhat.com>, John Stultz <jstultz@google.com>, "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org, Richard Cochran <richardcochran@gmail.com>, Stephen Boyd <sboyd@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Xuan Zhuo <xuanzhuo@linux.alibaba.com>, Marc Zyngier <maz@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Alessandro Zummo <a.zummo@towertech.it>, "Ridoux, Julien" <ridouxj@amazon.com> Subject: Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes Date: Wed, 13 Mar 2024 15:50:54 +0100 [thread overview] Message-ID: <202403131450547f373268@mail.local> (raw) In-Reply-To: <96be7312f7bddaf06c690e082a8028fa8b511deb.camel@infradead.org> On 13/03/2024 14:06:42+0000, David Woodhouse wrote: > If you're asking why patch 7/7 in Peter's series exists to expose the > virtio clock through RTC, and you're not particularly interested in the > first six, I suppose that's a fair question. As is the question of "why > is it called virtio_rtc not virtio_ptp?". > Exactly my question, thanks :) > But let me turn it around: if the kernel has access to this virtio > device and *not* any other RTC, why *wouldn't* the kernel use the time > from it? The fact that it can optionally *also* provide paired readings > with the CPU counter doesn't actually *hurt* for the RTC use case, does > it? As long as it doesn't behave differently from the other RTC, I'm fine with this. This is important because I don't want to carry any special infrastructure for this driver or to have to special case this driver later on because it is incompatible with some evolution of the subsystem. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-13 14:51 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-18 7:38 [virtio-dev] [RFC PATCH v3 0/7] Add virtio_rtc module and related changes Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` [RFC PATCH v3 1/7] timekeeping: Fix cross-timestamp interpolation on counter wrap Peter Hilber 2024-02-19 16:35 ` [tip: timers/core] " tip-bot2 for Peter Hilber 2023-12-18 7:38 ` [RFC PATCH v3 2/7] timekeeping: Fix cross-timestamp interpolation corner case decision Peter Hilber 2024-02-19 16:35 ` [tip: timers/core] " tip-bot2 for Peter Hilber 2023-12-18 7:38 ` [RFC PATCH v3 3/7] timekeeping: Fix cross-timestamp interpolation for non-x86 Peter Hilber 2024-02-19 16:35 ` [tip: timers/core] " tip-bot2 for Peter Hilber 2023-12-18 7:38 ` [virtio-dev] [RFC PATCH v3 4/7] virtio_rtc: Add module and driver core Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` [virtio-dev] [RFC PATCH v3 5/7] virtio_rtc: Add PTP clocks Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` [virtio-dev] [RFC PATCH v3 6/7] virtio_rtc: Add Arm Generic Timer cross-timestamping Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2023-12-18 7:38 ` [virtio-dev] [RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver Peter Hilber 2023-12-18 7:38 ` Peter Hilber 2024-03-08 17:03 ` Alexandre Belloni 2024-03-11 18:28 ` Peter Hilber 2024-03-11 19:46 ` Alexandre Belloni 2024-03-13 9:13 ` Peter Hilber 2024-03-07 14:02 ` [RFC PATCH v3 0/7] Add virtio_rtc module and related changes David Woodhouse 2024-03-07 14:02 ` David Woodhouse 2024-03-08 10:32 ` Peter Hilber 2024-03-08 10:32 ` Peter Hilber 2024-03-08 12:33 ` David Woodhouse 2024-03-08 12:33 ` David Woodhouse 2024-03-11 18:24 ` Peter Hilber 2024-03-11 18:24 ` Peter Hilber 2024-03-12 17:15 ` David Woodhouse 2024-03-12 17:15 ` David Woodhouse 2024-03-13 9:45 ` Peter Hilber 2024-03-13 9:45 ` Peter Hilber 2024-03-13 11:18 ` Alexandre Belloni 2024-03-13 11:18 ` Alexandre Belloni 2024-03-13 12:29 ` David Woodhouse 2024-03-13 12:29 ` David Woodhouse 2024-03-13 12:58 ` Alexandre Belloni 2024-03-13 12:58 ` Alexandre Belloni 2024-03-13 14:06 ` David Woodhouse 2024-03-13 14:06 ` David Woodhouse 2024-03-13 14:50 ` Alexandre Belloni [this message] 2024-03-13 14:50 ` Alexandre Belloni 2024-03-13 20:12 ` Andrew Lunn 2024-03-13 20:12 ` Andrew Lunn 2024-03-14 9:13 ` Peter Hilber 2024-03-14 9:13 ` Peter Hilber 2024-03-13 17:50 ` Peter Hilber 2024-03-13 17:50 ` Peter Hilber 2024-03-13 14:15 ` Peter Hilber 2024-03-13 14:15 ` Peter Hilber 2024-03-13 12:45 ` David Woodhouse 2024-03-13 12:45 ` David Woodhouse 2024-03-13 17:50 ` Peter Hilber 2024-03-13 17:50 ` Peter Hilber 2024-03-13 18:18 ` David Woodhouse 2024-03-13 18:18 ` David Woodhouse 2024-03-14 10:13 ` Peter Hilber 2024-03-14 10:13 ` Peter Hilber 2024-03-14 14:19 ` David Woodhouse 2024-03-14 14:19 ` David Woodhouse 2024-03-19 13:47 ` Peter Hilber 2024-03-19 13:47 ` Peter Hilber 2024-03-20 17:22 ` David Woodhouse 2024-03-20 17:22 ` David Woodhouse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202403131450547f373268@mail.local \ --to=alexandre.belloni@bootlin.com \ --cc=a.zummo@towertech.it \ --cc=christopher.s.hall@intel.com \ --cc=daniel.lezcano@linaro.org \ --cc=dwmw2@infradead.org \ --cc=jasowang@redhat.com \ --cc=jstultz@google.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=peter.hilber@opensynergy.com \ --cc=richardcochran@gmail.com \ --cc=ridouxj@amazon.com \ --cc=sboyd@kernel.org \ --cc=tglx@linutronix.de \ --cc=virtio-comment@lists.oasis-open.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux.dev \ --cc=xuanzhuo@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.