From: "Lothar Waßmann" <LW@KARO-electronics.de> To: Thomas Gleixner <tglx@linutronix.de> Cc: linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>, Yong Zhang <yong.zhang0@gmail.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] genirq: Fix race condition in ONESHOT irq handler Date: Wed, 8 Feb 2012 07:05:01 +0100 [thread overview] Message-ID: <20274.4237.63380.338503@ipc1.ka-ro> (raw) In-Reply-To: <alpine.LFD.2.02.1202071719340.2794@ionos> Hi, Thomas Gleixner writes: > On Tue, 7 Feb 2012, Lothar Waßmann wrote: > > > There is a race condition in the threaded IRQ handler code for oneshot > > interrupts that may lead to disabling an IRQ indefinitely. IRQs are > > masked before calling the hard-irq handler and are unmasked only after > > the soft-irq handler has been run. Thus if the hard-irq handler > > returns IRQ_HANDLED instead of IRQ_WAKE_THREAD, meaning the soft-irq > > Well, oneshot mode interrupts always had the semantics that the > threaded handler needs to run unconditionally. In fact the oneshot > mode was implemented to handle hardware which cannot do anything in > hard interrupt context to avoid the ugliness of a primary handler > calling disable_irq_nosync(). > > So it looks like driver developers decided that the oneshot mode might > be interesting with a primary handler as well. I can see the reason > why the tsc2007 driver uses it, but that does not make it a bug in the > core code in the first place. > Then maybe the core code should not check the return value of the primary handler for IRQ_WAKE_THREAD but call the secondary handler unconditionally for ONESHOT interrupts. Or it should be at least documented somewhere that primary handlers have to return IRQ_WAKE_THREAD in any case for oneshot interrupts. > > The problem arises also with interrupt controllers that latch a level > > triggered IRQ until it is acknowledged (like the i.MX28 does). > > In this case the IRQ status bit will remain asserted after the > > soft-irq finishes and retrigger the interrupt while the interrupt line > > is already deasserted. > > This does not make sense. We acknowledge interrupts via mask_ack_irq() > right on entry of handle_level_irq(). So either the interrupt > That's right. But at that point the IRQ line is still asserted and since it is a level IRQ this will not actually clear the interrupt status bit. Normally the IRQ status bit would self-clear when the IRQ line is being deasserted (in this case by removing the finger from the touch panel). But the i.MX28 leaves the IRQ status bit set and it takes another write to the IRQ status register to remove the bogus IRQ status. > controller is completely hosed or this explanation is bogus. > The first is the case. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________
WARNING: multiple messages have this Message-ID (diff)
From: LW@KARO-electronics.de (Lothar Waßmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] genirq: Fix race condition in ONESHOT irq handler Date: Wed, 8 Feb 2012 07:05:01 +0100 [thread overview] Message-ID: <20274.4237.63380.338503@ipc1.ka-ro> (raw) In-Reply-To: <alpine.LFD.2.02.1202071719340.2794@ionos> Hi, Thomas Gleixner writes: > On Tue, 7 Feb 2012, Lothar Wa?mann wrote: > > > There is a race condition in the threaded IRQ handler code for oneshot > > interrupts that may lead to disabling an IRQ indefinitely. IRQs are > > masked before calling the hard-irq handler and are unmasked only after > > the soft-irq handler has been run. Thus if the hard-irq handler > > returns IRQ_HANDLED instead of IRQ_WAKE_THREAD, meaning the soft-irq > > Well, oneshot mode interrupts always had the semantics that the > threaded handler needs to run unconditionally. In fact the oneshot > mode was implemented to handle hardware which cannot do anything in > hard interrupt context to avoid the ugliness of a primary handler > calling disable_irq_nosync(). > > So it looks like driver developers decided that the oneshot mode might > be interesting with a primary handler as well. I can see the reason > why the tsc2007 driver uses it, but that does not make it a bug in the > core code in the first place. > Then maybe the core code should not check the return value of the primary handler for IRQ_WAKE_THREAD but call the secondary handler unconditionally for ONESHOT interrupts. Or it should be at least documented somewhere that primary handlers have to return IRQ_WAKE_THREAD in any case for oneshot interrupts. > > The problem arises also with interrupt controllers that latch a level > > triggered IRQ until it is acknowledged (like the i.MX28 does). > > In this case the IRQ status bit will remain asserted after the > > soft-irq finishes and retrigger the interrupt while the interrupt line > > is already deasserted. > > This does not make sense. We acknowledge interrupts via mask_ack_irq() > right on entry of handle_level_irq(). So either the interrupt > That's right. But at that point the IRQ line is still asserted and since it is a level IRQ this will not actually clear the interrupt status bit. Normally the IRQ status bit would self-clear when the IRQ line is being deasserted (in this case by removing the finger from the touch panel). But the i.MX28 leaves the IRQ status bit set and it takes another write to the IRQ status register to remove the bogus IRQ status. > controller is completely hosed or this explanation is bogus. > The first is the case. Lothar Wa?mann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________
next prev parent reply other threads:[~2012-02-08 6:05 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-06 8:14 [BUG] genirq: Race condition in ONESHOT IRQ handler disabling IRQ forever =?utf-8?Q?Lothar_Wa=C3=9Fmann?= 2012-02-06 8:14 ` =?utf-8?Q?Lothar_Wa=C3=9Fmann?= 2012-02-06 10:42 ` Lars-Peter Clausen 2012-02-06 10:42 ` Lars-Peter Clausen 2012-02-07 9:03 ` Yong Zhang 2012-02-07 9:03 ` Yong Zhang 2012-02-07 10:01 ` Lothar Waßmann 2012-02-07 10:01 ` Lothar Waßmann 2012-02-07 12:34 ` Yong Zhang 2012-02-07 12:34 ` Yong Zhang 2012-02-07 12:52 ` Lothar Waßmann 2012-02-07 12:52 ` Lothar Waßmann 2012-02-07 13:07 ` Lars-Peter Clausen 2012-02-07 13:07 ` Lars-Peter Clausen 2012-02-07 13:38 ` [PATCH] genirq: Fix race condition in ONESHOT irq handler Lothar Waßmann 2012-02-07 13:38 ` Lothar Waßmann 2012-02-07 17:03 ` Thomas Gleixner 2012-02-07 17:03 ` Thomas Gleixner 2012-02-08 6:05 ` Lothar Waßmann [this message] 2012-02-08 6:05 ` Lothar Waßmann 2012-02-08 10:38 ` Thomas Gleixner 2012-02-08 10:38 ` Thomas Gleixner 2012-02-09 8:40 ` Lothar Waßmann 2012-02-09 8:40 ` Lothar Waßmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20274.4237.63380.338503@ipc1.ka-ro \ --to=lw@karo-electronics.de \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=yong.zhang0@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.