All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Russell King <linux@arm.linux.org.uk>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: arm: workaround for building with old binutils
Date: Sat, 11 Apr 2015 22:44:59 +0200	[thread overview]
Message-ID: <2057328.zEoCGSuP0u@wuerfel> (raw)
In-Reply-To: <51652361-AEE7-4C88-920A-5F0ED60EE275@linaro.org>

On Saturday 11 April 2015 12:35:19 Ard Biesheuvel wrote:
> 
> Yes, that should work. Could we also move the CE objs to ce-obj-$() and put
> 
> ifneq ($(ce-obj-y)$(ce-obj-m),)
> if <as check>
> obj-y += $(ce-obj-y)
> obj-m += $(ce-obj-m)
> else
> $(warning ...)
> endif
> endif
> 
> around it so you only get the warning if you have selected any of these modules?

Sounds good, I had not thought of that.

> In any case, I strongly prefer to leave the .S files themselves alone if at all possible

Yes, makes sense.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] crypto: arm: workaround for building with old binutils
Date: Sat, 11 Apr 2015 22:44:59 +0200	[thread overview]
Message-ID: <2057328.zEoCGSuP0u@wuerfel> (raw)
In-Reply-To: <51652361-AEE7-4C88-920A-5F0ED60EE275@linaro.org>

On Saturday 11 April 2015 12:35:19 Ard Biesheuvel wrote:
> 
> Yes, that should work. Could we also move the CE objs to ce-obj-$() and put
> 
> ifneq ($(ce-obj-y)$(ce-obj-m),)
> if <as check>
> obj-y += $(ce-obj-y)
> obj-m += $(ce-obj-m)
> else
> $(warning ...)
> endif
> endif
> 
> around it so you only get the warning if you have selected any of these modules?

Sounds good, I had not thought of that.

> In any case, I strongly prefer to leave the .S files themselves alone if at all possible

Yes, makes sense.

	Arnd

  reply	other threads:[~2015-04-11 20:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 19:57 [PATCH] crypto: arm: workaround for building with old binutils Arnd Bergmann
2015-04-10 19:57 ` Arnd Bergmann
2015-04-11  7:41 ` Ard Biesheuvel
2015-04-11  7:41   ` Ard Biesheuvel
2015-04-11  7:41   ` Ard Biesheuvel
2015-04-11  8:55   ` Arnd Bergmann
2015-04-11  8:55     ` Arnd Bergmann
2015-04-11  8:55     ` Arnd Bergmann
2015-04-11 10:35     ` Ard Biesheuvel
2015-04-11 10:35       ` Ard Biesheuvel
2015-04-11 10:35       ` Ard Biesheuvel
2015-04-11 20:44       ` Arnd Bergmann [this message]
2015-04-11 20:44         ` Arnd Bergmann
2015-04-11 13:32 Ard Biesheuvel
2015-04-11 13:32 ` Ard Biesheuvel
2015-04-11 20:54 ` Arnd Bergmann
2015-04-11 20:54   ` Arnd Bergmann
2015-04-12  9:23   ` Ard Biesheuvel
2015-04-12  9:23     ` Ard Biesheuvel
2015-04-12  9:23     ` Ard Biesheuvel
2015-04-13  4:12 ` Herbert Xu
2015-04-13  4:12   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2057328.zEoCGSuP0u@wuerfel \
    --to=arnd@arndb.de \
    --cc=ard.biesheuvel@linaro.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.