From: Arnd Bergmann <arnd@arndb.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: arm: workaround for building with old binutils
Date: Sat, 11 Apr 2015 10:55:35 +0200 [thread overview]
Message-ID: <2148670.W34n3asXfA@wuerfel> (raw)
In-Reply-To: <CAKv+Gu_n0-sMZZjWOmQ5koEfJRX6jqme5WOOP1zrF_zMnB7=nA@mail.gmail.com>
On Saturday 11 April 2015 09:41:08 Ard Biesheuvel wrote:
> Could you perhaps put the rules that build these modules inside a
>
> ifneq ($(armv8-ce-flags),-DARMV8_CE_DISABLED)
> ...
> endif
>
How about something like this:
ifeq ($(call as-option,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),)
$(warning ARMv8 Crypto Extensions need binutils 2.23 or higher)
else
...
endif
That would basically be a reimplementation of the missing "as-option-yn"
macro though, so we could also add that instead and do
ifeq ($(call as-option-yn,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),y)
$(warning ARMv8 Crypto Extensions need binutils 2.23 or higher)
else
...
endif
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] crypto: arm: workaround for building with old binutils
Date: Sat, 11 Apr 2015 10:55:35 +0200 [thread overview]
Message-ID: <2148670.W34n3asXfA@wuerfel> (raw)
In-Reply-To: <CAKv+Gu_n0-sMZZjWOmQ5koEfJRX6jqme5WOOP1zrF_zMnB7=nA@mail.gmail.com>
On Saturday 11 April 2015 09:41:08 Ard Biesheuvel wrote:
> Could you perhaps put the rules that build these modules inside a
>
> ifneq ($(armv8-ce-flags),-DARMV8_CE_DISABLED)
> ...
> endif
>
How about something like this:
ifeq ($(call as-option,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),)
$(warning ARMv8 Crypto Extensions need binutils 2.23 or higher)
else
...
endif
That would basically be a reimplementation of the missing "as-option-yn"
macro though, so we could also add that instead and do
ifeq ($(call as-option-yn,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),y)
$(warning ARMv8 Crypto Extensions need binutils 2.23 or higher)
else
...
endif
Arnd
next prev parent reply other threads:[~2015-04-11 8:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 19:57 [PATCH] crypto: arm: workaround for building with old binutils Arnd Bergmann
2015-04-10 19:57 ` Arnd Bergmann
2015-04-11 7:41 ` Ard Biesheuvel
2015-04-11 7:41 ` Ard Biesheuvel
2015-04-11 7:41 ` Ard Biesheuvel
2015-04-11 8:55 ` Arnd Bergmann [this message]
2015-04-11 8:55 ` Arnd Bergmann
2015-04-11 8:55 ` Arnd Bergmann
2015-04-11 10:35 ` Ard Biesheuvel
2015-04-11 10:35 ` Ard Biesheuvel
2015-04-11 10:35 ` Ard Biesheuvel
2015-04-11 20:44 ` Arnd Bergmann
2015-04-11 20:44 ` Arnd Bergmann
2015-04-11 13:32 Ard Biesheuvel
2015-04-11 13:32 ` Ard Biesheuvel
2015-04-11 20:54 ` Arnd Bergmann
2015-04-11 20:54 ` Arnd Bergmann
2015-04-12 9:23 ` Ard Biesheuvel
2015-04-12 9:23 ` Ard Biesheuvel
2015-04-12 9:23 ` Ard Biesheuvel
2015-04-13 4:12 ` Herbert Xu
2015-04-13 4:12 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2148670.W34n3asXfA@wuerfel \
--to=arnd@arndb.de \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.