All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Branden <scott.branden@broadcom.com>
To: Olof Johansson <olof@lixom.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v2] arm64: defconfig: enable EEPROM_AT25 config option
Date: Mon, 17 Oct 2016 16:24:31 -0700	[thread overview]
Message-ID: <207706e2-8fd4-748f-2ee7-3c372b447a7d@broadcom.com> (raw)
In-Reply-To: <CAOesGMijByw1FYt42toNF6pAEykks_agetQybhgMQj8nAc6xdg@mail.gmail.com>

Hi Olof,

On 16-10-17 02:58 PM, Olof Johansson wrote:
> Hi,
>
> On Wed, Oct 12, 2016 at 11:51 AM, Scott Branden
> <scott.branden@broadcom.com> wrote:
>> Enable support for on board SPI EEPROM by turning on
>> CONFIG_EEPROM_AT25.  This needs to be on in order to
>> boot and test the kernel with a static rootfs image
>> that is not rebuilt everytime the kernel is rebuilt.
>
> If we did this for every kernel option we'd get a huge kernel.
>
> In general, we've said that static options for what's needed to boot
> to rootfs (i.e. storage and network drivers for nfsroot) are fine to
> enable statically.
>
> I doubt you need the EEPROM driver to boot to rootfs on your system,
> so please enable it as a module instead.
>
> Look into using config fragments in case you need to modify the
> options for local builds, it should be a convenient way to have a
> small delta to apply to fit your internal needs, instead of completely
> forking the config file.

Do you allow such config fragments to be upstreamed or do we need to 
maintain these in our tree?

>
>
> -Olof
>

Thanks,
  Scott

WARNING: multiple messages have this Message-ID (diff)
From: scott.branden@broadcom.com (Scott Branden)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: defconfig: enable EEPROM_AT25 config option
Date: Mon, 17 Oct 2016 16:24:31 -0700	[thread overview]
Message-ID: <207706e2-8fd4-748f-2ee7-3c372b447a7d@broadcom.com> (raw)
In-Reply-To: <CAOesGMijByw1FYt42toNF6pAEykks_agetQybhgMQj8nAc6xdg@mail.gmail.com>

Hi Olof,

On 16-10-17 02:58 PM, Olof Johansson wrote:
> Hi,
>
> On Wed, Oct 12, 2016 at 11:51 AM, Scott Branden
> <scott.branden@broadcom.com> wrote:
>> Enable support for on board SPI EEPROM by turning on
>> CONFIG_EEPROM_AT25.  This needs to be on in order to
>> boot and test the kernel with a static rootfs image
>> that is not rebuilt everytime the kernel is rebuilt.
>
> If we did this for every kernel option we'd get a huge kernel.
>
> In general, we've said that static options for what's needed to boot
> to rootfs (i.e. storage and network drivers for nfsroot) are fine to
> enable statically.
>
> I doubt you need the EEPROM driver to boot to rootfs on your system,
> so please enable it as a module instead.
>
> Look into using config fragments in case you need to modify the
> options for local builds, it should be a convenient way to have a
> small delta to apply to fit your internal needs, instead of completely
> forking the config file.

Do you allow such config fragments to be upstreamed or do we need to 
maintain these in our tree?

>
>
> -Olof
>

Thanks,
  Scott

  reply	other threads:[~2016-10-17 23:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 18:51 [PATCH v2] arm64: defconfig: enable EEPROM_AT25 config option Scott Branden
2016-10-12 18:51 ` Scott Branden
2016-10-17 21:58 ` Olof Johansson
2016-10-17 21:58   ` Olof Johansson
2016-10-17 23:24   ` Scott Branden [this message]
2016-10-17 23:24     ` Scott Branden
2016-10-18  0:04     ` Olof Johansson
2016-10-18  0:04       ` Olof Johansson
2016-10-18 20:38       ` Scott Branden
2016-10-18 20:38         ` Scott Branden
2016-10-18 20:48         ` Olof Johansson
2016-10-18 20:48           ` Olof Johansson
2016-10-18 22:23           ` Scott Branden
2016-10-18 22:23             ` Scott Branden
2016-10-19  8:04             ` Arnd Bergmann
2016-10-19  8:04               ` Arnd Bergmann
2016-10-19 16:50               ` Olof Johansson
2016-10-19 16:50                 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=207706e2-8fd4-748f-2ee7-3c372b447a7d@broadcom.com \
    --to=scott.branden@broadcom.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.