* [Intel-wired-lan] [net-next, v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error
@ 2021-09-17 14:11 Hao Chen
2021-09-17 16:01 ` [Intel-wired-lan] [net-next, v1] " Jesse Brandeburg
0 siblings, 1 reply; 5+ messages in thread
From: Hao Chen @ 2021-09-17 14:11 UTC (permalink / raw)
To: intel-wired-lan
After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
[ 5.641579] e1000e: Unknown symbol mutex_lock (err -2)
[ 90.775705] e1000e: Unknown symbol mutex_lock (err -2)
[ 132.252339] e1000e: Unknown symbol mutex_lock (err -2)
This problem fixed after include <linux/mutex.h>.
Signed-off-by: Hao Chen <chenhaoa@uniontech.com>
---
drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h
index 5b2143f4b1f8..f3424255bd2b 100644
--- a/drivers/net/ethernet/intel/e1000e/e1000.h
+++ b/drivers/net/ethernet/intel/e1000e/e1000.h
@@ -21,6 +21,7 @@
#include <linux/ptp_classify.h>
#include <linux/mii.h>
#include <linux/mdio.h>
+#include <linux/mutex.h>
#include <linux/pm_qos.h>
#include "hw.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [net-next,v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error
2021-09-17 14:11 [Intel-wired-lan] [net-next, v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error Hao Chen
@ 2021-09-17 16:01 ` Jesse Brandeburg
0 siblings, 0 replies; 5+ messages in thread
From: Jesse Brandeburg @ 2021-09-17 16:01 UTC (permalink / raw)
To: Hao Chen
Cc: anthony.l.nguyen, davem, kuba, intel-wired-lan, netdev, linux-kernel
On 9/17/2021 7:11 AM, Hao Chen wrote:
> After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
> [ 5.641579] e1000e: Unknown symbol mutex_lock (err -2)
> [ 90.775705] e1000e: Unknown symbol mutex_lock (err -2)
> [ 132.252339] e1000e: Unknown symbol mutex_lock (err -2)
>
> This problem fixed after include <linux/mutex.h>.
Thanks for taking the time to send a patch.
Why do you think including a file will fix this? That error is usually
the user's fault for trying to use insmod which doesn't check module
dependencies.
The advice I usually give is to try modprobe instead, does the problem
still occur without this patch and just using modprobe?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-wired-lan] [net-next, v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error
@ 2021-09-17 16:01 ` Jesse Brandeburg
0 siblings, 0 replies; 5+ messages in thread
From: Jesse Brandeburg @ 2021-09-17 16:01 UTC (permalink / raw)
To: intel-wired-lan
On 9/17/2021 7:11 AM, Hao Chen wrote:
> After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
> [ 5.641579] e1000e: Unknown symbol mutex_lock (err -2)
> [ 90.775705] e1000e: Unknown symbol mutex_lock (err -2)
> [ 132.252339] e1000e: Unknown symbol mutex_lock (err -2)
>
> This problem fixed after include <linux/mutex.h>.
Thanks for taking the time to send a patch.
Why do you think including a file will fix this? That error is usually
the user's fault for trying to use insmod which doesn't check module
dependencies.
The advice I usually give is to try modprobe instead, does the problem
still occur without this patch and just using modprobe?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [net-next,v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error
@ 2021-09-17 14:16 Hao Chen
2021-09-17 10:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 5+ messages in thread
From: Hao Chen @ 2021-09-17 14:16 UTC (permalink / raw)
To: netdev; +Cc: Hao Chen
After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
[ 5.641579] e1000e: Unknown symbol mutex_lock (err -2)
[ 90.775705] e1000e: Unknown symbol mutex_lock (err -2)
[ 132.252339] e1000e: Unknown symbol mutex_lock (err -2)
This problem fixed after include <linux/mutex.h>.
Signed-off-by: Hao Chen <chenhaoa@uniontech.com>
---
drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/e1000e/e1000.h b/drivers/net/ethernet/intel/e1000e/e1000.h
index 5b2143f4b1f8..f3424255bd2b 100644
--- a/drivers/net/ethernet/intel/e1000e/e1000.h
+++ b/drivers/net/ethernet/intel/e1000e/e1000.h
@@ -21,6 +21,7 @@
#include <linux/ptp_classify.h>
#include <linux/mii.h>
#include <linux/mdio.h>
+#include <linux/mutex.h>
#include <linux/pm_qos.h>
#include "hw.h"
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-17 16:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-17 14:11 [Intel-wired-lan] [net-next, v1] net: e1000e: solve insmod 'Unknown symbol mutex_lock' error Hao Chen
2021-09-17 16:01 ` [net-next,v1] " Jesse Brandeburg
2021-09-17 16:01 ` [Intel-wired-lan] [net-next, v1] " Jesse Brandeburg
2021-09-17 14:16 [net-next,v1] " Hao Chen
2021-09-17 10:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.