[igt-dev] [PATCH i-g-t 0/3] Enable kms_color tests for amdgpu devices

[igt-dev] [PATCH i-g-t 0/3] Enable kms_color tests for amdgpu devices

[sunpeng.li]

From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>

The kms_color tests has some assumptions that are not compatible with
AMD hardware. These patches make it more generic.

Leo (Sunpeng) Li (3):
  tests/kms_color: Fill entire frame when painting rectangles
  tests/kms_color: Do not mask LUT for non i915 drivers.
  tests/kms_color: Enable color tests for AMDGPU

 tests/kms_color.c | 28 +++++++++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 1/3] tests/kms_color: Fill entire frame when painting rectangles

[sunpeng.li]

From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>

Fill entire frame to avoid garbage data from being included in CRC
calculations.

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
---
 tests/kms_color.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index dc4fcce..c312697 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -71,6 +71,7 @@ static void paint_gradient_rectangles(data_t *data,
 {
 	cairo_t *cr = igt_get_cairo_ctx(data->drm_fd, fb);
 	int i, l = mode->hdisplay / 3;
+	int rows_remaining = mode->hdisplay % 3;
 
 	/* Paint 3 gradient rectangles with red/green/blue between 1.0 and
 	 * 0.5. We want to avoid 0 so each max LUTs only affect their own
@@ -86,6 +87,16 @@ static void paint_gradient_rectangles(data_t *data,
 					       colors[i].b);
 	}
 
+	if (rows_remaining > 0)
+		igt_paint_color_gradient_range(cr, i * l, 0, rows_remaining,
+					       mode->vdisplay,
+					       colors[i-1].r != 0 ? 0.2 : 0,
+					       colors[i-1].g != 0 ? 0.2 : 0,
+					       colors[i-1].b != 0 ? 0.2 : 0,
+					       colors[i-1].r,
+					       colors[i-1].g,
+					       colors[i-1].b);
+
 	igt_put_cairo_ctx(data->drm_fd, fb, cr);
 }
 
@@ -96,6 +107,7 @@ static void paint_rectangles(data_t *data,
 {
 	cairo_t *cr = igt_get_cairo_ctx(data->drm_fd, fb);
 	int i, l = mode->hdisplay / 3;
+	int rows_remaining = mode->hdisplay % 3;
 
 	/* Paint 3 solid rectangles. */
 	for (i = 0 ; i < 3; i++) {
@@ -103,6 +115,10 @@ static void paint_rectangles(data_t *data,
 				colors[i].r, colors[i].g, colors[i].b);
 	}
 
+	if (rows_remaining > 0)
+		igt_paint_color(cr, i * l, 0, rows_remaining, mode->vdisplay,
+				colors[i-1].r, colors[i-1].g, colors[i-1].b);
+
 	igt_put_cairo_ctx(data->drm_fd, fb, cr);
 }
 
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/3] tests/kms_color: Do not mask LUT for non i915 drivers.

[sunpeng.li]

From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>

---
 tests/kms_color.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index c312697..1e51917 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -165,7 +165,12 @@ static struct _drm_color_lut *coeffs_to_lut(data_t *data,
 	struct _drm_color_lut *lut;
 	uint32_t i;
 	uint32_t max_value = (1 << 16) - 1;
-	uint32_t mask = ((1 << color_depth) - 1) << 8;
+	uint32_t mask;
+
+	if (is_i915_device(data->drm_fd))
+		mask = ((1 << color_depth) - 1) << 8;
+	else
+		mask = max_value;
 
 	lut = malloc(sizeof(struct _drm_color_lut) * lut_size);
 
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 3/3] tests/kms_color: Enable color tests for AMDGPU

[sunpeng.li]

From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
---
 tests/kms_color.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index 1e51917..bb106dd 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -1158,8 +1158,9 @@ igt_main
 	igt_skip_on_simulation();
 
 	igt_fixture {
-		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
-		data.devid = intel_get_drm_devid(data.drm_fd);
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_AMDGPU);
+		if (is_i915_device(data.drm_fd))
+			data.devid = intel_get_drm_devid(data.drm_fd);
 		kmstest_set_vt_graphics_mode();
 
 		igt_display_init(&data.display, data.drm_fd);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2 2/3] tests/kms_color: Do not mask LUT for non i915 drivers.

[sunpeng.li]

From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>

Masking assumes a direct relationship between the software LUT
structure, and hardware LUT. This is not always the case.

On AMD hardware for example, the hardware LUT is composed of
piecewise-linear segments, with end-point spaced exponentially along the
X axis, while software LUT is spaced linearly. Masking the LUT for the
purpose of truncating the resulting colors won't work here.

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>

v2: Add commit message and sign off.
---
 tests/kms_color.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index c312697..1e51917 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -165,7 +165,12 @@ static struct _drm_color_lut *coeffs_to_lut(data_t *data,
 	struct _drm_color_lut *lut;
 	uint32_t i;
 	uint32_t max_value = (1 << 16) - 1;
-	uint32_t mask = ((1 << color_depth) - 1) << 8;
+	uint32_t mask;
+
+	if (is_i915_device(data->drm_fd))
+		mask = ((1 << color_depth) - 1) << 8;
+	else
+		mask = max_value;
 
 	lut = malloc(sizeof(struct _drm_color_lut) * lut_size);
 
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for Enable kms_color tests for amdgpu devices (rev2)

[Patchwork]

== Series Details ==

Series: Enable kms_color tests for amdgpu devices (rev2)
URL   : https://patchwork.freedesktop.org/series/41644/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4428 -> IGTPW_1252 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/41644/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1252 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ringfill@basic-default-hang:
      fi-pnv-d510:        NOTRUN -> DMESG-WARN (fdo#101600)
      fi-blb-e6850:       NOTRUN -> DMESG-WARN (fdo#101600)

    igt@kms_pipe_crc_basic@read-crc-pipe-c:
      fi-skl-guc:         PASS -> FAIL (fdo#103191)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         NOTRUN -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-skl-6770hq:      FAIL (fdo#100368, fdo#103928) -> PASS

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      fi-skl-guc:         FAIL (fdo#103191) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928


== Participating hosts (29 -> 33) ==

  Additional (7): fi-kbl-7567u fi-bxt-dsi fi-skl-gvtdvm fi-bdw-gvtdvm fi-pnv-d510 fi-elk-e7500 fi-blb-e6850 
  Missing    (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4428 -> IGTPW_1252
    * Linux: CI_DRM_4049 -> CI_DRM_4050
    * Piglit: piglit_4428 -> piglit_4429

  CI_DRM_4049: 3dbfa04d62f1f1214a03c3b2d30f987dccf50ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4050: dc857e9d853d2bd074adaf49c49deb473328ea72 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1252: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1252/
  IGT_4428: aa330c72a74c071eddb35300e4dd1957eb8d30ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4428: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
  piglit_4429: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1252/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for Enable kms_color tests for amdgpu devices (rev2)

[Patchwork]

== Series Details ==

Series: Enable kms_color tests for amdgpu devices (rev2)
URL   : https://patchwork.freedesktop.org/series/41644/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4428_full -> IGTPW_1252_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1252_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1252_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/41644/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1252_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-blt:
      shard-kbl:          SKIP -> PASS

    igt@gem_mocs_settings@mocs-rc6-bsd2:
      shard-kbl:          PASS -> SKIP

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-snb:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in IGTPW_1252_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
      shard-hsw:          PASS -> FAIL (fdo#102670)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-apl:          PASS -> FAIL (fdo#103167) +1

    igt@perf@blocking:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    
    ==== Possible fixes ====

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-hsw:          FAIL (fdo#102887) -> PASS

    igt@kms_flip@dpms-vs-vblank-race:
      shard-hsw:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-hsw:          FAIL (fdo#100368) -> PASS +1

    igt@kms_frontbuffer_tracking@fbc-suspend:
      shard-kbl:          DMESG-WARN (fdo#103558, fdo#103313) -> PASS +7

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@kms_sysfs_edid_timing:
      shard-apl:          WARN (fdo#100047) -> PASS

    igt@kms_vblank@pipe-b-accuracy-idle:
      shard-hsw:          FAIL (fdo#102583) -> PASS

    igt@perf@polling:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    igt@pm_rpm@gem-pread:
      shard-kbl:          DMESG-WARN (fdo#103558) -> PASS +5

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
  fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 4) ==

  Missing    (1): shard-glkb 


== Build changes ==

    * IGT: IGT_4428 -> IGTPW_1252
    * Linux: CI_DRM_4049 -> CI_DRM_4050
    * Piglit: piglit_4428 -> piglit_4429

  CI_DRM_4049: 3dbfa04d62f1f1214a03c3b2d30f987dccf50ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4050: dc857e9d853d2bd074adaf49c49deb473328ea72 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1252: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1252/
  IGT_4428: aa330c72a74c071eddb35300e4dd1957eb8d30ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4428: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit
  piglit_4429: 93b35926a150e318439d2505901288594b3548f5 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1252/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 0/3] Enable kms_color tests for amdgpu devices

[Harry Wentland]

On 2018-04-12 05:37 PM, sunpeng.li@amd.com wrote:
> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>

Patchset (with v2 of patch 2) is
Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> 
> The kms_color tests has some assumptions that are not compatible with
> AMD hardware. These patches make it more generic.
> 
> Leo (Sunpeng) Li (3):
>   tests/kms_color: Fill entire frame when painting rectangles
>   tests/kms_color: Do not mask LUT for non i915 drivers.
>   tests/kms_color: Enable color tests for AMDGPU
> 
>  tests/kms_color.c | 28 +++++++++++++++++++++++++---
>  1 file changed, 25 insertions(+), 3 deletions(-)
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 0/3] Enable kms_color tests for amdgpu devices

[Arkadiusz Hiler]

On Thu, Apr 12, 2018 at 05:37:23PM -0400, sunpeng.li@amd.com wrote:
> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>
> 
> The kms_color tests has some assumptions that are not compatible with
> AMD hardware. These patches make it more generic.
> 
> Leo (Sunpeng) Li (3):
>   tests/kms_color: Fill entire frame when painting rectangles
>   tests/kms_color: Do not mask LUT for non i915 drivers.
>   tests/kms_color: Enable color tests for AMDGPU
> 
>  tests/kms_color.c | 28 +++++++++++++++++++++++++---
>  1 file changed, 25 insertions(+), 3 deletions(-)

The whole series is
Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

It was my assumption that much of the kms tests can be enabled on
non-Intel hardware with just a little bit of work. It's good to see that
someone is taking an effort.

Are you planning on enabling more of the test? I guess we have quite a
lot of superfluous igt_require_gem() calls scattered around, that should
be easy to get rid of.

Thanks for the patches, I've just pushed them :-)

-- 
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 0/3] Enable kms_color tests for amdgpu devices

[Harry Wentland]

On 2018-04-13 06:12 PM, Arkadiusz Hiler wrote:
> On Thu, Apr 12, 2018 at 05:37:23PM -0400, sunpeng.li@amd.com wrote:
>> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>
>>
>> The kms_color tests has some assumptions that are not compatible with
>> AMD hardware. These patches make it more generic.
>>
>> Leo (Sunpeng) Li (3):
>>   tests/kms_color: Fill entire frame when painting rectangles
>>   tests/kms_color: Do not mask LUT for non i915 drivers.
>>   tests/kms_color: Enable color tests for AMDGPU
>>
>>  tests/kms_color.c | 28 +++++++++++++++++++++++++---
>>  1 file changed, 25 insertions(+), 3 deletions(-)
> 
> The whole series is
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> 
> It was my assumption that much of the kms tests can be enabled on
> non-Intel hardware with just a little bit of work. It's good to see that
> someone is taking an effort.
> 
> Are you planning on enabling more of the test? I guess we have quite a
> lot of superfluous igt_require_gem() calls scattered around, that should
> be easy to get rid of.
> 

Over time, yes. We have quite limited resources to spend on IGT but would love to do more.

> Thanks for the patches, I've just pushed them :-)
> 

Thanks for pushing. I think I might have commit rights but didn't want to rush pushing them without giving someone else a chance to review.

Harry
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 0/3] Enable kms_color tests for amdgpu devices

[Arkadiusz Hiler]

On Mon, Apr 16, 2018 at 09:42:37AM -0400, Harry Wentland wrote:
> On 2018-04-13 06:12 PM, Arkadiusz Hiler wrote:
> > On Thu, Apr 12, 2018 at 05:37:23PM -0400, sunpeng.li@amd.com wrote:
> >> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>
> >>
> >> The kms_color tests has some assumptions that are not compatible with
> >> AMD hardware. These patches make it more generic.
> >>
> >> Leo (Sunpeng) Li (3):
> >>   tests/kms_color: Fill entire frame when painting rectangles
> >>   tests/kms_color: Do not mask LUT for non i915 drivers.
> >>   tests/kms_color: Enable color tests for AMDGPU
> >>
> >>  tests/kms_color.c | 28 +++++++++++++++++++++++++---
> >>  1 file changed, 25 insertions(+), 3 deletions(-)
> > 
> > The whole series is
> > Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > 
> > It was my assumption that much of the kms tests can be enabled on
> > non-Intel hardware with just a little bit of work. It's good to see that
> > someone is taking an effort.
> > 
> > Are you planning on enabling more of the test? I guess we have quite a
> > lot of superfluous igt_require_gem() calls scattered around, that should
> > be easy to get rid of.
> > 
> 
> Over time, yes. We have quite limited resources to spend on IGT but would love to do more.

I understand. This is awesome nonetheless.

> > Thanks for the patches, I've just pushed them :-)
> > 
> 
> Thanks for pushing. I think I might have commit rights but didn't want
> to rush pushing them without giving someone else a chance to review.

Sorry for not adding your r-b. I think the mails was stuck in the
moderation queue. Are you subscribed to this new-ish mailing list?

- Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev