From: David Lechner <david@lechnology.com>
To: Axel Haslam <ahaslam@baylibre.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
robh+dt@kernel.org, Sekhar Nori <nsekhar@ti.com>,
Alan Stern <stern@rowland.harvard.edu>,
Kevin Hilman <khilman@baylibre.com>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>,
manjunath.goudar@linaro.org, Mark Brown <broonie@kernel.org>,
Alexandre Bailon <abailon@baylibre.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver
Date: Tue, 25 Oct 2016 11:12:23 -0500 [thread overview]
Message-ID: <21019d11-3b01-3e0e-60bc-c4873cf20237@lechnology.com> (raw)
In-Reply-To: <CAKXjFTPvEXPRyq0HZiF7mcHWFaFoH7MjFqEKnTyuSCUOB=U7Aw@mail.gmail.com>
On 10/25/2016 02:39 AM, Axel Haslam wrote:
> On Tue, Oct 25, 2016 at 2:38 AM, David Lechner <david@lechnology.com> wrote:
>> On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote:
>>>
>>> -#ifndef CONFIG_ARCH_DAVINCI_DA8XX
>>> -#error "This file is DA8xx bus glue. Define CONFIG_ARCH_DAVINCI_DA8XX."
>>> -#endif
>>> +#include "ohci.h"
>>> +
>>> +#define DRIVER_DESC "OHCI DA8XX driver"
>>> +
>>> +static const char hcd_name[] = "ohci-da8xx";
>>
>>
>> why static const char instead of #define? This is only used one time in a
>> pr_info, so it seems kind of pointless anyway.
>
> Other drivers are using static const for the same variable.
> i think static const is preferred over #define because #define doet give a type.
> If you dont mind ill keep it static const.
>
If this string was used in this file more than one place, I would agree
with you, but currently it is only used as the argument of a pr_info().
The string "ohci-da8xx" could just be included in the fmt string instead
of using "%s".
WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
To: Axel Haslam <ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: Greg KH
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Sergei Shtylyov
<sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>,
manjunath.goudar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Alexandre Bailon
<abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver
Date: Tue, 25 Oct 2016 11:12:23 -0500 [thread overview]
Message-ID: <21019d11-3b01-3e0e-60bc-c4873cf20237@lechnology.com> (raw)
In-Reply-To: <CAKXjFTPvEXPRyq0HZiF7mcHWFaFoH7MjFqEKnTyuSCUOB=U7Aw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 10/25/2016 02:39 AM, Axel Haslam wrote:
> On Tue, Oct 25, 2016 at 2:38 AM, David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> wrote:
>> On 10/24/2016 11:46 AM, ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org wrote:
>>>
>>> -#ifndef CONFIG_ARCH_DAVINCI_DA8XX
>>> -#error "This file is DA8xx bus glue. Define CONFIG_ARCH_DAVINCI_DA8XX."
>>> -#endif
>>> +#include "ohci.h"
>>> +
>>> +#define DRIVER_DESC "OHCI DA8XX driver"
>>> +
>>> +static const char hcd_name[] = "ohci-da8xx";
>>
>>
>> why static const char instead of #define? This is only used one time in a
>> pr_info, so it seems kind of pointless anyway.
>
> Other drivers are using static const for the same variable.
> i think static const is preferred over #define because #define doet give a type.
> If you dont mind ill keep it static const.
>
If this string was used in this file more than one place, I would agree
with you, but currently it is only used as the argument of a pr_info().
The string "ohci-da8xx" could just be included in the fmt string instead
of using "%s".
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver
Date: Tue, 25 Oct 2016 11:12:23 -0500 [thread overview]
Message-ID: <21019d11-3b01-3e0e-60bc-c4873cf20237@lechnology.com> (raw)
In-Reply-To: <CAKXjFTPvEXPRyq0HZiF7mcHWFaFoH7MjFqEKnTyuSCUOB=U7Aw@mail.gmail.com>
On 10/25/2016 02:39 AM, Axel Haslam wrote:
> On Tue, Oct 25, 2016 at 2:38 AM, David Lechner <david@lechnology.com> wrote:
>> On 10/24/2016 11:46 AM, ahaslam at baylibre.com wrote:
>>>
>>> -#ifndef CONFIG_ARCH_DAVINCI_DA8XX
>>> -#error "This file is DA8xx bus glue. Define CONFIG_ARCH_DAVINCI_DA8XX."
>>> -#endif
>>> +#include "ohci.h"
>>> +
>>> +#define DRIVER_DESC "OHCI DA8XX driver"
>>> +
>>> +static const char hcd_name[] = "ohci-da8xx";
>>
>>
>> why static const char instead of #define? This is only used one time in a
>> pr_info, so it seems kind of pointless anyway.
>
> Other drivers are using static const for the same variable.
> i think static const is preferred over #define because #define doet give a type.
> If you dont mind ill keep it static const.
>
If this string was used in this file more than one place, I would agree
with you, but currently it is only used as the argument of a pr_info().
The string "ohci-da8xx" could just be included in the fmt string instead
of using "%s".
next prev parent reply other threads:[~2016-10-25 16:12 UTC|newest]
Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:46 [PATCH/RFT v2 00/17] Add DT support for ohci-da8xx ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` [PATCH/RFT v2 01/17] ARM: davinci: da8xx: add usb phy clocks ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 8:10 ` Sekhar Nori
2016-10-25 8:10 ` Sekhar Nori
2016-10-25 8:10 ` Sekhar Nori
2016-10-25 9:37 ` Axel Haslam
2016-10-25 9:37 ` Axel Haslam
2016-10-25 9:37 ` Axel Haslam
2016-10-25 10:17 ` Sekhar Nori
2016-10-25 10:17 ` Sekhar Nori
2016-10-25 10:17 ` Sekhar Nori
2016-10-25 15:53 ` David Lechner
2016-10-25 15:53 ` David Lechner
2016-10-25 15:53 ` David Lechner
2016-10-26 8:56 ` Sekhar Nori
2016-10-26 8:56 ` Sekhar Nori
2016-10-26 8:56 ` Sekhar Nori
2016-10-24 16:46 ` [PATCH/RFT v2 03/17] ARM: davinci: da8xx: Add USB PHY " ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 9:18 ` Sekhar Nori
2016-10-25 9:18 ` Sekhar Nori
2016-10-25 9:18 ` Sekhar Nori
2016-10-25 9:37 ` Axel Haslam
2016-10-25 9:37 ` Axel Haslam
2016-10-25 9:37 ` Axel Haslam
2016-10-24 16:46 ` [PATCH/RFT v2 04/17] ARM: DTS: da850: Add cfgchip syscon node ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam
2016-10-24 16:46 ` [PATCH/RFT v2 05/17] ARM: DTS: da850: Add usb phy node ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam
2016-10-24 16:46 ` [PATCH/RFT v2 06/17] ARM: davinci: da8xx: Fix some redefined symbol warnings ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 10:03 ` Sekhar Nori
2016-10-25 10:03 ` Sekhar Nori
2016-10-25 10:03 ` Sekhar Nori
2016-10-25 12:14 ` Alexandre Bailon
2016-10-25 12:14 ` Alexandre Bailon
2016-10-25 12:14 ` Alexandre Bailon
2016-10-24 16:46 ` [PATCH/RFT v2 07/17] ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam
2016-10-25 2:53 ` David Lechner
2016-10-25 2:53 ` David Lechner
2016-10-25 10:01 ` Axel Haslam
2016-10-25 10:01 ` Axel Haslam
2016-10-25 10:12 ` Sekhar Nori
2016-10-25 10:12 ` Sekhar Nori
2016-10-25 10:12 ` Sekhar Nori
2016-10-25 16:05 ` David Lechner
2016-10-25 16:05 ` David Lechner
2016-10-25 16:05 ` David Lechner
2016-10-26 9:30 ` Sekhar Nori
2016-10-26 9:30 ` Sekhar Nori
2016-10-26 9:30 ` Sekhar Nori
2016-10-24 16:46 ` [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-25 10:28 ` Sekhar Nori
2016-10-25 10:28 ` Sekhar Nori
2016-10-25 10:28 ` Sekhar Nori
2016-10-25 10:31 ` Axel Haslam
2016-10-25 10:31 ` Axel Haslam
2016-10-25 10:31 ` Axel Haslam
2016-10-24 16:46 ` [PATCH/RFT v2 09/17] regulator: fixed: Add over current event ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-24 17:43 ` Mark Brown
2016-10-24 17:43 ` Mark Brown
2016-10-24 17:43 ` Mark Brown
2016-10-24 17:53 ` Axel Haslam
2016-10-24 17:53 ` Axel Haslam
2016-10-24 17:53 ` Mark Brown
2016-10-24 17:53 ` Mark Brown
2016-10-24 17:53 ` Mark Brown
2016-10-24 18:11 ` Axel Haslam
2016-10-24 18:11 ` Axel Haslam
2016-10-24 18:11 ` Axel Haslam
2016-10-24 18:19 ` Mark Brown
2016-10-24 18:19 ` Mark Brown
2016-10-25 12:55 ` Axel Haslam
2016-10-25 12:55 ` Axel Haslam
2016-10-25 14:33 ` Mark Brown
2016-10-25 14:33 ` Mark Brown
2016-10-25 14:57 ` Axel Haslam
2016-10-25 14:57 ` Axel Haslam
2016-10-25 15:07 ` Axel Haslam
2016-10-25 15:07 ` Axel Haslam
2016-10-30 20:42 ` Rob Herring
2016-10-30 20:42 ` Rob Herring
2016-10-24 16:46 ` [PATCH/RFT v2 10/17] USB: da8xx: use flag instead of bitmask for over current change ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-24 16:46 ` [PATCH/RFT v2 11/17] USB: OHCI: make ohci-da8xx a separate driver ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 0:38 ` David Lechner
2016-10-25 0:38 ` David Lechner
2016-10-25 0:38 ` David Lechner
2016-10-25 7:39 ` Axel Haslam
2016-10-25 7:39 ` Axel Haslam
2016-10-25 7:39 ` Axel Haslam
2016-10-25 16:12 ` David Lechner [this message]
2016-10-25 16:12 ` David Lechner
2016-10-25 16:12 ` David Lechner
2016-10-25 16:21 ` Axel Haslam
2016-10-25 16:21 ` Axel Haslam
2016-10-25 16:21 ` Axel Haslam
2016-10-25 16:24 ` David Lechner
2016-10-25 16:24 ` David Lechner
2016-10-25 16:24 ` David Lechner
2016-10-24 16:46 ` [PATCH/RFT v2 12/17] USB: ochi-da8xx: Use a regulator for vbus/overcurrent ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 1:39 ` David Lechner
2016-10-25 1:39 ` David Lechner
2016-10-25 1:39 ` David Lechner
2016-10-25 8:24 ` Axel Haslam
2016-10-25 8:24 ` Axel Haslam
2016-10-25 8:24 ` Axel Haslam
2016-10-25 16:53 ` David Lechner
2016-10-25 16:53 ` David Lechner
2016-10-25 16:53 ` David Lechner
2016-10-25 17:32 ` Axel Haslam
2016-10-25 17:32 ` Axel Haslam
2016-10-25 10:43 ` Sekhar Nori
2016-10-25 10:43 ` Sekhar Nori
2016-10-25 10:43 ` Sekhar Nori
2016-10-25 10:52 ` Axel Haslam
2016-10-25 10:52 ` Axel Haslam
2016-10-25 10:52 ` Axel Haslam
2016-10-24 16:46 ` [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 1:12 ` David Lechner
2016-10-25 1:12 ` David Lechner
2016-10-25 1:12 ` David Lechner
2016-10-25 9:56 ` Axel Haslam
2016-10-25 9:56 ` Axel Haslam
2016-10-24 16:46 ` [PATCH/RFT v2 14/17] ARM: davinci: register the usb20_phy clock on the DT file ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-24 16:46 ` [PATCH/RFT v2 15/17] usb: host: ohci-da8xx: Add devicetree bindings documentation ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 1:02 ` David Lechner
2016-10-25 1:02 ` David Lechner
2016-10-25 1:02 ` David Lechner
2016-10-25 9:56 ` Axel Haslam
2016-10-25 9:56 ` Axel Haslam
2016-10-25 9:56 ` Axel Haslam
2016-10-24 16:46 ` [PATCH/RFT v2 16/17] USB: ohci-da8xx: Allow probing from DT ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-24 16:46 ` ahaslam-rdvid1DuHRBWk0Htik3J/w
2016-10-25 0:53 ` David Lechner
2016-10-25 0:53 ` David Lechner
2016-10-25 0:53 ` David Lechner
2016-10-25 8:10 ` Axel Haslam
2016-10-25 8:10 ` Axel Haslam
2016-10-24 16:46 ` [PATCH/RFT v2 17/17] ARM: dts: da850: add usb device node ahaslam
2016-10-24 16:46 ` ahaslam at baylibre.com
2016-10-25 0:48 ` David Lechner
2016-10-25 0:48 ` David Lechner
2016-10-25 0:48 ` David Lechner
2016-10-25 8:03 ` Axel Haslam
2016-10-25 8:03 ` Axel Haslam
2016-10-25 8:03 ` Axel Haslam
2016-10-25 10:55 ` [PATCH/RFT v2 00/17] Add DT support for ohci-da8xx Sekhar Nori
2016-10-25 10:55 ` Sekhar Nori
2016-10-25 10:55 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21019d11-3b01-3e0e-60bc-c4873cf20237@lechnology.com \
--to=david@lechnology.com \
--cc=abailon@baylibre.com \
--cc=ahaslam@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manjunath.goudar@linaro.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.