From: Arnd Bergmann <arnd@arndb.de>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
Simon Horman <horms@verge.net.au>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
artemi.ivanov@cogentembedded.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask
Date: Thu, 29 Dec 2016 22:18:41 +0100 [thread overview]
Message-ID: <2103911.qf9H68dkRp@wuerfel> (raw)
In-Reply-To: <1483044304-2085-1-git-send-email-nikita.yoush@cogentembedded.com>
On Thursday, December 29, 2016 11:45:03 PM CET Nikita Yushchenko wrote:
>
> static int __swiotlb_dma_supported(struct device *hwdev, u64 mask)
> {
> +#ifdef CONFIG_PCI
> + if (dev_is_pci(hwdev)) {
> + struct pci_dev *pdev = to_pci_dev(hwdev);
> + struct pci_host_bridge *br = pci_find_host_bridge(pdev->bus);
> +
> + if (br->dev.dma_mask && (*br->dev.dma_mask) &&
> + (mask & (*br->dev.dma_mask)) != mask)
> + return 0;
> + }
> +#endif
> if (swiotlb)
> return swiotlb_dma_supported(hwdev, mask);
> return 1;
>
I think it's wrong to make this a special case for PCI.
Instead, we should follow the dma-ranges properties during dma_set_mask()
to ensure we don't set a mask that any of the parents up to the root
cannot support.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Simon Horman <horms@verge.net.au>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
artemi.ivanov@cogentembedded.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask
Date: Thu, 29 Dec 2016 22:18:41 +0100 [thread overview]
Message-ID: <2103911.qf9H68dkRp@wuerfel> (raw)
In-Reply-To: <1483044304-2085-1-git-send-email-nikita.yoush@cogentembedded.com>
On Thursday, December 29, 2016 11:45:03 PM CET Nikita Yushchenko wrote:
>
> static int __swiotlb_dma_supported(struct device *hwdev, u64 mask)
> {
> +#ifdef CONFIG_PCI
> + if (dev_is_pci(hwdev)) {
> + struct pci_dev *pdev = to_pci_dev(hwdev);
> + struct pci_host_bridge *br = pci_find_host_bridge(pdev->bus);
> +
> + if (br->dev.dma_mask && (*br->dev.dma_mask) &&
> + (mask & (*br->dev.dma_mask)) != mask)
> + return 0;
> + }
> +#endif
> if (swiotlb)
> return swiotlb_dma_supported(hwdev, mask);
> return 1;
>
I think it's wrong to make this a special case for PCI.
Instead, we should follow the dma-ranges properties during dma_set_mask()
to ensure we don't set a mask that any of the parents up to the root
cannot support.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask
Date: Thu, 16 Feb 2017 16:12:55 -0000 [thread overview]
Message-ID: <2103911.qf9H68dkRp@wuerfel> (raw)
In-Reply-To: <1483044304-2085-1-git-send-email-nikita.yoush@cogentembedded.com>
On Thursday, December 29, 2016 11:45:03 PM CET Nikita Yushchenko wrote:
>
> static int __swiotlb_dma_supported(struct device *hwdev, u64 mask)
> {
> +#ifdef CONFIG_PCI
> + if (dev_is_pci(hwdev)) {
> + struct pci_dev *pdev = to_pci_dev(hwdev);
> + struct pci_host_bridge *br = pci_find_host_bridge(pdev->bus);
> +
> + if (br->dev.dma_mask && (*br->dev.dma_mask) &&
> + (mask & (*br->dev.dma_mask)) != mask)
> + return 0;
> + }
> +#endif
> if (swiotlb)
> return swiotlb_dma_supported(hwdev, mask);
> return 1;
>
I think it's wrong to make this a special case for PCI.
Instead, we should follow the dma-ranges properties during dma_set_mask()
to ensure we don't set a mask that any of the parents up to the root
cannot support.
Arnd
next prev parent reply other threads:[~2017-02-16 16:13 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 20:45 [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask Nikita Yushchenko
2016-12-29 20:45 ` Nikita Yushchenko
2016-12-29 20:45 ` [PATCH 2/2] rcar-pcie: set host bridge's " Nikita Yushchenko
2016-12-29 20:45 ` Nikita Yushchenko
2016-12-29 21:18 ` Arnd Bergmann [this message]
2017-02-16 16:12 ` [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit " Arnd Bergmann
2016-12-29 21:18 ` Arnd Bergmann
2016-12-30 9:46 ` Sergei Shtylyov
2016-12-30 9:46 ` Sergei Shtylyov
2016-12-30 10:06 ` Sergei Shtylyov
2016-12-30 10:06 ` Sergei Shtylyov
2017-01-03 18:44 ` Will Deacon
2017-01-03 18:44 ` Will Deacon
2017-01-03 19:00 ` Nikita Yushchenko
2017-01-03 19:00 ` Nikita Yushchenko
2017-01-03 19:01 ` Nikita Yushchenko
2017-01-03 19:01 ` Nikita Yushchenko
2017-01-03 19:01 ` Nikita Yushchenko
2017-01-03 20:13 ` Grygorii Strashko
2017-01-03 20:13 ` Grygorii Strashko
2017-01-03 20:13 ` Grygorii Strashko
2017-01-03 20:23 ` Nikita Yushchenko
2017-01-03 20:23 ` Nikita Yushchenko
2017-01-03 20:23 ` Nikita Yushchenko
2017-01-03 23:13 ` Arnd Bergmann
2017-01-03 23:13 ` Arnd Bergmann
2017-01-03 23:13 ` Arnd Bergmann
2017-01-04 6:24 ` Nikita Yushchenko
2017-01-04 6:24 ` Nikita Yushchenko
2017-01-04 6:24 ` Nikita Yushchenko
2017-01-04 13:29 ` Arnd Bergmann
2017-01-04 13:29 ` Arnd Bergmann
2017-01-04 13:29 ` Arnd Bergmann
2017-01-04 14:30 ` Nikita Yushchenko
2017-01-04 14:30 ` Nikita Yushchenko
2017-01-04 14:30 ` Nikita Yushchenko
2017-01-04 14:46 ` Arnd Bergmann
2017-01-04 14:46 ` Arnd Bergmann
2017-01-04 15:29 ` Nikita Yushchenko
2017-01-04 15:29 ` Nikita Yushchenko
2017-01-04 15:29 ` Nikita Yushchenko
2017-01-06 11:10 ` Arnd Bergmann
2017-01-06 11:10 ` Arnd Bergmann
2017-01-06 11:10 ` Arnd Bergmann
2017-01-06 13:47 ` Nikita Yushchenko
2017-01-06 13:47 ` Nikita Yushchenko
2017-01-06 13:47 ` Nikita Yushchenko
2017-01-06 14:38 ` [PATCH] arm64: do not set dma masks that device connection can't handle Nikita Yushchenko
2017-01-06 14:38 ` Nikita Yushchenko
2017-01-06 14:45 ` Nikita Yushchenko
2017-01-06 14:45 ` Nikita Yushchenko
2017-01-08 7:09 ` Sergei Shtylyov
2017-01-08 7:09 ` Sergei Shtylyov
2017-01-09 6:56 ` Nikita Yushchenko
2017-01-09 6:56 ` Nikita Yushchenko
2017-01-09 14:05 ` [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask Arnd Bergmann
2017-01-09 14:05 ` Arnd Bergmann
2017-01-09 14:05 ` Arnd Bergmann
2017-01-09 20:34 ` Nikita Yushchenko
2017-01-09 20:34 ` Nikita Yushchenko
2017-01-09 20:34 ` Nikita Yushchenko
2017-01-09 20:34 ` Nikita Yushchenko
2017-01-09 20:57 ` Christoph Hellwig
2017-01-09 20:57 ` Christoph Hellwig
2017-01-09 20:57 ` Christoph Hellwig
2017-01-09 20:57 ` Christoph Hellwig
2017-01-10 6:47 ` NVMe vs DMA addressing limitations Nikita Yushchenko
2017-01-10 7:07 ` Christoph Hellwig
2017-01-10 7:07 ` Christoph Hellwig
2017-01-10 7:07 ` Christoph Hellwig
2017-01-10 7:07 ` Christoph Hellwig
2017-01-10 7:31 ` Nikita Yushchenko
2017-01-10 7:31 ` Nikita Yushchenko
2017-01-10 7:31 ` Nikita Yushchenko
2017-01-10 7:31 ` Nikita Yushchenko
2017-01-10 11:01 ` Arnd Bergmann
2017-01-10 11:01 ` Arnd Bergmann
2017-01-10 11:01 ` Arnd Bergmann
2017-01-10 11:01 ` Arnd Bergmann
2017-01-10 14:48 ` Christoph Hellwig
2017-01-10 14:48 ` Christoph Hellwig
2017-01-10 14:48 ` Christoph Hellwig
2017-01-10 14:48 ` Christoph Hellwig
2017-01-10 15:02 ` Arnd Bergmann
2017-01-10 15:02 ` Arnd Bergmann
2017-01-10 15:02 ` Arnd Bergmann
2017-01-10 15:02 ` Arnd Bergmann
2017-01-12 10:09 ` Sagi Grimberg
2017-01-12 10:09 ` Sagi Grimberg
2017-01-12 10:09 ` Sagi Grimberg
2017-01-12 10:09 ` Sagi Grimberg
2017-01-12 11:56 ` Arnd Bergmann
2017-01-12 11:56 ` Arnd Bergmann
2017-01-12 11:56 ` Arnd Bergmann
2017-01-12 11:56 ` Arnd Bergmann
2017-01-12 13:07 ` Christoph Hellwig
2017-01-12 13:07 ` Christoph Hellwig
2017-01-12 13:07 ` Christoph Hellwig
2017-01-12 13:07 ` Christoph Hellwig
2017-01-10 10:54 ` Arnd Bergmann
2017-01-10 10:54 ` Arnd Bergmann
2017-01-10 10:54 ` Arnd Bergmann
2017-01-10 10:54 ` Arnd Bergmann
2017-01-10 10:47 ` [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask Arnd Bergmann
2017-01-10 10:47 ` Arnd Bergmann
2017-01-10 10:47 ` Arnd Bergmann
2017-01-10 10:47 ` Arnd Bergmann
2017-01-10 14:44 ` Christoph Hellwig
2017-01-10 14:44 ` Christoph Hellwig
2017-01-10 14:44 ` Christoph Hellwig
2017-01-10 14:44 ` Christoph Hellwig
2017-01-10 15:00 ` Arnd Bergmann
2017-01-10 15:00 ` Arnd Bergmann
2017-01-10 15:00 ` Arnd Bergmann
2017-01-10 15:00 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2103911.qf9H68dkRp@wuerfel \
--to=arnd@arndb.de \
--cc=artemi.ivanov@cogentembedded.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.