Re: [PATCH v3 1/3] clk: samsung: introduce nMUX for MUX clks that can reparented

From: "André Draszik" <andre.draszik@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
	peter.griffin@linaro.org,  krzysztof.kozlowski@linaro.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
	 linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	 willmcvicker@google.com, kernel-team@android.com,
	s.nawrocki@samsung.com,  cw00.choi@samsung.com,
	mturquette@baylibre.com, sboyd@kernel.org,
	 semen.protsenko@linaro.org, linux-clk@vger.kernel.org,
	jaewon02.kim@samsung.com
Subject: Re: [PATCH v3 1/3] clk: samsung: introduce nMUX for MUX clks that can reparented
Date: Thu, 28 Mar 2024 12:44:14 +0000	[thread overview]
Message-ID: <2125e654f89ee8c709a48c8e46956ef7645b9d2d.camel@linaro.org> (raw)
In-Reply-To: <20240328123440.1387823-2-tudor.ambarus@linaro.org>

On Thu, 2024-03-28 at 12:34 +0000, Tudor Ambarus wrote:
> All samsung MUX clocks that are defined with MUX() set the
> CLK_SET_RATE_NO_REPARENT flag in __MUX(), which prevents MUXes to be
> reparented during clk_set_rate().
> 
> Introduce nMUX() for MUX clocks that can be reparented on clock rate
> change. "nMUX" comes from "n-to-1 selector", hopefully emphasising that
> the selector can change on clock rate changes. Ideally MUX/MUX_F()
> should change to not have the CLK_SET_RATE_NO_REPARENT flag set by
> default, and all their users to be updated to add the flag back
> (like in the case of DIV and GATE). But this is a very intrusive change
> and because for now only GS101 allows MUX reparenting on clock rate
> change, stick with nMUX().
> 
> One user of nMUX() will be GS101. GS101 defines MUX clocks that
> are dedicated for each instance of an IP (see MUX USI). The reparenting
> of these MUX clocks will not affect other instances of the same IP or
> different IPs altogether.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>

Reviewed-by: André Draszik <andre.draszik@linaro.org>