All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	peter.griffin@linaro.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	andre.draszik@linaro.org, willmcvicker@google.com,
	kernel-team@android.com, s.nawrocki@samsung.com,
	cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org,
	semen.protsenko@linaro.org, linux-clk@vger.kernel.org,
	jaewon02.kim@samsung.com
Subject: Re: [PATCH v3 0/3] clk: samsung: introduce nMUX to reparent MUX clocks
Date: Mon, 15 Apr 2024 08:13:39 +0100	[thread overview]
Message-ID: <f67ca72f-c0ae-4f2f-a435-b00266914053@linaro.org> (raw)
In-Reply-To: <ab700927-d7b6-44c6-bbe0-8c52e4a0f907@linaro.org>



On 4/13/24 09:47, Krzysztof Kozlowski wrote:
> On 28/03/2024 13:34, Tudor Ambarus wrote:
>> v3:
>> - update first patch:
>>   - remove __nMUX() as it duplicated __MUX() with an exception on flags.
>>   - update commit message
>>   - update comment and say that nMUX() shall be used where MUX reparenting
>>     on clock rate chage is allowed
>> - collect R-b, A-b tags
>>
> 
> Sorry for late response, somehow this end up deep in inbox. You

no worries!

> reference some non existing commits, so I think you do not work on
> mainline trees.

Ah, the horror, you're right, I messed up the fixes reference in commit
2. It's because I started working on this before that patch got
integrated. Would be good to extend checkpatch to catch such situations.

> 
> Also Fixes must come before other patches, so probably first patch
> should be squashed with second. Otherwise second patch is not a complete
> fix.

I don't mind squashing them. I noticed a tag that might help in this
situations: "Depends-on:". But I guess we can't use that in the same
patch set as when the maintainer applies the dependency and adds its
S-o-b tag, it will modify the sha1 of the commit. Will squash them.

Cheers,
ta

WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	peter.griffin@linaro.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	andre.draszik@linaro.org, willmcvicker@google.com,
	kernel-team@android.com, s.nawrocki@samsung.com,
	cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org,
	semen.protsenko@linaro.org, linux-clk@vger.kernel.org,
	jaewon02.kim@samsung.com
Subject: Re: [PATCH v3 0/3] clk: samsung: introduce nMUX to reparent MUX clocks
Date: Mon, 15 Apr 2024 08:13:39 +0100	[thread overview]
Message-ID: <f67ca72f-c0ae-4f2f-a435-b00266914053@linaro.org> (raw)
In-Reply-To: <ab700927-d7b6-44c6-bbe0-8c52e4a0f907@linaro.org>



On 4/13/24 09:47, Krzysztof Kozlowski wrote:
> On 28/03/2024 13:34, Tudor Ambarus wrote:
>> v3:
>> - update first patch:
>>   - remove __nMUX() as it duplicated __MUX() with an exception on flags.
>>   - update commit message
>>   - update comment and say that nMUX() shall be used where MUX reparenting
>>     on clock rate chage is allowed
>> - collect R-b, A-b tags
>>
> 
> Sorry for late response, somehow this end up deep in inbox. You

no worries!

> reference some non existing commits, so I think you do not work on
> mainline trees.

Ah, the horror, you're right, I messed up the fixes reference in commit
2. It's because I started working on this before that patch got
integrated. Would be good to extend checkpatch to catch such situations.

> 
> Also Fixes must come before other patches, so probably first patch
> should be squashed with second. Otherwise second patch is not a complete
> fix.

I don't mind squashing them. I noticed a tag that might help in this
situations: "Depends-on:". But I guess we can't use that in the same
patch set as when the maintainer applies the dependency and adds its
S-o-b tag, it will modify the sha1 of the commit. Will squash them.

Cheers,
ta

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-04-15  7:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 12:34 [PATCH v3 0/3] clk: samsung: introduce nMUX to reparent MUX clocks Tudor Ambarus
2024-03-28 12:34 ` Tudor Ambarus
2024-03-28 12:34 ` [PATCH v3 1/3] clk: samsung: introduce nMUX for MUX clks that can reparented Tudor Ambarus
2024-03-28 12:34   ` Tudor Ambarus
2024-03-28 12:44   ` André Draszik
2024-03-28 12:44     ` André Draszik
2024-03-28 12:34 ` [PATCH v3 2/3] clk: samsung: gs101: propagate PERIC1 USI SPI clock rate Tudor Ambarus
2024-03-28 12:34   ` Tudor Ambarus
2024-03-28 12:34 ` [PATCH v3 3/3] clk: samsung: gs101: propagate PERIC0 " Tudor Ambarus
2024-03-28 12:34   ` Tudor Ambarus
2024-04-13  8:47 ` [PATCH v3 0/3] clk: samsung: introduce nMUX to reparent MUX clocks Krzysztof Kozlowski
2024-04-13  8:47   ` Krzysztof Kozlowski
2024-04-15  7:13   ` Tudor Ambarus [this message]
2024-04-15  7:13     ` Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f67ca72f-c0ae-4f2f-a435-b00266914053@linaro.org \
    --to=tudor.ambarus@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=cw00.choi@samsung.com \
    --cc=jaewon02.kim@samsung.com \
    --cc=kernel-team@android.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=peter.griffin@linaro.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.