From: Cupertino Miranda <Cupertino.Miranda@synopsys.com>
To: Richard Henderson <richard.henderson@linaro.org>,
"cupertinomiranda@gmail.com" <cupertinomiranda@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Claudiu Zissulescu <claziss@gmail.com>,
Shahab Vahedi <Shahab.Vahedi@synopsys.com>
Subject: Re: [PATCH 03/15] arc: Opcode definitions table
Date: Fri, 15 Jan 2021 17:11:16 +0000 [thread overview]
Message-ID: <214ddc83-cf6e-20e7-0a86-92af851809e4@synopsys.com> (raw)
In-Reply-To: <7336e0b3-13e8-a3d7-46fb-a4ea942c5c16@linaro.org>
Hi Richard,
Sorry to take so long to get through the changes after your review.
I am still going through the improving process and waiting for some
internal company approval to publish the generator of the TCG
instruction definitions, as we have discussed.
Nevertheless, there are some questions. I will address them near the
proper places and through the different patches.
Once again, thank you very much for your reviews. ;-)
On 12/1/20 8:22 PM, Richard Henderson wrote:
> On 11/11/20 10:17 AM, cupertinomiranda@gmail.com wrote:
>> From: Claudiu Zissulescu <claziss@synopsys.com>
>>
>> Signed-off-by: Claudiu Zissulescu <claziss@synopsys.com>
>> ---
>> target/arc/opcodes.def | 19976 +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 19976 insertions(+)
>> create mode 100644 target/arc/opcodes.def
>
> OMG. 20k lines.
>
> I assume this is gnu binutils opcodes/arc-tbl.h?
>
> You are the contributor there, so a re-license is fine. It would be good to
> document the upstream location and revision, against some future re-sync.
>
> That said, this format is less than ideal:
>
>> +/* abs<.f> b,c 00100bbb00101111FBBBCCCCCC001001. */
>> +{ "abs", 0x202F0009, 0xF8FF003F, ARC_OPCODE_ARC600 | ARC_OPCODE_ARC700 | ARC_OPCODE_ARCv2EM | ARC_OPCODE_ARCv2HS, ARITH, NONE, { OPERAND_RB, OPERAND_RC }, { C_F }},
>
> You've got the same information in two places
> (00100bbb00101111FBBBCCCCCC001001) vs (0x202F0009, 0xF8FF003F, OPERAND_*).
> Moreover, "abs" as a string is not especially useful, and means that you have
> to deal with strings in the translator instead of C symbols or enumerators.
>
> It would be relatively easy to generate a decodetree file from this input,
> which would simplify the translator.
>
> At a bare minimum strip the quotes and wrap in a macro so that you can (1)
> define an enumerator and (2) put the entries into an array indexed by the
> enumerator.
>
As you know, we reused the code from binutils to implement the decoder.
In that sense, we kindly request to allow us to do it through binutils
development flow later on. We will change the tables in binutils
and those changes will also be mirrored to QEMU.
Is this Ok ?
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Cupertino Miranda <Cupertino.Miranda@synopsys.com>
To: Richard Henderson <richard.henderson@linaro.org>,
"cupertinomiranda@gmail.com" <cupertinomiranda@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Claudiu Zissulescu <claziss@gmail.com>,
Shahab Vahedi <Shahab.Vahedi@synopsys.com>
Subject: Re: [PATCH 03/15] arc: Opcode definitions table
Date: Fri, 15 Jan 2021 17:11:16 +0000 [thread overview]
Message-ID: <214ddc83-cf6e-20e7-0a86-92af851809e4@synopsys.com> (raw)
In-Reply-To: <7336e0b3-13e8-a3d7-46fb-a4ea942c5c16@linaro.org>
Hi Richard,
Sorry to take so long to get through the changes after your review.
I am still going through the improving process and waiting for some
internal company approval to publish the generator of the TCG
instruction definitions, as we have discussed.
Nevertheless, there are some questions. I will address them near the
proper places and through the different patches.
Once again, thank you very much for your reviews. ;-)
On 12/1/20 8:22 PM, Richard Henderson wrote:
> On 11/11/20 10:17 AM, cupertinomiranda@gmail.com wrote:
>> From: Claudiu Zissulescu <claziss@synopsys.com>
>>
>> Signed-off-by: Claudiu Zissulescu <claziss@synopsys.com>
>> ---
>> target/arc/opcodes.def | 19976 +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 19976 insertions(+)
>> create mode 100644 target/arc/opcodes.def
>
> OMG. 20k lines.
>
> I assume this is gnu binutils opcodes/arc-tbl.h?
>
> You are the contributor there, so a re-license is fine. It would be good to
> document the upstream location and revision, against some future re-sync.
>
> That said, this format is less than ideal:
>
>> +/* abs<.f> b,c 00100bbb00101111FBBBCCCCCC001001. */
>> +{ "abs", 0x202F0009, 0xF8FF003F, ARC_OPCODE_ARC600 | ARC_OPCODE_ARC700 | ARC_OPCODE_ARCv2EM | ARC_OPCODE_ARCv2HS, ARITH, NONE, { OPERAND_RB, OPERAND_RC }, { C_F }},
>
> You've got the same information in two places
> (00100bbb00101111FBBBCCCCCC001001) vs (0x202F0009, 0xF8FF003F, OPERAND_*).
> Moreover, "abs" as a string is not especially useful, and means that you have
> to deal with strings in the translator instead of C symbols or enumerators.
>
> It would be relatively easy to generate a decodetree file from this input,
> which would simplify the translator.
>
> At a bare minimum strip the quotes and wrap in a macro so that you can (1)
> define an enumerator and (2) put the entries into an array indexed by the
> enumerator.
>
As you know, we reused the code from binutils to implement the decoder.
In that sense, we kindly request to allow us to do it through binutils
development flow later on. We will change the tables in binutils
and those changes will also be mirrored to QEMU.
Is this Ok ?
next prev parent reply other threads:[~2021-01-15 17:11 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 16:17 [PATCH 00/15] *** ARC port for review *** cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 01/15] arc: Add initial core cpu files cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-12-01 19:06 ` Richard Henderson
2020-12-01 19:06 ` Richard Henderson
2020-11-11 16:17 ` [PATCH 02/15] arc: Decoder code cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 03/15] arc: Opcode definitions table cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-12-01 20:22 ` Richard Henderson
2020-12-01 20:22 ` Richard Henderson
2021-01-15 17:11 ` Cupertino Miranda [this message]
2021-01-15 17:11 ` Cupertino Miranda
2021-01-15 19:52 ` Richard Henderson
2021-01-15 19:52 ` Richard Henderson
2020-11-11 16:17 ` [PATCH 04/15] arc: TCG and decoder glue code and helpers cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-12-01 21:35 ` Richard Henderson
2020-12-01 21:35 ` Richard Henderson
2021-01-15 17:11 ` Cupertino Miranda
2021-01-15 17:11 ` Cupertino Miranda
2021-01-15 20:31 ` Richard Henderson
2021-01-15 20:31 ` Richard Henderson
2021-01-15 21:48 ` Cupertino Miranda
2021-01-15 21:48 ` Cupertino Miranda
2021-01-15 21:53 ` Richard Henderson
2021-01-15 21:53 ` Richard Henderson
2021-01-15 22:06 ` Cupertino Miranda
2021-01-15 22:06 ` Cupertino Miranda
2021-01-15 21:28 ` Shahab Vahedi
2021-01-15 21:28 ` Shahab Vahedi
2021-01-15 21:51 ` Richard Henderson
2021-01-15 21:51 ` Richard Henderson
2020-11-11 16:17 ` [PATCH 05/15] arc: TCG instruction generator and hand-definitions cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-12-01 22:16 ` Richard Henderson
2020-12-01 22:16 ` Richard Henderson
2021-01-15 17:11 ` Cupertino Miranda
2021-01-15 17:11 ` Cupertino Miranda
2021-01-15 20:17 ` Richard Henderson
2021-01-15 20:17 ` Richard Henderson
2021-01-15 21:38 ` Cupertino Miranda
2021-01-15 21:38 ` Cupertino Miranda
2020-11-11 16:17 ` [PATCH 06/15] arc: TCG instruction definitions cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-12-01 23:09 ` Richard Henderson
2020-12-01 23:09 ` Richard Henderson
2020-12-02 12:55 ` Cupertino Miranda
2020-12-02 12:55 ` Cupertino Miranda
2020-12-03 16:07 ` Richard Henderson
2020-12-03 16:07 ` Richard Henderson
2020-12-03 16:54 ` Cupertino Miranda
2020-12-03 16:54 ` Cupertino Miranda
2020-12-03 19:34 ` Richard Henderson
2020-12-03 19:34 ` Richard Henderson
2020-12-03 19:51 ` Cupertino Miranda
2020-12-03 19:51 ` Cupertino Miranda
2021-01-15 17:11 ` Cupertino Miranda
2021-01-15 17:11 ` Cupertino Miranda
2020-11-11 16:17 ` [PATCH 07/15] arc: Add BCR and AUX registers implementation cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 08/15] arc: Add IRQ and timer subsystem support cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 09/15] arc: Add memory management unit (MMU) support cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 10/15] arc: Add memory protection unit (MPU) support cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 11/15] arc: Add gdbstub and XML for debugging support cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 12/15] arc: Add Synopsys ARC emulation boards cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 13/15] arc: Add support for ARCv2 cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 14/15] tests/tcg: ARC: Add TCG instruction definition tests cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:17 ` [PATCH 15/15] tests/acceptance: ARC: Add linux boot testing cupertinomiranda
2020-11-11 16:17 ` cupertinomiranda
2020-11-11 16:43 ` [PATCH 00/15] *** ARC port for review *** no-reply
2020-11-11 16:43 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=214ddc83-cf6e-20e7-0a86-92af851809e4@synopsys.com \
--to=cupertino.miranda@synopsys.com \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Shahab.Vahedi@synopsys.com \
--cc=claziss@gmail.com \
--cc=cupertinomiranda@gmail.com \
--cc=linux-snps-arc@lists.infradead.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shahab.vahedi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.