All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Loc Ho <lho-qTEPVZfXA3Y@public.gmane.org>
Cc: dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
	bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
	mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	patches-qTEPVZfXA3Y@public.gmane.org
Subject: Re: [PATCH v8 0/4] edac: Add APM X-Gene SoC memory controller EDAC driver
Date: Wed, 06 May 2015 10:52:26 +0200	[thread overview]
Message-ID: <2150970.xGYLhDU9BR@wuerfel> (raw)
In-Reply-To: <1430884947-16787-1-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>

On Tuesday 05 May 2015 22:02:22 Loc Ho wrote:
> 
> v8:
> * Change ASM_EDAC_H to __ASM_EDAC_H in file edac.h
> * Add WARN_ONCE in stub function atomic_scrub
> * Update DTS binding documentation (with only memory controller node)
> * Temporary remove L1/L2, L3, and SoC driver code and update memory driver
>   code accordingly
> 
> 

I don't see how this is helping. You still use a syscon reference for the
pcp node after I told you not to, and you are completely leaving out the
other nodes, which makes it impossible to tell what your plan is for those.

Please come up with a plan that makes it possible to have proper support
for all the devices in the future. Leaving out bits because you know that
adding them later will be hard is not a good solution: if you screw up
the design now, adding them later will be even harder.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 0/4] edac: Add APM X-Gene SoC memory controller EDAC driver
Date: Wed, 06 May 2015 10:52:26 +0200	[thread overview]
Message-ID: <2150970.xGYLhDU9BR@wuerfel> (raw)
In-Reply-To: <1430884947-16787-1-git-send-email-lho@apm.com>

On Tuesday 05 May 2015 22:02:22 Loc Ho wrote:
> 
> v8:
> * Change ASM_EDAC_H to __ASM_EDAC_H in file edac.h
> * Add WARN_ONCE in stub function atomic_scrub
> * Update DTS binding documentation (with only memory controller node)
> * Temporary remove L1/L2, L3, and SoC driver code and update memory driver
>   code accordingly
> 
> 

I don't see how this is helping. You still use a syscon reference for the
pcp node after I told you not to, and you are completely leaving out the
other nodes, which makes it impossible to tell what your plan is for those.

Please come up with a plan that makes it possible to have proper support
for all the devices in the future. Leaving out bits because you know that
adding them later will be hard is not a good solution: if you screw up
the design now, adding them later will be even harder.

	Arnd

  parent reply	other threads:[~2015-05-06  8:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  4:02 [PATCH v8 0/4] edac: Add APM X-Gene SoC memory controller EDAC driver Loc Ho
2015-05-06  4:02 ` Loc Ho
     [not found] ` <1430884947-16787-1-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-06  4:02   ` [PATCH v8 1/5] arm64: Enable EDAC on ARM64 Loc Ho
2015-05-06  4:02     ` Loc Ho
     [not found]     ` <1430884947-16787-2-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-06  4:02       ` [PATCH v8 2/5] MAINTAINERS: Add entry for APM X-Gene SoC EDAC driver Loc Ho
2015-05-06  4:02         ` Loc Ho
     [not found]         ` <1430884947-16787-3-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-06  4:02           ` [PATCH v8 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Loc Ho
2015-05-06  4:02             ` Loc Ho
     [not found]             ` <1430884947-16787-4-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-06  4:02               ` [PATCH v8 4/5] edac: Add APM X-Gene SoC memory controller EDAC driver Loc Ho
2015-05-06  4:02                 ` Loc Ho
     [not found]                 ` <1430884947-16787-5-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org>
2015-05-06  4:02                   ` [PATCH v8 5/5] arm64: Add APM X-Gene SoC memory controller EDAC DTS entries Loc Ho
2015-05-06  4:02                     ` Loc Ho
2015-05-06  4:10     ` [PATCH v8 1/5] arm64: Enable EDAC on ARM64 Jon Masters
2015-05-06  4:10       ` Jon Masters
2015-05-06  8:41   ` [PATCH v8 0/4] edac: Add APM X-Gene SoC memory controller EDAC driver Borislav Petkov
2015-05-06  8:41     ` Borislav Petkov
2015-05-06 17:00     ` Loc Ho
     [not found]       ` <CAPw-ZT=LepJr2Smjy81yhcTANdMRw99x1vR9rMoYsnHW_P3HPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-06 17:12         ` Borislav Petkov
2015-05-06 17:12           ` Borislav Petkov
     [not found]           ` <20150506171242.GG22949-fF5Pk5pvG8Y@public.gmane.org>
2015-05-06 18:17             ` Loc Ho
2015-05-06 18:17               ` Loc Ho
2015-05-06  8:52   ` Arnd Bergmann [this message]
2015-05-06  8:52     ` Arnd Bergmann
2015-05-06 18:12     ` Loc Ho
2015-05-06 18:12       ` Loc Ho
     [not found]       ` <CAPw-ZTkuZWNM9D_wJRfQq009KeL1coyYKXhqhWV+FWW6C=xRiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-06 18:29         ` Borislav Petkov
2015-05-06 18:29           ` Borislav Petkov
     [not found]           ` <20150506182900.GI22949-fF5Pk5pvG8Y@public.gmane.org>
2015-05-06 18:43             ` Loc Ho
2015-05-06 18:43               ` Loc Ho
     [not found]               ` <CAPw-ZTmJ8C3KmujZJN1z21S3LFQ-TRouUeAjN0Y02HOTKAG1_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-06 19:50                 ` Arnd Bergmann
2015-05-06 19:50                   ` Arnd Bergmann
2015-05-11 22:29                   ` Loc Ho
2015-05-11 22:29                     ` Loc Ho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2150970.xGYLhDU9BR@wuerfel \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=lho-qTEPVZfXA3Y@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    --cc=patches-qTEPVZfXA3Y@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.