* [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 @ 2022-11-24 17:59 rsbecker 2022-11-24 18:40 ` Ævar Arnfjörð Bjarmason 0 siblings, 1 reply; 6+ messages in thread From: rsbecker @ 2022-11-24 17:59 UTC (permalink / raw) To: git While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a condition where: <snip> + test_when_finished rm trace.perf actual + test_config_global trace2.perfBrief 1 + pwd + test_config_global trace2.perfTarget /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash directory.t0211-trace2-perf/trace.perf + test-tool trace2 101timer 5 10 3 fatal: failed to create thread[0] was encountered, causing the test to fail. Pointers on resolving this would be helpful. Thanks, Randall -- Brief whoami: NonStop&UNIX developer since approximately UNIX(421664400) NonStop(211288444200000000) -- In real life, I talk too much. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 2022-11-24 17:59 [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 rsbecker @ 2022-11-24 18:40 ` Ævar Arnfjörð Bjarmason 2022-11-24 19:18 ` rsbecker 2022-11-24 21:51 ` Ævar Arnfjörð Bjarmason 0 siblings, 2 replies; 6+ messages in thread From: Ævar Arnfjörð Bjarmason @ 2022-11-24 18:40 UTC (permalink / raw) To: rsbecker; +Cc: git, Jeff Hostetler [CC-ing Jeff, this is from the "stopwatch timers" topic] On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote: > While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a condition > where: Don't you mean t0211-trace2-perf.sh? > <snip> > + test_when_finished rm trace.perf actual > + test_config_global trace2.perfBrief 1 > + pwd > + test_config_global trace2.perfTarget > /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash > directory.t0211-trace2-perf/trace.perf > + test-tool trace2 101timer 5 10 3 > fatal: failed to create thread[0] > > was encountered, causing the test to fail. Pointers on resolving this would > be helpful. Apparently we really could use a NO_PTHREADS=Y CI setup, because that's all that's needed to reproduce this on linux & elsewhere. Running the test with that: + test-tool trace2 101timer 5 10 3 fatal: failed to create thread[0] error: last command exited with $?=128 For that all that's needed is this: diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh index 0b3436e8cac..cfba6861322 100755 --- a/t/t0211-trace2-perf.sh +++ b/t/t0211-trace2-perf.sh @@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' ' have_timer_event "main" "timer" "test" "test1" 5 actual ' -test_expect_success 'stopwatch timer test/test2' ' +test_expect_success PTHREADS 'stopwatch timer test/test2' ' test_when_finished "rm trace.perf actual" && test_config_global trace2.perfBrief 1 && test_config_global trace2.perfTarget "$(pwd)/trace.perf" && @@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' ' have_counter_event "main" "counter" "test" "test1" 15 actual ' -test_expect_success 'global counter test/test2' ' +test_expect_success PTHREADS 'global counter test/test2' ' test_when_finished "rm trace.perf actual" && test_config_global trace2.perfBrief 1 && test_config_global trace2.perfTarget "$(pwd)/trace.perf" && I think that's the correct fix here, and it should go into rc1. ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 2022-11-24 18:40 ` Ævar Arnfjörð Bjarmason @ 2022-11-24 19:18 ` rsbecker 2022-11-24 21:35 ` Ævar Arnfjörð Bjarmason 2022-11-24 21:51 ` Ævar Arnfjörð Bjarmason 1 sibling, 1 reply; 6+ messages in thread From: rsbecker @ 2022-11-24 19:18 UTC (permalink / raw) To: 'Ævar Arnfjörð Bjarmason' Cc: git, 'Jeff Hostetler' On November 24, 2022 1:41 PM, Ævar Arnfjörð Bjarmason wrote: >[CC-ing Jeff, this is from the "stopwatch timers" topic] > >On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote: > >> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a >> condition >> where: > >Don't you mean t0211-trace2-perf.sh? > >> <snip> >> + test_when_finished rm trace.perf actual test_config_global >> + trace2.perfBrief 1 pwd test_config_global trace2.perfTarget >> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash >> directory.t0211-trace2-perf/trace.perf >> + test-tool trace2 101timer 5 10 3 >> fatal: failed to create thread[0] >> >> was encountered, causing the test to fail. Pointers on resolving this >> would be helpful. > >Apparently we really could use a NO_PTHREADS=Y CI setup, because that's all >that's needed to reproduce this on linux & elsewhere. Running the test with that: > > + test-tool trace2 101timer 5 10 3 > fatal: failed to create thread[0] > error: last command exited with $?=128 > >For that all that's needed is this: > > diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh > index 0b3436e8cac..cfba6861322 100755 > --- a/t/t0211-trace2-perf.sh > +++ b/t/t0211-trace2-perf.sh > @@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' ' > have_timer_event "main" "timer" "test" "test1" 5 actual > ' > > -test_expect_success 'stopwatch timer test/test2' ' > +test_expect_success PTHREADS 'stopwatch timer test/test2' ' > test_when_finished "rm trace.perf actual" && > test_config_global trace2.perfBrief 1 && > test_config_global trace2.perfTarget "$(pwd)/trace.perf" && > @@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' ' > have_counter_event "main" "counter" "test" "test1" 15 actual > ' > > -test_expect_success 'global counter test/test2' ' > +test_expect_success PTHREADS 'global counter test/test2' ' > test_when_finished "rm trace.perf actual" && > test_config_global trace2.perfBrief 1 && > test_config_global trace2.perfTarget "$(pwd)/trace.perf" && > >I think that's the correct fix here, and it should go into rc1. I assume we do not have to modify the platform's entry in config.mak.uname, which already has NO_PTHREADS=UnfortunatelyYes. Thanks, Randall ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 2022-11-24 19:18 ` rsbecker @ 2022-11-24 21:35 ` Ævar Arnfjörð Bjarmason 0 siblings, 0 replies; 6+ messages in thread From: Ævar Arnfjörð Bjarmason @ 2022-11-24 21:35 UTC (permalink / raw) To: rsbecker; +Cc: git, 'Jeff Hostetler' On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote: > On November 24, 2022 1:41 PM, Ævar Arnfjörð Bjarmason wrote: >>[CC-ing Jeff, this is from the "stopwatch timers" topic] >> >>On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote: >> >>> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a >>> condition >>> where: >> >>Don't you mean t0211-trace2-perf.sh? >> >>> <snip> >>> + test_when_finished rm trace.perf actual test_config_global >>> + trace2.perfBrief 1 pwd test_config_global trace2.perfTarget >>> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash >>> directory.t0211-trace2-perf/trace.perf >>> + test-tool trace2 101timer 5 10 3 >>> fatal: failed to create thread[0] >>> >>> was encountered, causing the test to fail. Pointers on resolving this >>> would be helpful. >> >>Apparently we really could use a NO_PTHREADS=Y CI setup, because that's all >>that's needed to reproduce this on linux & elsewhere. Running the test with that: >> >> + test-tool trace2 101timer 5 10 3 >> fatal: failed to create thread[0] >> error: last command exited with $?=128 >> >>For that all that's needed is this: >> >> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh >> index 0b3436e8cac..cfba6861322 100755 >> --- a/t/t0211-trace2-perf.sh >> +++ b/t/t0211-trace2-perf.sh >> @@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' ' >> have_timer_event "main" "timer" "test" "test1" 5 actual >> ' >> >> -test_expect_success 'stopwatch timer test/test2' ' >> +test_expect_success PTHREADS 'stopwatch timer test/test2' ' >> test_when_finished "rm trace.perf actual" && >> test_config_global trace2.perfBrief 1 && >> test_config_global trace2.perfTarget "$(pwd)/trace.perf" && >> @@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' ' >> have_counter_event "main" "counter" "test" "test1" 15 actual >> ' >> >> -test_expect_success 'global counter test/test2' ' >> +test_expect_success PTHREADS 'global counter test/test2' ' >> test_when_finished "rm trace.perf actual" && >> test_config_global trace2.perfBrief 1 && >> test_config_global trace2.perfTarget "$(pwd)/trace.perf" && >> >>I think that's the correct fix here, and it should go into rc1. > > I assume we do not have to modify the platform's entry in config.mak.uname, which already has NO_PTHREADS=UnfortunatelyYes. Yes, that's the part where you declare that the platform doesn't have threading, this is where the tests are then guarded using that setting. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 2022-11-24 18:40 ` Ævar Arnfjörð Bjarmason 2022-11-24 19:18 ` rsbecker @ 2022-11-24 21:51 ` Ævar Arnfjörð Bjarmason 2022-11-24 22:22 ` rsbecker 1 sibling, 1 reply; 6+ messages in thread From: Ævar Arnfjörð Bjarmason @ 2022-11-24 21:51 UTC (permalink / raw) To: rsbecker; +Cc: git, Jeff Hostetler On Thu, Nov 24 2022, Ævar Arnfjörð Bjarmason wrote: > [CC-ing Jeff, this is from the "stopwatch timers" topic] > > On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote: > >> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a condition >> where: > > Don't you mean t0211-trace2-perf.sh? > >> <snip> >> + test_when_finished rm trace.perf actual >> + test_config_global trace2.perfBrief 1 >> + pwd >> + test_config_global trace2.perfTarget >> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash >> directory.t0211-trace2-perf/trace.perf >> + test-tool trace2 101timer 5 10 3 >> fatal: failed to create thread[0] >> >> was encountered, causing the test to fail. Pointers on resolving this would >> be helpful. > > Apparently we really could use a NO_PTHREADS=Y CI setup, because that's > all that's needed to reproduce this on linux & elsewhere. Running the > test with that: > > + test-tool trace2 101timer 5 10 3 > fatal: failed to create thread[0] > error: last command exited with $?=128 > > For that all that's needed is this: > > diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh > index 0b3436e8cac..cfba6861322 100755 > --- a/t/t0211-trace2-perf.sh > +++ b/t/t0211-trace2-perf.sh > @@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' ' > have_timer_event "main" "timer" "test" "test1" 5 actual > ' > > -test_expect_success 'stopwatch timer test/test2' ' > +test_expect_success PTHREADS 'stopwatch timer test/test2' ' > test_when_finished "rm trace.perf actual" && > test_config_global trace2.perfBrief 1 && > test_config_global trace2.perfTarget "$(pwd)/trace.perf" && > @@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' ' > have_counter_event "main" "counter" "test" "test1" 15 actual > ' > > -test_expect_success 'global counter test/test2' ' > +test_expect_success PTHREADS 'global counter test/test2' ' > test_when_finished "rm trace.perf actual" && > test_config_global trace2.perfBrief 1 && > test_config_global trace2.perfTarget "$(pwd)/trace.perf" && > > I think that's the correct fix here, and it should go into rc1. I submitted a fix at https://lore.kernel.org/git/patch-1.1-f7f21c94a6c-20221124T214813Z-avarab@gmail.com/; but I see that since your message-id's contain "$" I got the In-Reply-To wrong, sorry :) ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 2022-11-24 21:51 ` Ævar Arnfjörð Bjarmason @ 2022-11-24 22:22 ` rsbecker 0 siblings, 0 replies; 6+ messages in thread From: rsbecker @ 2022-11-24 22:22 UTC (permalink / raw) To: 'Ævar Arnfjörð Bjarmason' Cc: git, 'Jeff Hostetler' On November 24, 2022 4:51 PM, Ævar Arnfjörð Bjarmason wrote: >On Thu, Nov 24 2022, Ævar Arnfjörð Bjarmason wrote: > >> [CC-ing Jeff, this is from the "stopwatch timers" topic] >> >> On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote: >> >>> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a >>> condition >>> where: >> >> Don't you mean t0211-trace2-perf.sh? >> >>> <snip> >>> + test_when_finished rm trace.perf actual test_config_global >>> + trace2.perfBrief 1 pwd test_config_global trace2.perfTarget >>> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash >>> directory.t0211-trace2-perf/trace.perf >>> + test-tool trace2 101timer 5 10 3 >>> fatal: failed to create thread[0] >>> >>> was encountered, causing the test to fail. Pointers on resolving this >>> would be helpful. >> >> Apparently we really could use a NO_PTHREADS=Y CI setup, because >> that's all that's needed to reproduce this on linux & elsewhere. >> Running the test with that: >> >> + test-tool trace2 101timer 5 10 3 >> fatal: failed to create thread[0] >> error: last command exited with $?=128 >> >> For that all that's needed is this: >> >> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh >> index 0b3436e8cac..cfba6861322 100755 >> --- a/t/t0211-trace2-perf.sh >> +++ b/t/t0211-trace2-perf.sh >> @@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' ' >> have_timer_event "main" "timer" "test" "test1" 5 actual >> ' >> >> -test_expect_success 'stopwatch timer test/test2' ' >> +test_expect_success PTHREADS 'stopwatch timer test/test2' ' >> test_when_finished "rm trace.perf actual" && >> test_config_global trace2.perfBrief 1 && >> test_config_global trace2.perfTarget "$(pwd)/trace.perf" && >> @@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' ' >> have_counter_event "main" "counter" "test" "test1" 15 actual >> ' >> >> -test_expect_success 'global counter test/test2' ' >> +test_expect_success PTHREADS 'global counter test/test2' ' >> test_when_finished "rm trace.perf actual" && >> test_config_global trace2.perfBrief 1 && >> test_config_global trace2.perfTarget "$(pwd)/trace.perf" && >> >> I think that's the correct fix here, and it should go into rc1. > >I submitted a fix at >https://lore.kernel.org/git/patch-1.1-f7f21c94a6c-20221124T214813Z- >avarab@gmail.com/; >but I see that since your message-id's contain "$" I got the In-Reply-To wrong, >sorry :) Thanks ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-24 22:22 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-24 17:59 [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0 rsbecker 2022-11-24 18:40 ` Ævar Arnfjörð Bjarmason 2022-11-24 19:18 ` rsbecker 2022-11-24 21:35 ` Ævar Arnfjörð Bjarmason 2022-11-24 21:51 ` Ævar Arnfjörð Bjarmason 2022-11-24 22:22 ` rsbecker
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.