All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vokáč Michal" <Michal.Vokac@ysoft.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity
Date: Tue, 9 Oct 2018 13:18:24 +0000	[thread overview]
Message-ID: <221a185c-19fc-cc89-49b1-aa77fb1f0e41@ysoft.com> (raw)
In-Reply-To: <CAOMZO5DdV9Sm9z6wX8e4LTvbokjnOMqtgOJQOvVvysVvzaBKGw@mail.gmail.com>

On 9.10.2018 14:36, Fabio Estevam wrote:
> Hi Michal,
> 
> On Tue, Oct 9, 2018 at 5:30 AM Vokáč Michal <Michal.Vokac@ysoft.com> wrote:
> 
>> Sorry for the inconvenience :( Lesson learned..
>>
>> So in other words (no offense): broken drivers need to stay broken because
>> users may already get used to the broken behavior?
> 
> In order to keep the old dtb's working you could introduce a new
> property (like reset-gpio-active-low, for example).
> 
> Then the driver behavior can be made untouched for the old dtb's and
> only new dtb's with this new property would have the correct GPIO
> reset behavior.

Thank you very much Fabio!
I saw these xxx-active-low/high properties in many device tree
sources wondering why the heck people use them when they could
use GPIO_ACTIVE_LOW/HIGH. And this is the explanation.

And I feel like an idiot once again: git grep -l "reset-active-low"
first hit is:

  Documentation/devicetree/bindings/display/ssd1307fb.txt

Oooops.
The weird thing is that usage of reset-active-low is documented
in the example but it is not implemented.

So the patch no.2 should be reverted and patch no.3 not applied at all.

I will prepare a new patch utilizing the reset-active-low property.

Again, sorry for the troubles and thank you for your comments.
Michal

WARNING: multiple messages have this Message-ID (diff)
From: "Vokáč Michal" <Michal.Vokac@ysoft.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity
Date: Tue, 09 Oct 2018 13:18:24 +0000	[thread overview]
Message-ID: <221a185c-19fc-cc89-49b1-aa77fb1f0e41@ysoft.com> (raw)
In-Reply-To: <CAOMZO5DdV9Sm9z6wX8e4LTvbokjnOMqtgOJQOvVvysVvzaBKGw@mail.gmail.com>

T24gOS4xMC4yMDE4IDE0OjM2LCBGYWJpbyBFc3RldmFtIHdyb3RlOg0KPiBIaSBNaWNoYWwsDQo+
IA0KPiBPbiBUdWUsIE9jdCA5LCAyMDE4IGF0IDU6MzAgQU0gVm9rw6HEjSBNaWNoYWwgPE1pY2hh
bC5Wb2thY0B5c29mdC5jb20+IHdyb3RlOg0KPiANCj4+IFNvcnJ5IGZvciB0aGUgaW5jb252ZW5p
ZW5jZSA6KCBMZXNzb24gbGVhcm5lZC4uDQo+Pg0KPj4gU28gaW4gb3RoZXIgd29yZHMgKG5vIG9m
ZmVuc2UpOiBicm9rZW4gZHJpdmVycyBuZWVkIHRvIHN0YXkgYnJva2VuIGJlY2F1c2UNCj4+IHVz
ZXJzIG1heSBhbHJlYWR5IGdldCB1c2VkIHRvIHRoZSBicm9rZW4gYmVoYXZpb3I/DQo+IA0KPiBJ
biBvcmRlciB0byBrZWVwIHRoZSBvbGQgZHRiJ3Mgd29ya2luZyB5b3UgY291bGQgaW50cm9kdWNl
IGEgbmV3DQo+IHByb3BlcnR5IChsaWtlIHJlc2V0LWdwaW8tYWN0aXZlLWxvdywgZm9yIGV4YW1w
bGUpLg0KPiANCj4gVGhlbiB0aGUgZHJpdmVyIGJlaGF2aW9yIGNhbiBiZSBtYWRlIHVudG91Y2hl
ZCBmb3IgdGhlIG9sZCBkdGIncyBhbmQNCj4gb25seSBuZXcgZHRiJ3Mgd2l0aCB0aGlzIG5ldyBw
cm9wZXJ0eSB3b3VsZCBoYXZlIHRoZSBjb3JyZWN0IEdQSU8NCj4gcmVzZXQgYmVoYXZpb3IuDQoN
ClRoYW5rIHlvdSB2ZXJ5IG11Y2ggRmFiaW8hDQpJIHNhdyB0aGVzZSB4eHgtYWN0aXZlLWxvdy9o
aWdoIHByb3BlcnRpZXMgaW4gbWFueSBkZXZpY2UgdHJlZQ0Kc291cmNlcyB3b25kZXJpbmcgd2h5
IHRoZSBoZWNrIHBlb3BsZSB1c2UgdGhlbSB3aGVuIHRoZXkgY291bGQNCnVzZSBHUElPX0FDVElW
RV9MT1cvSElHSC4gQW5kIHRoaXMgaXMgdGhlIGV4cGxhbmF0aW9uLg0KDQpBbmQgSSBmZWVsIGxp
a2UgYW4gaWRpb3Qgb25jZSBhZ2FpbjogZ2l0IGdyZXAgLWwgInJlc2V0LWFjdGl2ZS1sb3ciDQpm
aXJzdCBoaXQgaXM6DQoNCiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3Bs
YXkvc3NkMTMwN2ZiLnR4dA0KDQpPb29vcHMuDQpUaGUgd2VpcmQgdGhpbmcgaXMgdGhhdCB1c2Fn
ZSBvZiByZXNldC1hY3RpdmUtbG93IGlzIGRvY3VtZW50ZWQNCmluIHRoZSBleGFtcGxlIGJ1dCBp
dCBpcyBub3QgaW1wbGVtZW50ZWQuDQoNClNvIHRoZSBwYXRjaCBuby4yIHNob3VsZCBiZSByZXZl
cnRlZCBhbmQgcGF0Y2ggbm8uMyBub3QgYXBwbGllZCBhdCBhbGwuDQoNCkkgd2lsbCBwcmVwYXJl
IGEgbmV3IHBhdGNoIHV0aWxpemluZyB0aGUgcmVzZXQtYWN0aXZlLWxvdyBwcm9wZXJ0eS4NCg0K
QWdhaW4sIHNvcnJ5IGZvciB0aGUgdHJvdWJsZXMgYW5kIHRoYW5rIHlvdSBmb3IgeW91ciBjb21t
ZW50cy4NCk1pY2hhbA0K

  reply	other threads:[~2018-10-09 13:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180927092738epcas5p28c53516b73fe7747133914f40c84d6c4@epcas5p2.samsung.com>
2018-09-27  9:24 ` [RESEND PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset Michal Vokáč
2018-09-27  9:24   ` Michal Vokáč
2018-09-27  9:24   ` [RESEND PATCH v2 2/3] video: ssd1307fb: Do not hard code active-low reset sequence Michal Vokáč
2018-09-27  9:24     ` Michal Vokáč
2018-10-08 10:53     ` Bartlomiej Zolnierkiewicz
2018-10-08 10:53       ` Bartlomiej Zolnierkiewicz
2018-09-27  9:24   ` [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity Michal Vokáč
2018-09-27  9:24     ` Michal Vokáč
2018-10-08 11:45     ` Vokáč Michal
2018-10-08 11:45       ` Vokáč Michal
2018-10-09  0:20       ` Shawn Guo
2018-10-09  0:20         ` Shawn Guo
2018-10-09  7:51         ` Bartlomiej Zolnierkiewicz
2018-10-09  7:51           ` Bartlomiej Zolnierkiewicz
2018-10-09  8:29           ` Vokáč Michal
2018-10-09  8:29             ` Vokáč Michal
2018-10-09 12:36             ` Fabio Estevam
2018-10-09 12:36               ` Fabio Estevam
2018-10-09 12:36               ` Fabio Estevam
2018-10-09 13:18               ` Vokáč Michal [this message]
2018-10-09 13:18                 ` Vokáč Michal
2018-10-09 13:18                 ` Vokáč Michal
2018-10-09 13:30                 ` Bartlomiej Zolnierkiewicz
2018-10-09 13:30                   ` Bartlomiej Zolnierkiewicz
2018-10-09 13:30                   ` Bartlomiej Zolnierkiewicz
2018-10-08 10:53   ` [RESEND PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset Bartlomiej Zolnierkiewicz
2018-10-08 10:53     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=221a185c-19fc-cc89-49b1-aa77fb1f0e41@ysoft.com \
    --to=michal.vokac@ysoft.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.