Re: [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity

From: "Vokáč Michal" <Michal.Vokac@ysoft.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity
Date: Mon, 8 Oct 2018 11:45:36 +0000	[thread overview]
Message-ID: <68f4da21-6f0d-5bf9-b352-cdc423269080@ysoft.com> (raw)
In-Reply-To: <1538040281-21319-3-git-send-email-michal.vokac@ysoft.com>

On 27.9.2018 11:24, Michal Vokáč wrote:
> The reset signal of the SSD1306 OLED display is actually active-low.
> Adapt the DT to reflect the real world.
> 
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> ---
> v2 changes: New patch in the series

Bartlomiej just queued the first two patches for v4.20.
Will somebody take this one? Otherwise this SoM will end up with
broken OLED display reset.

Thanks, Michal.

> 
>   arch/arm/boot/dts/imx28-cfa10036.dts | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts
> index e54f5ab..be3406e 100644
> --- a/arch/arm/boot/dts/imx28-cfa10036.dts
> +++ b/arch/arm/boot/dts/imx28-cfa10036.dts
> @@ -11,6 +11,7 @@
>   
>   /dts-v1/;
>   #include "imx28.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>   
>   / {
>   	model = "Crystalfontz CFA-10036 Board";
> @@ -95,7 +96,7 @@
>   					pinctrl-names = "default";
>   					pinctrl-0 = <&ssd1306_cfa10036>;
>   					reg = <0x3c>;
> -					reset-gpios = <&gpio2 7 0>;
> +					reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
>   					solomon,height = <32>;
>   					solomon,width = <128>;
>   					solomon,page-offset = <0>;
> 