All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Reshetova, Elena" <elena.reshetova@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"tj@kernel.org" <tj@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"lizefan@huawei.com" <lizefan@huawei.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"eparis@redhat.com" <eparis@redhat.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"luto@kernel.org" <luto@kernel.org>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"dvhart@infradead.org" <dvhart@infradead.org>,
	"ebiederm@xmission.com" <ebiederm@xmission.com>
Subject: RE: [PATCH 14/15] futex: convert futex_pi_state.refcount to refcount_t
Date: Fri, 1 Sep 2017 13:24:16 +0000	[thread overview]
Message-ID: <2236FBA76BA1254E88B949DDB74E612B6FF63506@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20170901123415.s3fxlyeyourz47av@hirez.programming.kicks-ass.net>


> On Fri, Sep 01, 2017 at 11:05:33AM +0000, Reshetova, Elena wrote:
> > Actually on the second thought: does the above memory ordering differences
> > really apply when  we have ARCH_HAS_REFCOUNT? To me it looks like the way
> > how it is currently implemented for x86 is the same way as it is for atomic cases.
> 
> Never look to x86 for memory ordering, its boring.
> 
> And yes, for the ARM implementation it can certainly make a difference.

So, yes, what I am trying to say is that it can really depend if you have ARCH_HAS_REFCOUNT
enabled or not and then also based on architecture. Thus I believe is also true for atomic: there
might be differences when you use arch. dependent version of function or not. 

So, I guess if I rewrite the commits, I should only include the statement on relaxed memory order
for REFCOUNT_FULL and tell that arch. specific implementations may vary on their properties
(as they do now). 

  reply	other threads:[~2017-09-01 13:24 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 12:22 [PATCH 00/15] v5 kernel core pieces refcount conversions Elena Reshetova
2017-08-30 12:22 ` [PATCH 01/15] sched: convert sighand_struct.count to refcount_t Elena Reshetova
2017-08-30 12:22 ` [PATCH 02/15] sched: convert signal_struct.sigcnt " Elena Reshetova
2017-08-30 12:22 ` [PATCH 03/15] sched: convert user_struct.__count " Elena Reshetova
2017-08-30 12:22 ` [PATCH 04/15] sched: convert numa_group.refcount " Elena Reshetova
2017-08-30 12:22 ` [PATCH 05/15] sched/task_struct: convert task_struct.usage " Elena Reshetova
2017-08-30 12:22 ` [PATCH 06/15] sched/task_struct: convert task_struct.stack_refcount " Elena Reshetova
2017-08-30 12:22 ` [PATCH 07/15] perf: convert perf_event_context.refcount " Elena Reshetova
2017-08-30 12:22 ` [PATCH 08/15] perf/ring_buffer: convert ring_buffer.refcount " Elena Reshetova
2017-08-30 12:22 ` [PATCH 09/15] perf/ring_buffer: convert ring_buffer.aux_refcount " Elena Reshetova
2017-08-30 12:22 ` [PATCH 10/15] uprobes: convert uprobe.ref " Elena Reshetova
2017-08-30 12:22 ` [PATCH 11/15] nsproxy: convert nsproxy.count " Elena Reshetova
2017-08-30 12:22 ` [PATCH 12/15] groups: convert group_info.usage " Elena Reshetova
2017-08-30 12:22 ` [PATCH 13/15] creds: convert cred.usage " Elena Reshetova
2017-08-30 12:22 ` [PATCH 14/15] futex: convert futex_pi_state.refcount " Elena Reshetova
2017-09-01  7:39   ` Thomas Gleixner
2017-09-01  9:38     ` Peter Zijlstra
2017-09-01  9:43       ` Thomas Gleixner
2017-09-01 10:52         ` Reshetova, Elena
2017-09-01 10:52           ` Reshetova, Elena
2017-09-01 11:05         ` Reshetova, Elena
2017-09-01 11:05           ` Reshetova, Elena
2017-09-01 12:34           ` Peter Zijlstra
2017-09-01 12:34             ` Peter Zijlstra
2017-09-01 13:24             ` Reshetova, Elena [this message]
2017-09-01 13:24               ` Reshetova, Elena
2017-09-01 13:36               ` Peter Zijlstra
2017-09-01 13:36                 ` Peter Zijlstra
2017-09-01 17:03                 ` Reshetova, Elena
2017-09-01 17:03                   ` Reshetova, Elena
2017-09-01 19:12                   ` Peter Zijlstra
2017-09-01 19:12                     ` Peter Zijlstra
2017-09-04 10:31                     ` Reshetova, Elena
2017-09-04 10:31                       ` Reshetova, Elena
2017-09-04 12:00                       ` Peter Zijlstra
2017-09-04 12:00                         ` Peter Zijlstra
2017-09-14 16:02                         ` Reshetova, Elena
2017-09-14 16:02                           ` Reshetova, Elena
2017-10-20 12:03                           ` Reshetova, Elena
2017-10-20 12:03                             ` Reshetova, Elena
2017-10-20 12:30                             ` Thomas Gleixner
2017-10-20 12:30                               ` Thomas Gleixner
2017-10-23  7:36                               ` Reshetova, Elena
2017-10-23  7:36                                 ` Reshetova, Elena
2017-08-30 12:22 ` [PATCH 15/15] kcov: convert kcov.refcount " Elena Reshetova
2017-08-31 23:48 ` [PATCH 00/15] v5 kernel core pieces refcount conversions Kees Cook
2017-09-01  9:48   ` Peter Zijlstra
2017-09-01 16:55     ` Kees Cook
2017-09-01 17:08       ` Reshetova, Elena
  -- strict thread matches above, loose matches on Subject: below --
2017-08-25  9:41 [PATCH 00/15] v4 " Elena Reshetova
2017-08-25  9:41 ` [PATCH 14/15] futex: convert futex_pi_state.refcount to refcount_t Elena Reshetova
2017-07-18 10:29 [PATCH 00/15] v4 kernel core pieces refcount conversions Elena Reshetova
2017-07-18 10:30 ` [PATCH 14/15] futex: convert futex_pi_state.refcount to refcount_t Elena Reshetova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2236FBA76BA1254E88B949DDB74E612B6FF63506@IRSMSX102.ger.corp.intel.com \
    --to=elena.reshetova@intel.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=dvhart@infradead.org \
    --cc=ebiederm@xmission.com \
    --cc=eparis@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.