All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugen.Hristev at microchip.com <Eugen.Hristev@microchip.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] boot/at91bootstrap3: add support for at91bootstrap 4.x series
Date: Wed, 19 May 2021 11:36:56 +0000	[thread overview]
Message-ID: <223d3cbf-f1cb-4bdc-aff6-f766e428da33@microchip.com> (raw)
In-Reply-To: <20210519120237.52ddc109@windsurf.orange-hotspot>

On 5/19/21 1:02 PM, Thomas Petazzoni wrote:
> Hello Yann,
> 
> On Wed, 19 May 2021 11:33:23 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> 
>> This introduces two issues.
>>
>> First, and most important: this means that we now have two "known
>> versions". However, you forgot to account for the licensing stuff. We
>> use main.c as a substitute for a license file, but of course main.c
>> differs between 4.x and 3.x...
>>
>> We could carry a per-version hash file, but using main.c as a license
>> file is really just hidding the issue. IOnstead, I've dropped it
>> altogether.
> 
> Aaah, yes, indeed. Thanks for spotting/detecting that.
> 
>> Eugen, Nicolas (and Simon?): would you care to add an actual license
>> file to your repository, please?
> 
> Agreed, Eugen and Nicolas: it would really be better to have a proper
> LICENSE file in your repo. Please add it to both the 3.x branch and the
> 4.x branch :-)

Hi,

Thank you for taking care of this. You could have given me more feedback 
on my previous patch set so I would have changed it, if you felt like 
it, but now it's done, we can move forward, which is good.
I will add a LICENSE file in the repo soon.

Thanks,
Eugen

> 
>> The second issue is less of an issue: there were two defconfigs that use
>> the default 3.x version. Without a tweak, they would have switched over
>> to using 4.x. So I pinned them with BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X.
> 
> Aah, yes, well spotted. I think we should ask the contributor of these
> defconfigs to use a fixed version of AT91Bootstrap, because that's
> normally what we do for bootloader/kernel versions in defconfigs.
> 
>> With the aboce two issues adressed: applied to next, thanks.
> 
> Many thanks!
> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> 

  reply	other threads:[~2021-05-19 11:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 21:37 [Buildroot] [PATCH 0/3] My take on the at91bootstrap 4.x story Thomas Petazzoni
2021-05-18 21:37 ` [Buildroot] [PATCH 1/3] boot/at91bootstrap3: add support for at91bootstrap 4.x series Thomas Petazzoni
2021-05-19  9:33   ` Yann E. MORIN
2021-05-19 10:02     ` Thomas Petazzoni
2021-05-19 11:36       ` Eugen.Hristev at microchip.com [this message]
2021-05-19 12:20         ` Thomas Petazzoni
2021-05-19 12:29           ` Eugen.Hristev at microchip.com
2021-06-14  9:01             ` Eugen.Hristev at microchip.com
2021-06-14 12:28               ` Thomas Petazzoni
2021-06-14 19:25               ` Arnout Vandecappelle
2021-07-07 10:29                 ` Eugen.Hristev at microchip.com
2021-05-19 19:44       ` Edgar Bonet
2021-05-18 21:37 ` [Buildroot] [PATCH 2/3] boot/at91bootstrap3: bump 3.x series to 3.10.2 Thomas Petazzoni
2021-05-18 21:37 ` [Buildroot] [PATCH 3/3] boot/at91bootstrap3: add BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3 Thomas Petazzoni
2021-05-19 11:29   ` Eugen.Hristev at microchip.com
2021-05-19 12:19     ` Thomas Petazzoni
2021-05-19 12:39       ` Yann E. MORIN
2021-05-19  9:34 ` [Buildroot] [PATCH 0/3] My take on the at91bootstrap 4.x story Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=223d3cbf-f1cb-4bdc-aff6-f766e428da33@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=buildroot@busybox.net \
    --subject='Re: [Buildroot] [PATCH 1/3] boot/at91bootstrap3: add support for at91bootstrap 4.x series' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.