All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugen.Hristev at microchip.com <Eugen.Hristev@microchip.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] boot/at91bootstrap3: add BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3
Date: Wed, 19 May 2021 11:29:23 +0000	[thread overview]
Message-ID: <ebcdcf55-e613-6b37-0faa-26b3d548b5be@microchip.com> (raw)
In-Reply-To: <20210518213749.144355-4-thomas.petazzoni@bootlin.com>

On 5/19/21 12:37 AM, Thomas Petazzoni wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
> 
> Some at91bootstrap3 configurations now use Python scripts on the host
> for NAND/PMEC related utilities. In order to be able to use those
> scripts, this commit adds a new
> BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3 which allows to express the
> need for host-python3 as a dependency to build at91bootstrap3.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> [Thomas: this was extracted from a patch from Eugen adding
> at91bootstrap 4.x support.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>   boot/at91bootstrap3/Config.in         | 8 ++++++++
>   boot/at91bootstrap3/at91bootstrap3.mk | 4 ++++
>   2 files changed, 12 insertions(+)
> 
> diff --git a/boot/at91bootstrap3/Config.in b/boot/at91bootstrap3/Config.in
> index 18301a0dc0..966e393db5 100644
> --- a/boot/at91bootstrap3/Config.in
> +++ b/boot/at91bootstrap3/Config.in
> @@ -101,3 +101,11 @@ config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_CONFIG_FILE
>            Path to the at91bootstrap3 configuration file
> 
>   endif # BR2_TARGET_AT91BOOTSTRAP3
> +
> +config BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3
> +       bool "needs host-python3"

Hi,

This prompt that appears in menuconfig is a bit unfriendly : it does not 
say who needs the host-python3, and it does not appear to be in the 
at91bootstrap3 -related options.
It is at the same indentation level as the other bootloaders, like 
Barebox, Grub, etc. So I think it's misleading and should be aligned 
with the other At91bootstrap options




> +       help
> +         Enable this option if the at91bootstrap build process needs
> +         Python 3.x to be available on the host. This is needed in
> +         some at91bootstrap configurations to use NAND/PMECC Python
> +         scripts.
> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
> index fdd87591bb..48200b2b6e 100644
> --- a/boot/at91bootstrap3/at91bootstrap3.mk
> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
> @@ -30,6 +30,10 @@ AT91BOOTSTRAP3_CPE_ID_PRODUCT = at91bootstrap
>   AT91BOOTSTRAP3_INSTALL_IMAGES = YES
>   AT91BOOTSTRAP3_INSTALL_TARGET = NO
> 
> +ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3),y)
> +AT91BOOTSTRAP3_DEPENDENCIES += host-python3
> +endif
> +
>   AT91BOOTSTRAP3_CUSTOM_PATCH_DIR = \
>          $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR))
> 
> --
> 2.31.1
> 

  reply	other threads:[~2021-05-19 11:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 21:37 [Buildroot] [PATCH 0/3] My take on the at91bootstrap 4.x story Thomas Petazzoni
2021-05-18 21:37 ` [Buildroot] [PATCH 1/3] boot/at91bootstrap3: add support for at91bootstrap 4.x series Thomas Petazzoni
2021-05-19  9:33   ` Yann E. MORIN
2021-05-19 10:02     ` Thomas Petazzoni
2021-05-19 11:36       ` Eugen.Hristev at microchip.com
2021-05-19 12:20         ` Thomas Petazzoni
2021-05-19 12:29           ` Eugen.Hristev at microchip.com
2021-06-14  9:01             ` Eugen.Hristev at microchip.com
2021-06-14 12:28               ` Thomas Petazzoni
2021-06-14 19:25               ` Arnout Vandecappelle
2021-07-07 10:29                 ` Eugen.Hristev at microchip.com
2021-05-19 19:44       ` Edgar Bonet
2021-05-18 21:37 ` [Buildroot] [PATCH 2/3] boot/at91bootstrap3: bump 3.x series to 3.10.2 Thomas Petazzoni
2021-05-18 21:37 ` [Buildroot] [PATCH 3/3] boot/at91bootstrap3: add BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3 Thomas Petazzoni
2021-05-19 11:29   ` Eugen.Hristev at microchip.com [this message]
2021-05-19 12:19     ` Thomas Petazzoni
2021-05-19 12:39       ` Yann E. MORIN
2021-05-19  9:34 ` [Buildroot] [PATCH 0/3] My take on the at91bootstrap 4.x story Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebcdcf55-e613-6b37-0faa-26b3d548b5be@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=buildroot@busybox.net \
    --subject='Re: [Buildroot] [PATCH 3/3] boot/at91bootstrap3: add BR2_TARGET_AT91BOOTSTRAP3_NEEDS_PYTHON3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.