All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: <jaswinder.singh@linaro.org>, <eric@anholt.net>,
	<jassisinghbrar@gmail.com>
Cc: <bcm-kernel-feedback-list@broadcom.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-rpi-kernel@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>, <yukuai3@huawei.com>
Subject: Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe()
Date: Wed, 9 Jun 2021 20:13:07 +0800	[thread overview]
Message-ID: <226660de-e502-68b8-131d-27552ccccfd0@huawei.com> (raw)
In-Reply-To: <20210601082454.127810-1-chengzhihao1@huawei.com>

在 2021/6/1 16:24, Zhihao Cheng 写道:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
>   drivers/mailbox/bcm2835-mailbox.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
> index 39761d190545..86b7ce3549c5 100644
> --- a/drivers/mailbox/bcm2835-mailbox.c
> +++ b/drivers/mailbox/bcm2835-mailbox.c
> @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
>   	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>   	if (IS_ERR(mbox->regs)) {
>   		ret = PTR_ERR(mbox->regs);
> -		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>   		return ret;
>   	}
>   

friendly ping.


WARNING: multiple messages have this Message-ID (diff)
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: <jaswinder.singh@linaro.org>, <eric@anholt.net>,
	<jassisinghbrar@gmail.com>
Cc: <bcm-kernel-feedback-list@broadcom.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-rpi-kernel@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>, <yukuai3@huawei.com>
Subject: Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe()
Date: Wed, 9 Jun 2021 20:13:07 +0800	[thread overview]
Message-ID: <226660de-e502-68b8-131d-27552ccccfd0@huawei.com> (raw)
In-Reply-To: <20210601082454.127810-1-chengzhihao1@huawei.com>

在 2021/6/1 16:24, Zhihao Cheng 写道:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
>   drivers/mailbox/bcm2835-mailbox.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
> index 39761d190545..86b7ce3549c5 100644
> --- a/drivers/mailbox/bcm2835-mailbox.c
> +++ b/drivers/mailbox/bcm2835-mailbox.c
> @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
>   	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>   	if (IS_ERR(mbox->regs)) {
>   		ret = PTR_ERR(mbox->regs);
> -		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>   		return ret;
>   	}
>   

friendly ping.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-09 12:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01  8:24 [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox_probe() Zhihao Cheng
2021-06-01  8:24 ` Zhihao Cheng
2021-06-09 12:13 ` Zhihao Cheng [this message]
2021-06-09 12:13   ` Zhihao Cheng
2021-06-09 15:58   ` Scott Branden
2021-06-09 15:58     ` Scott Branden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=226660de-e502-68b8-131d-27552ccccfd0@huawei.com \
    --to=chengzhihao1@huawei.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=eric@anholt.net \
    --cc=jassisinghbrar@gmail.com \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.