* [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
@ 2016-09-13 6:21 Namrata A Shettar
2016-09-13 7:27 ` [Outreachy kernel] " Julia Lawall
2016-09-13 7:33 ` Arnd Bergmann
0 siblings, 2 replies; 7+ messages in thread
From: Namrata A Shettar @ 2016-09-13 6:21 UTC (permalink / raw)
To: Ian Abbott, hsweeten, gregkh, badbuddha91, devel, linux-kernel,
outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
This patch removes an unnecessary blank line that caused checkpatch issue.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
---
Changes in v2:
- Changed the subject line
- Changed description of patch
drivers/staging/comedi/comedi_pcmcia.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_pcmcia.c
b/drivers/staging/comedi/comedi_pcmcia.c
index d7072a5..ec8a0ad 100644
--- a/drivers/staging/comedi/comedi_pcmcia.c
+++ b/drivers/staging/comedi/comedi_pcmcia.c
@@ -18,7 +18,6 @@
#include <linux/module.h>
#include <linux/kernel.h>
-
#include "comedi_pcmcia.h"
/**
[-- Attachment #2: Type: text/html, Size: 920 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
2016-09-13 6:21 [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line Namrata A Shettar
@ 2016-09-13 7:27 ` Julia Lawall
2016-09-13 7:33 ` Arnd Bergmann
1 sibling, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2016-09-13 7:27 UTC (permalink / raw)
To: Namrata A Shettar
Cc: Ian Abbott, hsweeten, gregkh, badbuddha91, devel, linux-kernel,
outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1456 bytes --]
On Tue, 13 Sep 2016, Namrata A Shettar wrote:
> This patch removes an unnecessary blank line that caused checkpatch issue.
Actually, commit messages and subject lines should be written in the
imperative. So you should say eg
Remove unnecessary blank line
instead of
Removes unnecessary blank line
julia
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> Changes in v2:
> - Changed the subject line
> - Changed description of patch
>
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDErWX1NgsruZtt10hi
> hZR2J3cvK-Q9Zj_dp_GLc_0mLmA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
2016-09-13 6:21 [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line Namrata A Shettar
2016-09-13 7:27 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-13 7:33 ` Arnd Bergmann
2016-09-13 9:36 ` Julia Lawall
1 sibling, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2016-09-13 7:33 UTC (permalink / raw)
To: outreachy-kernel
Cc: Namrata A Shettar, Ian Abbott, hsweeten, gregkh, badbuddha91,
devel, linux-kernel
On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
I would argue that checkpatch is wrong here, it's very common to have
an empty line between the global and the local header files.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
2016-09-13 7:33 ` Arnd Bergmann
@ 2016-09-13 9:36 ` Julia Lawall
2016-09-13 9:53 ` Namrata A Shettar
0 siblings, 1 reply; 7+ messages in thread
From: Julia Lawall @ 2016-09-13 9:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: outreachy-kernel, Namrata A Shettar, Ian Abbott, hsweeten,
gregkh, badbuddha91, devel, linux-kernel
On Tue, 13 Sep 2016, Arnd Bergmann wrote:
> On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> > --- a/drivers/staging/comedi/comedi_pcmcia.c
> > +++ b/drivers/staging/comedi/comedi_pcmcia.c
> > @@ -18,7 +18,6 @@
> >
> > #include <linux/module.h>
> > #include <linux/kernel.h>
> > -
> > #include "comedi_pcmcia.h"
> >
> > /**
> >
>
> I would argue that checkpatch is wrong here, it's very common to have
> an empty line between the global and the local header files.
I forwarded this to Joe Perches, and he pointed out that checkpatch
doesn't give a warning for this. Namrata, what version of the kernel are
you using?
julia
>
> Arnd
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2284008.DIPsHg5UWl%40wuerfel.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
2016-09-13 9:36 ` Julia Lawall
@ 2016-09-13 9:53 ` Namrata A Shettar
2016-09-13 9:57 ` Julia Lawall
0 siblings, 1 reply; 7+ messages in thread
From: Namrata A Shettar @ 2016-09-13 9:53 UTC (permalink / raw)
To: outreachy-kernel
Cc: arnd, namrataashettar, abbotti, hsweeten, gregkh, badbuddha91,
devel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 950 bytes --]
Yes I realize that this may be wrong.Thank you for your inputs!
Also,The version of the kernel I am using is : 4.8.0-rc2+
Thanks,
Namrata
On Tuesday, September 13, 2016 at 3:06:06 PM UTC+5:30, Julia Lawall wrote:
>
>
>
> On Tue, 13 Sep 2016, Arnd Bergmann wrote:
>
> > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> > > --- a/drivers/staging/comedi/comedi_pcmcia.c
> > > +++ b/drivers/staging/comedi/comedi_pcmcia.c
> > > @@ -18,7 +18,6 @@
> > >
> > > #include <linux/module.h>
> > > #include <linux/kernel.h>
> > > -
> > > #include "comedi_pcmcia.h"
> > >
> > > /**
> > >
> >
> > I would argue that checkpatch is wrong here, it's very common to have
> > an empty line between the global and the local header files.
>
> I forwarded this to Joe Perches, and he pointed out that checkpatch
> doesn't give a warning for this. Namrata, what version of the kernel are
> you using?
>
> julia
>
>
>
>
[-- Attachment #1.2: Type: text/html, Size: 1311 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
2016-09-13 9:53 ` Namrata A Shettar
@ 2016-09-13 9:57 ` Julia Lawall
2016-09-13 10:18 ` Namrata A Shettar
0 siblings, 1 reply; 7+ messages in thread
From: Julia Lawall @ 2016-09-13 9:57 UTC (permalink / raw)
To: Namrata A Shettar
Cc: outreachy-kernel, arnd, abbotti, hsweeten, gregkh, badbuddha91,
devel, linux-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1889 bytes --]
On Tue, 13 Sep 2016, Namrata A Shettar wrote:
> Yes I realize that this may be wrong.Thank you for your inputs!
>
> Also,The version of the kernel I am using is : 4.8.0-rc2+
You should be using what you get by doing the following command:
git clone -b staging-testing git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Maybe this is what you already have?
julia
>
> Thanks,
> Namrata
>
> On Tuesday, September 13, 2016 at 3:06:06 PM UTC+5:30, Julia Lawall wrote:
>
>
> On Tue, 13 Sep 2016, Arnd Bergmann wrote:
>
> > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A
> Shettar wrote:
> > > --- a/drivers/staging/comedi/comedi_pcmcia.c
> > > +++ b/drivers/staging/comedi/comedi_pcmcia.c
> > > @@ -18,7 +18,6 @@
> > >
> > > #include <linux/module.h>
> > > #include <linux/kernel.h>
> > > -
> > > #include "comedi_pcmcia.h"
> > >
> > > /**
> > >
> >
> > I would argue that checkpatch is wrong here, it's very common
> to have
> > an empty line between the global and the local header files.
>
> I forwarded this to Joe Perches, and he pointed out that
> checkpatch
> doesn't give a warning for this. Namrata, what version of the
> kernel are
> you using?
>
> julia
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/e2fdc076-900a-4a25-9e5a-
> 49d693bd3c74%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
2016-09-13 9:57 ` Julia Lawall
@ 2016-09-13 10:18 ` Namrata A Shettar
0 siblings, 0 replies; 7+ messages in thread
From: Namrata A Shettar @ 2016-09-13 10:18 UTC (permalink / raw)
To: Julia Lawall
Cc: outreachy-kernel, arnd, Ian Abbott, hsweeten, gregkh,
badbuddha91, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
I followed the tutorial : https://kernelnewbies.org/Outreachyfirstpatch
So I think what I have is the same as the one your suggesting.Perhaps,I'll
try running the command you suggested to be completely sure.
Thanks,
Namrata
On Tue, Sep 13, 2016 at 3:27 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Tue, 13 Sep 2016, Namrata A Shettar wrote:
>
> > Yes I realize that this may be wrong.Thank you for your inputs!
> >
> > Also,The version of the kernel I am using is : 4.8.0-rc2+
>
> You should be using what you get by doing the following command:
>
> git clone -b staging-testing git://git.kernel.org/pub/scm/
> linux/kernel/git/gregkh/staging.git
>
> Maybe this is what you already have?
>
> julia
>
>
> <http://groups.google.com/d/msgid/outreachy-kernel/e2fdc076-900a-4a25-9e5a->
[-- Attachment #2: Type: text/html, Size: 1528 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-13 14:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 6:21 [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line Namrata A Shettar
2016-09-13 7:27 ` [Outreachy kernel] " Julia Lawall
2016-09-13 7:33 ` Arnd Bergmann
2016-09-13 9:36 ` Julia Lawall
2016-09-13 9:53 ` Namrata A Shettar
2016-09-13 9:57 ` Julia Lawall
2016-09-13 10:18 ` Namrata A Shettar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.