From: Paolo Abeni <pabeni@redhat.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 02/11] udp/ipv6: refactor udpv6_sendmsg udplite checks
Date: Thu, 28 Apr 2022 16:09:37 +0200 [thread overview]
Message-ID: <229c169ccf8fdbf7fc826901982f1f15e86f3d17.camel@redhat.com> (raw)
In-Reply-To: <33dfdf2119c86e35062f783d405bedec2fde2b4c.1651071843.git.asml.silence@gmail.com>
On Thu, 2022-04-28 at 11:56 +0100, Pavel Begunkov wrote:
> Don't save a IS_UDPLITE() result in advance but do when it's really
> needed, so it doesn't store/load it from the stack. Same for resolving
> the getfrag callback pointer.
It's quite unclear to me if this change brings really any performance
benefit. The end results will depend a lot on the optimization
performed by the compiler, and IMHO the code looks better before this
modifications.
Paolo
next prev parent reply other threads:[~2022-04-28 14:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 10:56 [PATCH net-next 00/11] UDP/IPv6 refactoring Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 01/11] ipv6: optimise ipcm6 cookie init Pavel Begunkov
2022-04-28 14:04 ` Paolo Abeni
2022-04-28 15:27 ` Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 02/11] udp/ipv6: refactor udpv6_sendmsg udplite checks Pavel Begunkov
2022-04-28 14:09 ` Paolo Abeni [this message]
2022-04-28 15:11 ` Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 03/11] udp/ipv6: move pending section of udpv6_sendmsg Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 04/11] udp/ipv6: prioritise the ip6 path over ip4 checks Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 05/11] udp/ipv6: optimise udpv6_sendmsg() daddr checks Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 06/11] udp/ipv6: optimise out daddr reassignment Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 07/11] udp/ipv6: clean up udpv6_sendmsg's saddr init Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 08/11] ipv6: partially inline fl6_update_dst() Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 09/11] ipv6: refactor opts push in __ip6_make_skb() Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 10/11] ipv6: improve opt-less __ip6_make_skb() Pavel Begunkov
2022-04-28 10:56 ` [PATCH net-next 11/11] ipv6: clean up ip6_setup_cork Pavel Begunkov
2022-04-28 14:04 ` [PATCH net-next 00/11] UDP/IPv6 refactoring Paolo Abeni
2022-04-28 15:03 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229c169ccf8fdbf7fc826901982f1f15e86f3d17.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.