From: Md Danish Anwar <a0501179@ti.com> To: Roger Quadros <rogerq@kernel.org>, MD Danish Anwar <danishanwar@ti.com>, "Andrew F. Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, Nishanth Menon <nm@ti.com> Cc: <linux-remoteproc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, <srk@ti.com>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org> Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Date: Fri, 17 Mar 2023 10:32:34 +0530 [thread overview] Message-ID: <22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com> (raw) In-Reply-To: <455440f4-7f2b-366e-53ec-700c3bb98534@kernel.org> On 16/03/23 19:34, Roger Quadros wrote: > > Hi, > > On 16/03/2023 15:11, Md Danish Anwar wrote: >> >> >> On 16/03/23 17:49, Roger Quadros wrote: >>> >>> >>> On 16/03/2023 13:44, Md Danish Anwar wrote: >>>> >>>> On 16/03/23 17:06, Roger Quadros wrote: >>>>> Hi, >>>>> >>>>> On 16/03/2023 13:05, Md Danish Anwar wrote: >>>>>> Hi Roger, >>>>>> >>>>>> On 15/03/23 17:52, Roger Quadros wrote: >>>>>>> >>>>>>> >>>>>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>>>>> From: Suman Anna <s-anna@ti.com> > [..] >> Sure, then I will use the existing enum pru_type. >> >> The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this >> enum definition from there to include/linux/remoteproc/pruss.h > > There are 2 public pruss.h files. > include/linux/remoteproc/pruss.h > and > include/linux/pruss_driver.h > > Why is that and when to use what? > The include/linux/remoteproc/pruss.h file was introduced in series [1] as a public header file for PRU_RPROC driver (drivers/remoteproc/pru_rproc.c) The second header file include/linux/pruss_driver.h was introduced much earlier as part of [2] , "soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs". As far as I can see, seems like pruss_driver.h was added as a public header file for PRUSS platform driver (drivers/soc/ti/pruss.c) [1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/ [2] https://lore.kernel.org/all/1542886753-17625-7-git-send-email-rogerq@ti.com/ > cheers, > -roger -- Thanks and Regards, Danish.
WARNING: multiple messages have this Message-ID (diff)
From: Md Danish Anwar <a0501179@ti.com> To: Roger Quadros <rogerq@kernel.org>, MD Danish Anwar <danishanwar@ti.com>, "Andrew F. Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, Nishanth Menon <nm@ti.com> Cc: <linux-remoteproc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, <srk@ti.com>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org> Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Date: Fri, 17 Mar 2023 10:32:34 +0530 [thread overview] Message-ID: <22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com> (raw) In-Reply-To: <455440f4-7f2b-366e-53ec-700c3bb98534@kernel.org> On 16/03/23 19:34, Roger Quadros wrote: > > Hi, > > On 16/03/2023 15:11, Md Danish Anwar wrote: >> >> >> On 16/03/23 17:49, Roger Quadros wrote: >>> >>> >>> On 16/03/2023 13:44, Md Danish Anwar wrote: >>>> >>>> On 16/03/23 17:06, Roger Quadros wrote: >>>>> Hi, >>>>> >>>>> On 16/03/2023 13:05, Md Danish Anwar wrote: >>>>>> Hi Roger, >>>>>> >>>>>> On 15/03/23 17:52, Roger Quadros wrote: >>>>>>> >>>>>>> >>>>>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>>>>> From: Suman Anna <s-anna@ti.com> > [..] >> Sure, then I will use the existing enum pru_type. >> >> The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this >> enum definition from there to include/linux/remoteproc/pruss.h > > There are 2 public pruss.h files. > include/linux/remoteproc/pruss.h > and > include/linux/pruss_driver.h > > Why is that and when to use what? > The include/linux/remoteproc/pruss.h file was introduced in series [1] as a public header file for PRU_RPROC driver (drivers/remoteproc/pru_rproc.c) The second header file include/linux/pruss_driver.h was introduced much earlier as part of [2] , "soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs". As far as I can see, seems like pruss_driver.h was added as a public header file for PRUSS platform driver (drivers/soc/ti/pruss.c) [1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/ [2] https://lore.kernel.org/all/1542886753-17625-7-git-send-email-rogerq@ti.com/ > cheers, > -roger -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-17 5:03 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-13 11:11 [PATCH v4 0/5] Introduce PRU platform consumer API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-13 11:11 ` [PATCH v4 1/5] soc: ti: pruss: Add pruss_get()/put() API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-13 16:19 ` Andrew Davis 2023-03-13 16:19 ` Andrew Davis 2023-03-13 11:11 ` [PATCH v4 2/5] soc: ti: pruss: Add pruss_{request,release}_mem_region() API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-17 8:56 ` Roger Quadros 2023-03-17 8:56 ` Roger Quadros 2023-03-20 5:11 ` [EXTERNAL] " Md Danish Anwar 2023-03-20 5:11 ` Md Danish Anwar 2023-03-20 16:18 ` Andrew Davis 2023-03-20 16:18 ` Andrew Davis 2023-03-21 5:23 ` Md Danish Anwar 2023-03-21 5:23 ` Md Danish Anwar 2023-03-21 9:24 ` Roger Quadros 2023-03-21 9:24 ` Roger Quadros 2023-03-21 9:48 ` [EXTERNAL] " Md Danish Anwar 2023-03-21 9:48 ` Md Danish Anwar 2023-03-21 10:23 ` Roger Quadros 2023-03-21 10:23 ` Roger Quadros 2023-03-21 10:45 ` Md Danish Anwar 2023-03-21 10:45 ` Md Danish Anwar 2023-03-13 11:11 ` [PATCH v4 3/5] soc: ti: pruss: Add pruss_cfg_read()/update() API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-15 12:07 ` Roger Quadros 2023-03-15 12:07 ` Roger Quadros 2023-03-16 11:08 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 11:08 ` Md Danish Anwar 2023-03-16 11:29 ` Md Danish Anwar 2023-03-16 11:29 ` Md Danish Anwar 2023-03-16 11:32 ` Roger Quadros 2023-03-16 11:32 ` Roger Quadros 2023-03-16 11:34 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 11:34 ` Md Danish Anwar 2023-03-13 11:11 ` [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-15 12:22 ` Roger Quadros 2023-03-15 12:22 ` Roger Quadros 2023-03-16 11:05 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 11:05 ` Md Danish Anwar 2023-03-16 11:36 ` Roger Quadros 2023-03-16 11:36 ` Roger Quadros 2023-03-16 11:44 ` Md Danish Anwar 2023-03-16 11:44 ` Md Danish Anwar 2023-03-16 12:19 ` Roger Quadros 2023-03-16 12:19 ` Roger Quadros 2023-03-16 13:11 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 13:11 ` Md Danish Anwar 2023-03-16 14:04 ` Roger Quadros 2023-03-16 14:04 ` Roger Quadros 2023-03-17 5:02 ` Md Danish Anwar [this message] 2023-03-17 5:02 ` [EXTERNAL] " Md Danish Anwar 2023-03-17 8:31 ` Roger Quadros 2023-03-17 8:31 ` Roger Quadros 2023-03-17 8:55 ` [EXTERNAL] " Md Danish Anwar 2023-03-17 8:55 ` Md Danish Anwar 2023-03-13 11:11 ` [PATCH v4 5/5] soc: ti: pruss: Add helper functions to get/set PRUSS_CFG_GPMUX MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com \ --to=a0501179@ti.com \ --cc=afd@ti.com \ --cc=andersson@kernel.org \ --cc=danishanwar@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=netdev@vger.kernel.org \ --cc=nm@ti.com \ --cc=rogerq@kernel.org \ --cc=s-anna@ti.com \ --cc=srk@ti.com \ --cc=ssantosh@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.