From: Roger Quadros <rogerq@kernel.org> To: MD Danish Anwar <danishanwar@ti.com>, "Andrew F. Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, Nishanth Menon <nm@ti.com> Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Date: Wed, 15 Mar 2023 14:22:18 +0200 [thread overview] Message-ID: <d168e7dd-42a0-b728-5c4c-e97209c13871@kernel.org> (raw) In-Reply-To: <20230313111127.1229187-5-danishanwar@ti.com> On 13/03/2023 13:11, MD Danish Anwar wrote: > From: Suman Anna <s-anna@ti.com> > > The PRUSS CFG module is represented as a syscon node and is currently > managed by the PRUSS platform driver. Add easy accessor functions to set > GPI mode, MII_RT event enable/disable and XFR (XIN XOUT) enable/disable > to enable the PRUSS Ethernet usecase. These functions reuse the generic > pruss_cfg_update() API function. > > Signed-off-by: Suman Anna <s-anna@ti.com> > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> > Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> > Signed-off-by: Puranjay Mohan <p-mohan@ti.com> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > --- > drivers/soc/ti/pruss.c | 60 ++++++++++++++++++++++++++++++++ > include/linux/remoteproc/pruss.h | 22 ++++++++++++ > 2 files changed, 82 insertions(+) > > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index 26d8129b515c..2f04b7922ddb 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -203,6 +203,66 @@ static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, > return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); > } > > +/** > + * pruss_cfg_gpimode() - set the GPI mode of the PRU > + * @pruss: the pruss instance handle > + * @pru_id: id of the PRU core within the PRUSS > + * @mode: GPI mode to set > + * > + * Sets the GPI mode for a given PRU by programming the > + * corresponding PRUSS_CFG_GPCFGx register > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode) > +{ > + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) > + return -EINVAL; > + > + if (mode < 0 || mode > PRUSS_GPI_MODE_MAX) > + return -EINVAL; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), > + PRUSS_GPCFG_PRU_GPI_MODE_MASK, > + mode << PRUSS_GPCFG_PRU_GPI_MODE_SHIFT); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_gpimode); > + > +/** > + * pruss_cfg_miirt_enable() - Enable/disable MII RT Events > + * @pruss: the pruss instance > + * @enable: enable/disable > + * > + * Enable/disable the MII RT Events for the PRUSS. > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) > +{ > + u32 set = enable ? PRUSS_MII_RT_EVENT_EN : 0; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_MII_RT, > + PRUSS_MII_RT_EVENT_EN, set); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_miirt_enable); > + > +/** > + * pruss_cfg_xfr_enable() - Enable/disable XIN XOUT shift functionality > + * @pruss: the pruss instance > + * @enable: enable/disable > + * @mask: Mask for PRU / RTU You should not expect the user to provide the mask but only the core type e.g. enum pru_type { PRU_TYPE_PRU = 0, PRU_TYPE_RTU, PRU_TYPE_TX_PRU, PRU_TYPE_MAX, }; Then you figure out the mask in the function. Also check for invalid pru_type and return error if so. > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask) re-arrange so it is (struct pruss, enum pru_type, bool enable) > +{ > + u32 set = enable ? mask : 0; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_SPP, mask, set); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_xfr_enable); > + > static void pruss_of_free_clk_provider(void *data) > { > struct device_node *clk_mux_np = data; > diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h > index 12ef10b9fe9a..51a3eedd2be6 100644 > --- a/include/linux/remoteproc/pruss.h > +++ b/include/linux/remoteproc/pruss.h > @@ -101,6 +101,7 @@ enum pruss_gpi_mode { > PRUSS_GPI_MODE_PARALLEL, > PRUSS_GPI_MODE_28BIT_SHIFT, > PRUSS_GPI_MODE_MII, > + PRUSS_GPI_MODE_MAX, This could have come as part of patch 3. > }; > > /** > @@ -165,6 +166,10 @@ int pruss_request_mem_region(struct pruss *pruss, enum pruss_mem mem_id, > struct pruss_mem_region *region); > int pruss_release_mem_region(struct pruss *pruss, > struct pruss_mem_region *region); > +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode); > +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable); > +int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask); > > #else > > @@ -188,6 +193,23 @@ static inline int pruss_release_mem_region(struct pruss *pruss, > return -EOPNOTSUPP; > } > > +static inline int pruss_cfg_gpimode(struct pruss *pruss, > + enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > #endif /* CONFIG_TI_PRUSS */ > > #if IS_ENABLED(CONFIG_PRU_REMOTEPROC) cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@kernel.org> To: MD Danish Anwar <danishanwar@ti.com>, "Andrew F. Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, Nishanth Menon <nm@ti.com> Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Date: Wed, 15 Mar 2023 14:22:18 +0200 [thread overview] Message-ID: <d168e7dd-42a0-b728-5c4c-e97209c13871@kernel.org> (raw) In-Reply-To: <20230313111127.1229187-5-danishanwar@ti.com> On 13/03/2023 13:11, MD Danish Anwar wrote: > From: Suman Anna <s-anna@ti.com> > > The PRUSS CFG module is represented as a syscon node and is currently > managed by the PRUSS platform driver. Add easy accessor functions to set > GPI mode, MII_RT event enable/disable and XFR (XIN XOUT) enable/disable > to enable the PRUSS Ethernet usecase. These functions reuse the generic > pruss_cfg_update() API function. > > Signed-off-by: Suman Anna <s-anna@ti.com> > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> > Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org> > Signed-off-by: Puranjay Mohan <p-mohan@ti.com> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > --- > drivers/soc/ti/pruss.c | 60 ++++++++++++++++++++++++++++++++ > include/linux/remoteproc/pruss.h | 22 ++++++++++++ > 2 files changed, 82 insertions(+) > > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index 26d8129b515c..2f04b7922ddb 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -203,6 +203,66 @@ static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, > return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); > } > > +/** > + * pruss_cfg_gpimode() - set the GPI mode of the PRU > + * @pruss: the pruss instance handle > + * @pru_id: id of the PRU core within the PRUSS > + * @mode: GPI mode to set > + * > + * Sets the GPI mode for a given PRU by programming the > + * corresponding PRUSS_CFG_GPCFGx register > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode) > +{ > + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) > + return -EINVAL; > + > + if (mode < 0 || mode > PRUSS_GPI_MODE_MAX) > + return -EINVAL; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), > + PRUSS_GPCFG_PRU_GPI_MODE_MASK, > + mode << PRUSS_GPCFG_PRU_GPI_MODE_SHIFT); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_gpimode); > + > +/** > + * pruss_cfg_miirt_enable() - Enable/disable MII RT Events > + * @pruss: the pruss instance > + * @enable: enable/disable > + * > + * Enable/disable the MII RT Events for the PRUSS. > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) > +{ > + u32 set = enable ? PRUSS_MII_RT_EVENT_EN : 0; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_MII_RT, > + PRUSS_MII_RT_EVENT_EN, set); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_miirt_enable); > + > +/** > + * pruss_cfg_xfr_enable() - Enable/disable XIN XOUT shift functionality > + * @pruss: the pruss instance > + * @enable: enable/disable > + * @mask: Mask for PRU / RTU You should not expect the user to provide the mask but only the core type e.g. enum pru_type { PRU_TYPE_PRU = 0, PRU_TYPE_RTU, PRU_TYPE_TX_PRU, PRU_TYPE_MAX, }; Then you figure out the mask in the function. Also check for invalid pru_type and return error if so. > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask) re-arrange so it is (struct pruss, enum pru_type, bool enable) > +{ > + u32 set = enable ? mask : 0; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_SPP, mask, set); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_xfr_enable); > + > static void pruss_of_free_clk_provider(void *data) > { > struct device_node *clk_mux_np = data; > diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h > index 12ef10b9fe9a..51a3eedd2be6 100644 > --- a/include/linux/remoteproc/pruss.h > +++ b/include/linux/remoteproc/pruss.h > @@ -101,6 +101,7 @@ enum pruss_gpi_mode { > PRUSS_GPI_MODE_PARALLEL, > PRUSS_GPI_MODE_28BIT_SHIFT, > PRUSS_GPI_MODE_MII, > + PRUSS_GPI_MODE_MAX, This could have come as part of patch 3. > }; > > /** > @@ -165,6 +166,10 @@ int pruss_request_mem_region(struct pruss *pruss, enum pruss_mem mem_id, > struct pruss_mem_region *region); > int pruss_release_mem_region(struct pruss *pruss, > struct pruss_mem_region *region); > +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode); > +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable); > +int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask); > > #else > > @@ -188,6 +193,23 @@ static inline int pruss_release_mem_region(struct pruss *pruss, > return -EOPNOTSUPP; > } > > +static inline int pruss_cfg_gpimode(struct pruss *pruss, > + enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > #endif /* CONFIG_TI_PRUSS */ > > #if IS_ENABLED(CONFIG_PRU_REMOTEPROC) cheers, -roger
next prev parent reply other threads:[~2023-03-15 12:23 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-13 11:11 [PATCH v4 0/5] Introduce PRU platform consumer API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-13 11:11 ` [PATCH v4 1/5] soc: ti: pruss: Add pruss_get()/put() API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-13 16:19 ` Andrew Davis 2023-03-13 16:19 ` Andrew Davis 2023-03-13 11:11 ` [PATCH v4 2/5] soc: ti: pruss: Add pruss_{request,release}_mem_region() API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-17 8:56 ` Roger Quadros 2023-03-17 8:56 ` Roger Quadros 2023-03-20 5:11 ` [EXTERNAL] " Md Danish Anwar 2023-03-20 5:11 ` Md Danish Anwar 2023-03-20 16:18 ` Andrew Davis 2023-03-20 16:18 ` Andrew Davis 2023-03-21 5:23 ` Md Danish Anwar 2023-03-21 5:23 ` Md Danish Anwar 2023-03-21 9:24 ` Roger Quadros 2023-03-21 9:24 ` Roger Quadros 2023-03-21 9:48 ` [EXTERNAL] " Md Danish Anwar 2023-03-21 9:48 ` Md Danish Anwar 2023-03-21 10:23 ` Roger Quadros 2023-03-21 10:23 ` Roger Quadros 2023-03-21 10:45 ` Md Danish Anwar 2023-03-21 10:45 ` Md Danish Anwar 2023-03-13 11:11 ` [PATCH v4 3/5] soc: ti: pruss: Add pruss_cfg_read()/update() API MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-15 12:07 ` Roger Quadros 2023-03-15 12:07 ` Roger Quadros 2023-03-16 11:08 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 11:08 ` Md Danish Anwar 2023-03-16 11:29 ` Md Danish Anwar 2023-03-16 11:29 ` Md Danish Anwar 2023-03-16 11:32 ` Roger Quadros 2023-03-16 11:32 ` Roger Quadros 2023-03-16 11:34 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 11:34 ` Md Danish Anwar 2023-03-13 11:11 ` [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar 2023-03-15 12:22 ` Roger Quadros [this message] 2023-03-15 12:22 ` Roger Quadros 2023-03-16 11:05 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 11:05 ` Md Danish Anwar 2023-03-16 11:36 ` Roger Quadros 2023-03-16 11:36 ` Roger Quadros 2023-03-16 11:44 ` Md Danish Anwar 2023-03-16 11:44 ` Md Danish Anwar 2023-03-16 12:19 ` Roger Quadros 2023-03-16 12:19 ` Roger Quadros 2023-03-16 13:11 ` [EXTERNAL] " Md Danish Anwar 2023-03-16 13:11 ` Md Danish Anwar 2023-03-16 14:04 ` Roger Quadros 2023-03-16 14:04 ` Roger Quadros 2023-03-17 5:02 ` [EXTERNAL] " Md Danish Anwar 2023-03-17 5:02 ` Md Danish Anwar 2023-03-17 8:31 ` Roger Quadros 2023-03-17 8:31 ` Roger Quadros 2023-03-17 8:55 ` [EXTERNAL] " Md Danish Anwar 2023-03-17 8:55 ` Md Danish Anwar 2023-03-13 11:11 ` [PATCH v4 5/5] soc: ti: pruss: Add helper functions to get/set PRUSS_CFG_GPMUX MD Danish Anwar 2023-03-13 11:11 ` MD Danish Anwar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d168e7dd-42a0-b728-5c4c-e97209c13871@kernel.org \ --to=rogerq@kernel.org \ --cc=afd@ti.com \ --cc=andersson@kernel.org \ --cc=danishanwar@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=netdev@vger.kernel.org \ --cc=nm@ti.com \ --cc=s-anna@ti.com \ --cc=srk@ti.com \ --cc=ssantosh@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.