All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Zhang <yang.zhang.wz@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Wanpeng Li" <kernellwp@gmail.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	tony.luck@intel.com, "Borislav Petkov" <bp@alien8.de>,
	"Peter Zijlstra" <peterz@infradead.org>,
	mchehab@kernel.org, "Andrew Morton" <akpm@linux-foundation.org>,
	krzk@kernel.org, jpoimboe@redhat.com,
	"Andy Lutomirski" <luto@kernel.org>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Thomas Garnier" <thgarnie@google.com>,
	"Robert Gerst" <rgerst@gmail.com>,
	"Mathias Krause" <minipli@googlemail.com>,
	douly.fnst@cn.fujitsu.com, "Nicolai Stange" <nicstange@gmail.com>,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	dvlasenk@redhat.com,
	"Daniel Bristot de Oliveira" <bristot@redhat.com>,
	yamada.masahiro@socionext.com, mika.westerberg@linux.intel.com,
	"Chen Yu" <yu.c.chen@intel.com>,
	aaron.lu@intel.com, "Steven Rostedt" <rostedt@goodmis.org>,
	"Kyle Huey" <me@kylehuey.com>, "Len Brown" <len.brown@intel.com>,
	"Prarit Bhargava" <prarit@redhat.com>,
	hidehiro.kawai.ez@hitachi.com, fengtiantian@huawei.com,
	pmladek@suse.com, jeyu@redhat.com, Larry.Finger@lwfinger.net,
	zijun_hu@htc.com, luisbg@osg.samsung.com,
	johannes.berg@intel.com, niklas.soderlund+renesas@ragnatech.se,
	zlpnobody@gmail.com, "Alexey Dobriyan" <adobriyan@gmail.com>,
	fgao@48lvckh6395k16k5.yundunddos.com, ebiederm@xmission.com,
	"Subash Abhinov Kasiviswanathan" <subashab@codeaurora.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Matt Fleming" <matt@codeblueprint.co.uk>,
	"Mel Gorman" <mgorman@techsingularity.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-doc@vger.kernel.org, linux-edac@vger.kernel.org,
	kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86/idle: use dynamic halt poll
Date: Tue, 4 Jul 2017 10:19:28 +0800	[thread overview]
Message-ID: <22bd985d-739e-0a6e-7b16-9f6e3cd39445@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1707031205060.2188@nanos>

On 2017/7/3 18:06, Thomas Gleixner wrote:
> On Mon, 3 Jul 2017, Yang Zhang wrote:
>> The background is that we(Alibaba Cloud) do get more and more complaints from
>> our customers in both KVM and Xen compare to bare-mental.After investigations,
>> the root cause is known to us: big cost in message passing workload(David show
>> it in KVM forum 2015)
>>
>> A typical message workload like below:
>> vcpu 0                             vcpu 1
>> 1. send ipi                     2.  doing hlt
>> 3. go into idle                 4.  receive ipi and wake up from hlt
>> 5. write APIC time twice        6.  write APIC time twice to
>>    to stop sched timer              reprogram sched timer
>> 7. doing hlt                    8.  handle task and send ipi to
>>                                     vcpu 0
>> 9. same to 4.                   10. same to 3
>>
>> One transaction will introduce about 12 vmexits(2 hlt and 10 msr write). The
>> cost of such vmexits will degrades performance severely. Linux kernel already
>> provide idle=poll to mitigate the trend. But it only eliminates the IPI and
>> hlt vmexit. It has nothing to do with start/stop sched timer. A compromise
>> would be to turn off NOHZ kernel, but it is not the default config for new
>> distributions.
>
> You still can turn if off on the kernel command line via nohz=off

You are right. Senior users will turn off it manually. But it only solve 
the sched timer. They still have the IPI/hlt problem. Another point is 
we release the distribution image to customer without any extra 
configuration to avoid mismatch between VM and bare-metal. To change 
such configuration needs reboot, but some customer's business cannot be 
interrupted after they start the service(like online gaming). It would 
be better if we can provide the sysctl interface to allow run-time 
modification. By the way, idle=poll seems too heavy to use.



>
> Thanks,
>
> 	tglx
>


-- 
Yang
Alibaba Cloud Computing

WARNING: multiple messages have this Message-ID (diff)
From: Yang Zhang <yang.zhang.wz@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Wanpeng Li" <kernellwp@gmail.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	tony.luck@intel.com, "Borislav Petkov" <bp@alien8.de>,
	"Peter Zijlstra" <peterz@infradead.org>,
	mchehab@kernel.org, "Andrew Morton" <akpm@linux-foundation.org>,
	krzk@kernel.org, jpoimboe@redhat.com,
	"Andy Lutomirski" <luto@kernel.org>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Thomas Garnier" <thgarnie@google.com>,
	"Robert Gerst" <rgerst@gmail.com>,
	"Mathias Krause" <minipli@googlemail.com>,
	douly.fnst@cn.fujitsu.com, "Nicolai Stange" <nicstange@gmail.com>,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	dvlasenk@redhat.com,
	"Daniel Bristot de Oliveira" <bristot@redhat.com>,
	yamada.masahiro@socionext.com, mika.westerberg@linux.intel.com,
	"Chen Yu" <yu.c.chen@intel.com>,
	aaron.lu@intel.com, "Steven Rostedt" <rostedt@goodmis.org>,
	"Kyle Huey" <me@kylehuey.com>, "Len Brown" <len.brown@intel.com>,
	"Prarit Bhargava" <prarit@redhat.com>,
	hidehiro.kawai.ez@hitachi.com, fengtiantian@huawei.com,
	pmladek@suse.com, jeyu@redhat.com, Larry.Finger@lwfinger.net,
	zijun_hu@htc.com, luisbg@osg.samsung.com,
	johannes.berg@intel.com, niklas.soderlund+renesas@ragnatech.se,
	zlpnobody@gmail.com, "Alexey Dobriyan" <adobriyan@gmail.com>,
	fgao@ikuai8.com, ebiederm@xmission.com,
	"Subash Abhinov Kasiviswanathan" <subashab@codeaurora.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Matt Fleming" <matt@codeblueprint.co.uk>,
	"Mel Gorman" <mgorman@techsingularity.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-doc@vger.kernel.org, linux-edac@vger.kernel.org,
	kvm <kvm@vger.kernel.org>
Subject: [2/2] x86/idle: use dynamic halt poll
Date: Tue, 4 Jul 2017 10:19:28 +0800	[thread overview]
Message-ID: <22bd985d-739e-0a6e-7b16-9f6e3cd39445@gmail.com> (raw)

On 2017/7/3 18:06, Thomas Gleixner wrote:
> On Mon, 3 Jul 2017, Yang Zhang wrote:
>> The background is that we(Alibaba Cloud) do get more and more complaints from
>> our customers in both KVM and Xen compare to bare-mental.After investigations,
>> the root cause is known to us: big cost in message passing workload(David show
>> it in KVM forum 2015)
>>
>> A typical message workload like below:
>> vcpu 0                             vcpu 1
>> 1. send ipi                     2.  doing hlt
>> 3. go into idle                 4.  receive ipi and wake up from hlt
>> 5. write APIC time twice        6.  write APIC time twice to
>>    to stop sched timer              reprogram sched timer
>> 7. doing hlt                    8.  handle task and send ipi to
>>                                     vcpu 0
>> 9. same to 4.                   10. same to 3
>>
>> One transaction will introduce about 12 vmexits(2 hlt and 10 msr write). The
>> cost of such vmexits will degrades performance severely. Linux kernel already
>> provide idle=poll to mitigate the trend. But it only eliminates the IPI and
>> hlt vmexit. It has nothing to do with start/stop sched timer. A compromise
>> would be to turn off NOHZ kernel, but it is not the default config for new
>> distributions.
>
> You still can turn if off on the kernel command line via nohz=off

You are right. Senior users will turn off it manually. But it only solve 
the sched timer. They still have the IPI/hlt problem. Another point is 
we release the distribution image to customer without any extra 
configuration to avoid mismatch between VM and bare-metal. To change 
such configuration needs reboot, but some customer's business cannot be 
interrupted after they start the service(like online gaming). It would 
be better if we can provide the sysctl interface to allow run-time 
modification. By the way, idle=poll seems too heavy to use.



>
> Thanks,
>
> 	tglx
>

WARNING: multiple messages have this Message-ID (diff)
From: Yang Zhang <yang.zhang.wz@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Wanpeng Li" <kernellwp@gmail.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	tony.luck@intel.com, "Borislav Petkov" <bp@alien8.de>,
	"Peter Zijlstra" <peterz@infradead.org>,
	mchehab@kernel.org, "Andrew Morton" <akpm@linux-foundation.org>,
	krzk@kernel.org, jpoimboe@redhat.com,
	"Andy Lutomirski" <luto@kernel.org>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Thomas Garnier" <thgarnie@google.com>,
	"Robert Gerst" <rgerst@gmail.com>,
	"Mathias Krause" <minipli@googlemail.com>,
	douly.fnst@cn.fujitsu.com, "Nicolai Stange" <nicstange@gmail.com>,
	"Frederic Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH 2/2] x86/idle: use dynamic halt poll
Date: Tue, 4 Jul 2017 10:19:28 +0800	[thread overview]
Message-ID: <22bd985d-739e-0a6e-7b16-9f6e3cd39445@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1707031205060.2188@nanos>

On 2017/7/3 18:06, Thomas Gleixner wrote:
> On Mon, 3 Jul 2017, Yang Zhang wrote:
>> The background is that we(Alibaba Cloud) do get more and more complaints from
>> our customers in both KVM and Xen compare to bare-mental.After investigations,
>> the root cause is known to us: big cost in message passing workload(David show
>> it in KVM forum 2015)
>>
>> A typical message workload like below:
>> vcpu 0                             vcpu 1
>> 1. send ipi                     2.  doing hlt
>> 3. go into idle                 4.  receive ipi and wake up from hlt
>> 5. write APIC time twice        6.  write APIC time twice to
>>    to stop sched timer              reprogram sched timer
>> 7. doing hlt                    8.  handle task and send ipi to
>>                                     vcpu 0
>> 9. same to 4.                   10. same to 3
>>
>> One transaction will introduce about 12 vmexits(2 hlt and 10 msr write). The
>> cost of such vmexits will degrades performance severely. Linux kernel already
>> provide idle=poll to mitigate the trend. But it only eliminates the IPI and
>> hlt vmexit. It has nothing to do with start/stop sched timer. A compromise
>> would be to turn off NOHZ kernel, but it is not the default config for new
>> distributions.
>
> You still can turn if off on the kernel command line via nohz=off

You are right. Senior users will turn off it manually. But it only solve 
the sched timer. They still have the IPI/hlt problem. Another point is 
we release the distribution image to customer without any extra 
configuration to avoid mismatch between VM and bare-metal. To change 
such configuration needs reboot, but some customer's business cannot be 
interrupted after they start the service(like online gaming). It would 
be better if we can provide the sysctl interface to allow run-time 
modification. By the way, idle=poll seems too heavy to use.



>
> Thanks,
>
> 	tglx
>


-- 
Yang
Alibaba Cloud Computing

  reply	other threads:[~2017-07-04  2:19 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 11:22 [PATCH 0/2] x86/idle: add halt poll support root
2017-06-22 11:22 ` root
2017-06-22 11:22 ` [PATCH 1/2] x86/idle: add halt poll for halt idle root
2017-06-22 11:22   ` root
2017-06-22 11:22   ` [1/2] " Yang Zhang
2017-06-22 14:23   ` [PATCH 1/2] " Thomas Gleixner
2017-06-22 14:23     ` Thomas Gleixner
2017-06-22 14:23     ` [1/2] " Thomas Gleixner
2017-06-23  4:05     ` [PATCH 1/2] " Yang Zhang
2017-06-23  4:05       ` Yang Zhang
2017-06-23  4:05       ` [1/2] " Yang Zhang
2017-08-16  4:04   ` [PATCH 1/2] " Michael S. Tsirkin
2017-08-16  4:04     ` Michael S. Tsirkin
2017-08-16  4:04     ` [1/2] " Michael S. Tsirkin
2017-08-17  7:29     ` [PATCH 1/2] " Yang Zhang
2017-08-17  7:29       ` Yang Zhang
2017-08-17  7:29       ` [1/2] " Yang Zhang
2017-06-22 11:22 ` [PATCH 2/2] x86/idle: use dynamic halt poll root
2017-06-22 11:22   ` root
2017-06-22 11:22   ` [2/2] " Yang Zhang
2017-06-22 11:51   ` [PATCH 2/2] " Paolo Bonzini
2017-06-22 11:51     ` Paolo Bonzini
2017-06-22 11:51     ` [2/2] " Paolo Bonzini
2017-06-23  3:58     ` [PATCH 2/2] " Yang Zhang
2017-06-23  3:58       ` Yang Zhang
2017-06-23  3:58       ` [2/2] " Yang Zhang
2017-06-27 11:22       ` [PATCH 2/2] " Yang Zhang
2017-06-27 11:22         ` Yang Zhang
2017-06-27 11:22         ` [2/2] " Yang Zhang
2017-06-27 12:07         ` [PATCH 2/2] " Paolo Bonzini
2017-06-27 12:07           ` Paolo Bonzini
2017-06-27 12:07           ` [2/2] " Paolo Bonzini
2017-06-27 12:23           ` [PATCH 2/2] " Wanpeng Li
2017-06-27 12:23             ` Wanpeng Li
2017-06-27 12:23             ` [2/2] " Wanpeng Li
2017-06-27 12:28             ` [PATCH 2/2] " Paolo Bonzini
2017-06-27 12:28               ` Paolo Bonzini
2017-06-27 12:28               ` [2/2] " Paolo Bonzini
2017-06-27 13:40               ` [PATCH 2/2] " Radim Krčmář
2017-06-27 13:40                 ` Radim Krčmář
2017-06-27 13:40                 ` [2/2] " Radim Krčmář
2017-06-27 13:56                 ` [PATCH 2/2] " Paolo Bonzini
2017-06-27 13:56                   ` Paolo Bonzini
2017-06-27 13:56                   ` [2/2] " Paolo Bonzini
2017-06-27 14:22                   ` [PATCH 2/2] " Radim Krčmář
2017-06-27 14:22                     ` Radim Krčmář
2017-06-27 14:22                     ` [2/2] " Radim Krčmář
2017-06-27 14:26                     ` [PATCH 2/2] " Paolo Bonzini
2017-06-27 14:26                       ` Paolo Bonzini
2017-06-27 14:26                       ` [2/2] " Paolo Bonzini
2017-07-03  9:28                     ` [PATCH 2/2] " Yang Zhang
2017-07-03  9:28                       ` Yang Zhang
2017-07-03  9:28                       ` [2/2] " Yang Zhang
2017-07-03 10:06                       ` [PATCH 2/2] " Thomas Gleixner
2017-07-03 10:06                         ` Thomas Gleixner
2017-07-03 10:06                         ` [2/2] " Thomas Gleixner
2017-07-04  2:19                         ` Yang Zhang [this message]
2017-07-04  2:19                           ` [PATCH 2/2] " Yang Zhang
2017-07-04  2:19                           ` [2/2] " Yang Zhang
2017-07-04 14:13                       ` [PATCH 2/2] " Radim Krčmář
2017-07-04 14:13                         ` Radim Krčmář
2017-07-04 14:13                         ` [2/2] " Radim Krčmář
2017-07-04 14:50                         ` [PATCH 2/2] " Thomas Gleixner
2017-07-04 14:50                           ` Thomas Gleixner
2017-07-04 14:50                           ` [2/2] " Thomas Gleixner
2017-07-13 11:49                         ` [PATCH 2/2] " Yang Zhang
2017-07-13 11:49                           ` Yang Zhang
2017-07-13 11:49                           ` [2/2] " Yang Zhang
2017-07-14  9:37                           ` [PATCH 2/2] " Alexander Graf
2017-07-14  9:37                             ` Alexander Graf
2017-07-14  9:37                             ` [2/2] " Alexander Graf
2017-07-17  9:26                             ` [PATCH 2/2] " Yang Zhang
2017-07-17  9:26                               ` Yang Zhang
2017-07-17  9:26                               ` [2/2] " Yang Zhang
2017-07-17  9:54                               ` [PATCH 2/2] " Alexander Graf
2017-07-17  9:54                                 ` Alexander Graf
2017-07-17  9:54                                 ` [2/2] " Alexander Graf
2017-07-17 12:50                                 ` [PATCH 2/2] " Yang Zhang
2017-07-17 12:50                                   ` Yang Zhang
2017-07-17 12:50                                   ` [2/2] " Yang Zhang
2017-07-04 22:28                       ` [PATCH 2/2] " Wanpeng Li
2017-07-04 22:28                         ` Wanpeng Li
2017-07-04 22:28                         ` [2/2] " Wanpeng Li
2017-06-22 14:32   ` [PATCH 2/2] " Thomas Gleixner
2017-06-22 14:32     ` Thomas Gleixner
2017-06-22 14:32     ` [2/2] " Thomas Gleixner
2017-06-23  4:04     ` [PATCH 2/2] " Yang Zhang
2017-06-23  4:04       ` Yang Zhang
2017-06-23  4:04       ` [2/2] " Yang Zhang
2017-06-22 22:46   ` [PATCH 2/2] " kbuild test robot
2017-06-22 22:46     ` kbuild test robot
2017-06-22 22:46     ` [2/2] " kbuild test robot
2017-06-22 11:32 ` [PATCH 0/2] x86/idle: add halt poll support Yang Zhang
2017-06-22 11:32   ` Yang Zhang
2017-06-22 11:50 ` Wanpeng Li
2017-06-22 11:50   ` Wanpeng Li
2017-06-23  4:08   ` Yang Zhang
2017-06-23  4:08     ` Yang Zhang
2017-06-23  4:35     ` Wanpeng Li
2017-06-23  4:35       ` Wanpeng Li
2017-06-23  6:49       ` Yang Zhang
2017-06-23  6:49         ` Yang Zhang
2017-06-27 14:00         ` Radim Krčmář
2017-06-27 14:00           ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22bd985d-739e-0a6e-7b16-9f6e3cd39445@gmail.com \
    --to=yang.zhang.wz@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=aaron.lu@intel.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=borntraeger@de.ibm.com \
    --cc=bp@alien8.de \
    --cc=bristot@redhat.com \
    --cc=corbet@lwn.net \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=dvlasenk@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=fengtiantian@huawei.com \
    --cc=fgao@48lvckh6395k16k5.yundunddos.com \
    --cc=fweisbec@gmail.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=hpa@zytor.com \
    --cc=jeyu@redhat.com \
    --cc=johannes.berg@intel.com \
    --cc=jpoimboe@redhat.com \
    --cc=kernellwp@gmail.com \
    --cc=krzk@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    --cc=luto@kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mchehab@kernel.org \
    --cc=me@kylehuey.com \
    --cc=mgorman@techsingularity.net \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=minipli@googlemail.com \
    --cc=nicstange@gmail.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=prarit@redhat.com \
    --cc=rgerst@gmail.com \
    --cc=rkrcmar@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=subashab@codeaurora.org \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    --cc=yu.c.chen@intel.com \
    --cc=zijun_hu@htc.com \
    --cc=zlpnobody@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.