All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Mark Brown <broonie@kernel.org>,
	kuninori.morimoto.gx@renesas.com,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Keyon Jie <yang.jie@linux.intel.com>,
	alsa-devel@alsa-project.org, curtis@malainey.com,
	linux-kernel@vger.kernel.org, tiwai@suse.com,
	liam.r.girdwood@linux.intel.com
Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1
Date: Thu, 19 Mar 2020 18:45:00 +0100	[thread overview]
Message-ID: <2346211f-4639-75c3-513a-b765a0ba88d2@intel.com> (raw)
In-Reply-To: <a7bf2aee-78e7-f905-bcc3-cd21bf16a976@intel.com>

On 2020-03-19 18:33, Cezary Rojewski wrote:
> 
> Thank you for being so cooperative during this 2day debug session.
> 
> The patch I mentioned earlier unintentionally (?) changed 'platform' 
> component param for ssp0_port from 'dummy' to 'platform' for non-SOF 
> solution:
> 
> diff --git a/sound/soc/intel/boards/broadwell.c 
> b/sound/soc/intel/boards/broadwell.c
> index b9c12e24c70b..db7e1e87156d 100644
> --- a/sound/soc/intel/boards/broadwell.c
> +++ b/sound/soc/intel/boards/broadwell.c
> @@ -164,14 +164,6 @@ SND_SOC_DAILINK_DEF(platform,
>   SND_SOC_DAILINK_DEF(codec,
>          DAILINK_COMP_ARRAY(COMP_CODEC("i2c-INT343A:00", "rt286-aif1")));
> 
> -#if IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
> -SND_SOC_DAILINK_DEF(ssp0_port,
> -           DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));
> -#else
> -SND_SOC_DAILINK_DEF(ssp0_port,
> -           DAILINK_COMP_ARRAY(COMP_DUMMY()));
> -#endif
> -
>   /* broadwell digital audio interface glue - connects codec <--> CPU */
>   static struct snd_soc_dai_link broadwell_rt286_dais[] = {
>          /* Front End DAI links */
> @@ -226,7 +218,7 @@ static struct snd_soc_dai_link 
> broadwell_rt286_dais[] = {
>                  .ops = &broadwell_rt286_ops,
>                  .dpcm_playback = 1,
>                  .dpcm_capture = 1,
> -               SND_SOC_DAILINK_REG(ssp0_port, codec, platform),
> +               SND_SOC_DAILINK_REG(dummy, codec, dummy),
>          },
> 

Of course I messed up the mail - above is a revert of said change.

WARNING: multiple messages have this Message-ID (diff)
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
	curtis@malainey.com, tiwai@suse.com,
	Keyon Jie <yang.jie@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com,
	Mark Brown <broonie@kernel.org>
Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1
Date: Thu, 19 Mar 2020 18:45:00 +0100	[thread overview]
Message-ID: <2346211f-4639-75c3-513a-b765a0ba88d2@intel.com> (raw)
In-Reply-To: <a7bf2aee-78e7-f905-bcc3-cd21bf16a976@intel.com>

On 2020-03-19 18:33, Cezary Rojewski wrote:
> 
> Thank you for being so cooperative during this 2day debug session.
> 
> The patch I mentioned earlier unintentionally (?) changed 'platform' 
> component param for ssp0_port from 'dummy' to 'platform' for non-SOF 
> solution:
> 
> diff --git a/sound/soc/intel/boards/broadwell.c 
> b/sound/soc/intel/boards/broadwell.c
> index b9c12e24c70b..db7e1e87156d 100644
> --- a/sound/soc/intel/boards/broadwell.c
> +++ b/sound/soc/intel/boards/broadwell.c
> @@ -164,14 +164,6 @@ SND_SOC_DAILINK_DEF(platform,
>   SND_SOC_DAILINK_DEF(codec,
>          DAILINK_COMP_ARRAY(COMP_CODEC("i2c-INT343A:00", "rt286-aif1")));
> 
> -#if IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
> -SND_SOC_DAILINK_DEF(ssp0_port,
> -           DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));
> -#else
> -SND_SOC_DAILINK_DEF(ssp0_port,
> -           DAILINK_COMP_ARRAY(COMP_DUMMY()));
> -#endif
> -
>   /* broadwell digital audio interface glue - connects codec <--> CPU */
>   static struct snd_soc_dai_link broadwell_rt286_dais[] = {
>          /* Front End DAI links */
> @@ -226,7 +218,7 @@ static struct snd_soc_dai_link 
> broadwell_rt286_dais[] = {
>                  .ops = &broadwell_rt286_ops,
>                  .dpcm_playback = 1,
>                  .dpcm_capture = 1,
> -               SND_SOC_DAILINK_REG(ssp0_port, codec, platform),
> +               SND_SOC_DAILINK_REG(dummy, codec, dummy),
>          },
> 

Of course I messed up the mail - above is a revert of said change.

  reply	other threads:[~2020-03-19 17:45 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  6:30 snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 Dominik Brodowski
2020-03-18  9:41 ` Cezary Rojewski
2020-03-18  9:41   ` Cezary Rojewski
2020-03-18  9:57   ` Dominik Brodowski
2020-03-18  9:57     ` Dominik Brodowski
2020-03-18 10:05     ` Cezary Rojewski
2020-03-18 10:05       ` Cezary Rojewski
2020-03-18 10:19       ` Dominik Brodowski
2020-03-18 10:19         ` Dominik Brodowski
2020-03-18 10:49 ` Keyon Jie
2020-03-18 10:49   ` Keyon Jie
2020-03-18 12:39   ` Dominik Brodowski
2020-03-18 12:39     ` Dominik Brodowski
2020-03-18 15:13     ` Pierre-Louis Bossart
2020-03-18 15:13       ` Pierre-Louis Bossart
2020-03-18 16:20       ` Dominik Brodowski
2020-03-18 16:20         ` Dominik Brodowski
2020-03-18 17:08         ` Pierre-Louis Bossart
2020-03-18 17:08           ` Pierre-Louis Bossart
2020-03-18 17:18           ` Curtis Malainey
2020-03-18 17:19           ` Dominik Brodowski
2020-03-18 17:19             ` Dominik Brodowski
2020-03-18 17:25             ` Curtis Malainey
2020-03-18 19:13               ` Ross Zwisler
2020-03-18 19:13                 ` Ross Zwisler
2020-03-18 17:29             ` Pierre-Louis Bossart
2020-03-18 17:29               ` Pierre-Louis Bossart
2020-03-18 17:35               ` Cezary Rojewski
2020-03-18 18:27         ` Cezary Rojewski
2020-03-18 18:27           ` Cezary Rojewski
2020-03-18 19:22           ` Dominik Brodowski
2020-03-18 19:22             ` Dominik Brodowski
2020-03-18 20:43             ` Cezary Rojewski
2020-03-18 20:43               ` Cezary Rojewski
2020-03-18 21:52               ` Dominik Brodowski
2020-03-18 21:52                 ` Dominik Brodowski
2020-03-18 22:20                 ` Cezary Rojewski
2020-03-18 22:20                   ` Cezary Rojewski
2020-03-19 13:00                   ` Dominik Brodowski
2020-03-19 13:00                     ` Dominik Brodowski
2020-03-19 13:17                     ` Cezary Rojewski
2020-03-19 13:17                       ` Cezary Rojewski
2020-03-19 13:41                     ` Mark Brown
2020-03-19 13:41                       ` Mark Brown
2020-03-19 15:48                       ` Cezary Rojewski
2020-03-19 15:48                         ` Cezary Rojewski
2020-03-19 16:51                         ` Dominik Brodowski
2020-03-19 16:51                           ` Dominik Brodowski
2020-03-19 17:21                           ` Pierre-Louis Bossart
2020-03-19 17:21                             ` Pierre-Louis Bossart
2020-03-19 17:35                             ` Mark Brown
2020-03-19 17:35                               ` Mark Brown
2020-03-20  3:21                               ` Keyon Jie
2020-03-20  3:21                                 ` Keyon Jie
2020-03-19 17:41                             ` Cezary Rojewski
2020-03-19 17:41                               ` Cezary Rojewski
2020-03-19 17:33                           ` Cezary Rojewski
2020-03-19 17:33                             ` Cezary Rojewski
2020-03-19 17:45                             ` Cezary Rojewski [this message]
2020-03-19 17:45                               ` Cezary Rojewski
2020-03-19 18:24                             ` Dominik Brodowski
2020-03-19 18:24                               ` Dominik Brodowski
2020-03-19 18:35                               ` Cezary Rojewski
2020-03-19 18:35                                 ` Cezary Rojewski
2020-03-19 19:05                                 ` Pierre-Louis Bossart
2020-03-19 19:05                                   ` Pierre-Louis Bossart
2020-03-30 10:23                           ` Dominik Brodowski
2020-03-30 10:23                             ` Dominik Brodowski
2020-03-30 11:10                             ` Cezary Rojewski
2020-03-30 11:10                               ` Cezary Rojewski
2020-03-30 11:39                               ` Mark Brown
2020-03-30 11:39                                 ` Mark Brown
2020-03-30 15:37                                 ` Pierre-Louis Bossart
2020-03-30 15:37                                   ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2346211f-4639-75c3-513a-b765a0ba88d2@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=curtis@malainey.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.