All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>,
	Dominik Brodowski <linux@dominikbrodowski.net>
Cc: kuninori.morimoto.gx@renesas.com,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Keyon Jie <yang.jie@linux.intel.com>,
	alsa-devel@alsa-project.org, curtis@malainey.com,
	linux-kernel@vger.kernel.org, tiwai@suse.com,
	liam.r.girdwood@linux.intel.com
Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1
Date: Thu, 19 Mar 2020 16:48:03 +0100	[thread overview]
Message-ID: <a01359dc-479e-b3e3-37a6-4a9c421d18da@intel.com> (raw)
In-Reply-To: <20200319134139.GB3983@sirena.org.uk>

On 2020-03-19 14:41, Mark Brown wrote:
> On Thu, Mar 19, 2020 at 02:00:49PM +0100, Dominik Brodowski wrote:
> 
>> Have some good news now, namely that a bisect is complete: That pointed to
>> 1272063a7ee4 ("ASoC: soc-core: care .ignore_suspend for Component suspend");
>> therefore I've added Kuninori Morimoto to this e-mail thread.
> 
> If that's an issue it feels more like a driver bug in that if the driver
> asked for ignore_suspend then it should expect not to have the suspend
> callback called.
> 

Requested for tests with following diff applied:

diff --git a/sound/soc/intel/boards/broadwell.c 
b/sound/soc/intel/boards/broadwell.c
index db7e1e87156d..6ed4c1b0a515 100644
--- a/sound/soc/intel/boards/broadwell.c
+++ b/sound/soc/intel/boards/broadwell.c
@@ -212,7 +212,6 @@ static struct snd_soc_dai_link 
broadwell_rt286_dais[] = {
                 .init = broadwell_rt286_codec_init,
                 .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
                         SND_SOC_DAIFMT_CBS_CFS,
-               .ignore_suspend = 1,
                 .ignore_pmdown_time = 1,
                 .be_hw_params_fixup = broadwell_ssp0_fixup,
                 .ops = &broadwell_rt286_ops,

WARNING: multiple messages have this Message-ID (diff)
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>,
	Dominik Brodowski <linux@dominikbrodowski.net>
Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
	curtis@malainey.com, tiwai@suse.com,
	Keyon Jie <yang.jie@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com
Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1
Date: Thu, 19 Mar 2020 16:48:03 +0100	[thread overview]
Message-ID: <a01359dc-479e-b3e3-37a6-4a9c421d18da@intel.com> (raw)
In-Reply-To: <20200319134139.GB3983@sirena.org.uk>

On 2020-03-19 14:41, Mark Brown wrote:
> On Thu, Mar 19, 2020 at 02:00:49PM +0100, Dominik Brodowski wrote:
> 
>> Have some good news now, namely that a bisect is complete: That pointed to
>> 1272063a7ee4 ("ASoC: soc-core: care .ignore_suspend for Component suspend");
>> therefore I've added Kuninori Morimoto to this e-mail thread.
> 
> If that's an issue it feels more like a driver bug in that if the driver
> asked for ignore_suspend then it should expect not to have the suspend
> callback called.
> 

Requested for tests with following diff applied:

diff --git a/sound/soc/intel/boards/broadwell.c 
b/sound/soc/intel/boards/broadwell.c
index db7e1e87156d..6ed4c1b0a515 100644
--- a/sound/soc/intel/boards/broadwell.c
+++ b/sound/soc/intel/boards/broadwell.c
@@ -212,7 +212,6 @@ static struct snd_soc_dai_link 
broadwell_rt286_dais[] = {
                 .init = broadwell_rt286_codec_init,
                 .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
                         SND_SOC_DAIFMT_CBS_CFS,
-               .ignore_suspend = 1,
                 .ignore_pmdown_time = 1,
                 .be_hw_params_fixup = broadwell_ssp0_fixup,
                 .ops = &broadwell_rt286_ops,

  reply	other threads:[~2020-03-19 15:48 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  6:30 snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 Dominik Brodowski
2020-03-18  9:41 ` Cezary Rojewski
2020-03-18  9:41   ` Cezary Rojewski
2020-03-18  9:57   ` Dominik Brodowski
2020-03-18  9:57     ` Dominik Brodowski
2020-03-18 10:05     ` Cezary Rojewski
2020-03-18 10:05       ` Cezary Rojewski
2020-03-18 10:19       ` Dominik Brodowski
2020-03-18 10:19         ` Dominik Brodowski
2020-03-18 10:49 ` Keyon Jie
2020-03-18 10:49   ` Keyon Jie
2020-03-18 12:39   ` Dominik Brodowski
2020-03-18 12:39     ` Dominik Brodowski
2020-03-18 15:13     ` Pierre-Louis Bossart
2020-03-18 15:13       ` Pierre-Louis Bossart
2020-03-18 16:20       ` Dominik Brodowski
2020-03-18 16:20         ` Dominik Brodowski
2020-03-18 17:08         ` Pierre-Louis Bossart
2020-03-18 17:08           ` Pierre-Louis Bossart
2020-03-18 17:18           ` Curtis Malainey
2020-03-18 17:19           ` Dominik Brodowski
2020-03-18 17:19             ` Dominik Brodowski
2020-03-18 17:25             ` Curtis Malainey
2020-03-18 19:13               ` Ross Zwisler
2020-03-18 19:13                 ` Ross Zwisler
2020-03-18 17:29             ` Pierre-Louis Bossart
2020-03-18 17:29               ` Pierre-Louis Bossart
2020-03-18 17:35               ` Cezary Rojewski
2020-03-18 18:27         ` Cezary Rojewski
2020-03-18 18:27           ` Cezary Rojewski
2020-03-18 19:22           ` Dominik Brodowski
2020-03-18 19:22             ` Dominik Brodowski
2020-03-18 20:43             ` Cezary Rojewski
2020-03-18 20:43               ` Cezary Rojewski
2020-03-18 21:52               ` Dominik Brodowski
2020-03-18 21:52                 ` Dominik Brodowski
2020-03-18 22:20                 ` Cezary Rojewski
2020-03-18 22:20                   ` Cezary Rojewski
2020-03-19 13:00                   ` Dominik Brodowski
2020-03-19 13:00                     ` Dominik Brodowski
2020-03-19 13:17                     ` Cezary Rojewski
2020-03-19 13:17                       ` Cezary Rojewski
2020-03-19 13:41                     ` Mark Brown
2020-03-19 13:41                       ` Mark Brown
2020-03-19 15:48                       ` Cezary Rojewski [this message]
2020-03-19 15:48                         ` Cezary Rojewski
2020-03-19 16:51                         ` Dominik Brodowski
2020-03-19 16:51                           ` Dominik Brodowski
2020-03-19 17:21                           ` Pierre-Louis Bossart
2020-03-19 17:21                             ` Pierre-Louis Bossart
2020-03-19 17:35                             ` Mark Brown
2020-03-19 17:35                               ` Mark Brown
2020-03-20  3:21                               ` Keyon Jie
2020-03-20  3:21                                 ` Keyon Jie
2020-03-19 17:41                             ` Cezary Rojewski
2020-03-19 17:41                               ` Cezary Rojewski
2020-03-19 17:33                           ` Cezary Rojewski
2020-03-19 17:33                             ` Cezary Rojewski
2020-03-19 17:45                             ` Cezary Rojewski
2020-03-19 17:45                               ` Cezary Rojewski
2020-03-19 18:24                             ` Dominik Brodowski
2020-03-19 18:24                               ` Dominik Brodowski
2020-03-19 18:35                               ` Cezary Rojewski
2020-03-19 18:35                                 ` Cezary Rojewski
2020-03-19 19:05                                 ` Pierre-Louis Bossart
2020-03-19 19:05                                   ` Pierre-Louis Bossart
2020-03-30 10:23                           ` Dominik Brodowski
2020-03-30 10:23                             ` Dominik Brodowski
2020-03-30 11:10                             ` Cezary Rojewski
2020-03-30 11:10                               ` Cezary Rojewski
2020-03-30 11:39                               ` Mark Brown
2020-03-30 11:39                                 ` Mark Brown
2020-03-30 15:37                                 ` Pierre-Louis Bossart
2020-03-30 15:37                                   ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a01359dc-479e-b3e3-37a6-4a9c421d18da@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=curtis@malainey.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.