From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Marco Felsch" <m.felsch@pengutronix.de>,
support.opensource@diasemi.com,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Joel Stanley" <joel@jms.id.au>,
lgirdwood@gmail.com, broonie@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>
Subject: Re: [PATCH v3 2/6] gpio: make gpiod_to_offset() available for other users
Date: Mon, 02 Dec 2019 13:30:04 +1030 [thread overview]
Message-ID: <23d79dff-6577-4fba-b7e6-d494ec7b8a93@www.fastmail.com> (raw)
In-Reply-To: <20191129172537.31410-3-m.felsch@pengutronix.de>
On Sat, 30 Nov 2019, at 03:55, Marco Felsch wrote:
> Currently gpiod_to_offset() is a gpio-subsystem private function which
> is used by the gpiolib itself and by the aspeed gpio driver. The time
> has shown that there are other drivers as well which need this
> information in some special cases e.g. MFD drivers. The patch makes the
> function public but you need to explicit add the <linux/gpio/private.h>
> include. See discussion [1] for more information.
>
> [1] https://lkml.org/lkml/2019/11/27/357
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> v3:
> - former patch description was "gpio: add support to get local gpio number"
> - adapt commit message and description to reflect new state
> - don't add wrapper instead use the already existing gpiod_to_offset
> - move gpiod_to_offset from gpiolib.h into gpiolib.c
> - move declaration into linux/gpio/private.h
> ---
> drivers/gpio/gpio-aspeed.c | 11 +++++------
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Marco Felsch" <m.felsch@pengutronix.de>,
support.opensource@diasemi.com,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Joel Stanley" <joel@jms.id.au>,
lgirdwood@gmail.com, broonie@kernel.org
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/6] gpio: make gpiod_to_offset() available for other users
Date: Mon, 02 Dec 2019 13:30:04 +1030 [thread overview]
Message-ID: <23d79dff-6577-4fba-b7e6-d494ec7b8a93@www.fastmail.com> (raw)
In-Reply-To: <20191129172537.31410-3-m.felsch@pengutronix.de>
On Sat, 30 Nov 2019, at 03:55, Marco Felsch wrote:
> Currently gpiod_to_offset() is a gpio-subsystem private function which
> is used by the gpiolib itself and by the aspeed gpio driver. The time
> has shown that there are other drivers as well which need this
> information in some special cases e.g. MFD drivers. The patch makes the
> function public but you need to explicit add the <linux/gpio/private.h>
> include. See discussion [1] for more information.
>
> [1] https://lkml.org/lkml/2019/11/27/357
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> v3:
> - former patch description was "gpio: add support to get local gpio number"
> - adapt commit message and description to reflect new state
> - don't add wrapper instead use the already existing gpiod_to_offset
> - move gpiod_to_offset from gpiolib.h into gpiolib.c
> - move declaration into linux/gpio/private.h
> ---
> drivers/gpio/gpio-aspeed.c | 11 +++++------
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-02 2:58 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 17:25 [PATCH v3 0/6] DA9062 PMIC features Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-11-29 17:25 ` [PATCH v3 1/6] gpio: treewide rename gpio_chip_hwgpio to gpiod_to_offset Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-12-02 2:59 ` Andrew Jeffery
2019-12-02 2:59 ` Andrew Jeffery
2019-11-29 17:25 ` [PATCH v3 2/6] gpio: make gpiod_to_offset() available for other users Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-12-02 3:00 ` Andrew Jeffery [this message]
2019-12-02 3:00 ` Andrew Jeffery
2019-11-29 17:25 ` [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-12-04 13:46 ` Mark Brown
2019-12-04 13:46 ` Mark Brown
2019-12-10 9:41 ` Marco Felsch
2019-12-10 9:41 ` Marco Felsch
2019-12-11 16:14 ` Adam Thomson
2019-12-11 16:14 ` Adam Thomson
2019-12-11 17:09 ` Marco Felsch
2019-12-11 17:09 ` Marco Felsch
2019-12-12 15:08 ` Linus Walleij
2019-12-12 15:08 ` Linus Walleij
2019-12-12 15:55 ` Marco Felsch
2019-12-12 15:55 ` Marco Felsch
2019-12-12 16:10 ` Mark Brown
2019-12-12 16:10 ` Mark Brown
2019-12-12 16:21 ` Marco Felsch
2019-12-12 16:21 ` Marco Felsch
2019-12-12 16:51 ` Mark Brown
2019-12-12 16:51 ` Mark Brown
2019-12-16 8:55 ` Marco Felsch
2019-12-16 8:55 ` Marco Felsch
2019-12-16 11:44 ` Mark Brown
2019-12-16 11:44 ` Mark Brown
2019-12-17 7:35 ` Marco Felsch
2019-12-17 7:35 ` Marco Felsch
2019-12-17 12:58 ` Mark Brown
2019-12-17 12:58 ` Mark Brown
2020-01-07 8:36 ` Marco Felsch
2020-01-07 8:36 ` Marco Felsch
2020-01-07 13:09 ` Mark Brown
2020-01-07 13:09 ` Mark Brown
2020-01-07 13:38 ` Marco Felsch
2020-01-07 13:38 ` Marco Felsch
2020-01-14 15:43 ` Mark Brown
2020-01-14 15:43 ` Mark Brown
2019-12-16 16:32 ` Adam Thomson
2019-12-16 16:32 ` Adam Thomson
2019-12-17 9:00 ` Marco Felsch
2019-12-17 9:00 ` Marco Felsch
2019-12-17 9:12 ` Marco Felsch
2019-12-17 9:12 ` Marco Felsch
2019-12-17 9:53 ` Adam Thomson
2019-12-17 9:53 ` Adam Thomson
2019-12-17 12:31 ` Marco Felsch
2019-12-17 12:31 ` Marco Felsch
2019-12-17 13:13 ` Adam Thomson
2019-12-17 13:13 ` Adam Thomson
2019-12-16 16:32 ` Adam Thomson
2019-12-16 16:32 ` Adam Thomson
2019-12-16 12:28 ` Linus Walleij
2019-12-16 12:28 ` Linus Walleij
2019-11-29 17:25 ` [PATCH v3 4/6] regulator: da9062: add voltage selection gpio support Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-11-29 17:25 ` [PATCH v3 5/6] dt-bindings: mfd: da9062: add regulator gpio enable/disable documentation Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-12-13 22:23 ` Rob Herring
2019-12-13 22:23 ` Rob Herring
2019-12-16 16:31 ` Lee Jones
2019-12-16 16:31 ` Lee Jones
2019-11-29 17:25 ` [PATCH v3 6/6] regulator: da9062: add gpio based regulator dis-/enable support Marco Felsch
2019-11-29 17:25 ` Marco Felsch
2019-12-02 11:44 ` [PATCH v3 0/6] DA9062 PMIC features Linus Walleij
2019-12-02 11:44 ` Linus Walleij
2019-12-02 12:04 ` Lee Jones
2019-12-02 12:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23d79dff-6577-4fba-b7e6-d494ec7b8a93@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.