All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux-arm-kernel@lists.infradead.org,
	Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
Cc: mripard@kernel.org, wens@csie.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node
Date: Thu, 21 Jan 2021 20:54:07 +0100	[thread overview]
Message-ID: <2438641.b0YrFlWa0f@kista> (raw)
In-Reply-To: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de>

Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a):
> BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> packet loss rates. The realtek phy driver overrides the settings of the
> pull ups for the delays, so fix this for Banana Pro.
> 
> Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>

Much better. Now the only thing missing is "Fixes" tag, which references 
commit which introduced the issue. Probably this will be the commit which 
added ethernet node. This tag is important for deciding which commits should 
be backported to stable releases. Take a look in v1 for M2U fixes tag.

Btw, each version should have changelog under "---" line, so maintainers and 
reviewers know what changed.

Best regards,
Jernej



WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux-arm-kernel@lists.infradead.org,
	Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
Cc: devicetree@vger.kernel.org, wens@csie.org, robh+dt@kernel.org,
	linux-kernel@vger.kernel.org, mripard@kernel.org
Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node
Date: Thu, 21 Jan 2021 20:54:07 +0100	[thread overview]
Message-ID: <2438641.b0YrFlWa0f@kista> (raw)
In-Reply-To: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de>

Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a):
> BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> packet loss rates. The realtek phy driver overrides the settings of the
> pull ups for the delays, so fix this for Banana Pro.
> 
> Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>

Much better. Now the only thing missing is "Fixes" tag, which references 
commit which introduced the issue. Probably this will be the commit which 
added ethernet node. This tag is important for deciding which commits should 
be backported to stable releases. Take a look in v1 for M2U fixes tag.

Btw, each version should have changelog under "---" line, so maintainers and 
reviewers know what changed.

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-21 20:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 17:08 [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node Hermann Lauer
2021-01-21 17:08 ` Hermann Lauer
2021-01-21 19:54 ` Jernej Škrabec [this message]
2021-01-21 19:54   ` Jernej Škrabec
2021-01-22  3:09   ` Chen-Yu Tsai
2021-01-22  3:09     ` Chen-Yu Tsai
2021-01-28  9:40 ` [PATCH v3] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode Hermann Lauer
2021-01-28  9:40   ` Hermann Lauer
2021-01-28 11:18   ` [PATCH v4] " Hermann.Lauer
2021-01-28 11:18     ` Hermann.Lauer
2021-01-28 14:59     ` Maxime Ripard
2021-01-28 14:59       ` Maxime Ripard
2021-02-01 12:08       ` Hermann Lauer
2021-02-01 12:08         ` Hermann Lauer
2021-02-01 17:29         ` Maxime Ripard
2021-02-01 17:29           ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2438641.b0YrFlWa0f@kista \
    --to=jernej.skrabec@siol.net \
    --cc=Hermann.Lauer@iwr.uni-heidelberg.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.