From: Joe Perches <joe@perches.com> To: Shreeya Patel <shreeya.patel23498@gmail.com>, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Subject: Re: [Outreachy kernel] [PATCH v2] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions Date: Fri, 13 Mar 2020 14:21:57 -0700 [thread overview] Message-ID: <25a1aca2c993ecb70ba7cd9c9e38bce9170a98b0.camel@perches.com> (raw) In-Reply-To: <20200313102912.17218-1-shreeya.patel23498@gmail.com> On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote: > Remove unnecessary if and else conditions since both are leading to the > initialization of "phtpriv->ampdu_enable" with the same value. > Also, remove the unnecessary else-if condition since it does nothing. [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c [] > @@ -2772,16 +2772,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe > > /* maybe needs check if ap supports rx ampdu. */ > if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) { > - if (pregistrypriv->wifi_spec == 1) { > - /* remove this part because testbed AP should disable RX AMPDU */ > - /* phtpriv->ampdu_enable = false; */ > - phtpriv->ampdu_enable = true; > - } else { > - phtpriv->ampdu_enable = true; > - } > - } else if (pregistrypriv->ampdu_enable == 2) { > - /* remove this part because testbed AP should disable RX AMPDU */ > - /* phtpriv->ampdu_enable = true; */ > + phtpriv->ampdu_enable = true; This isn't the same test. This could be: if ((!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1)) || pregistrypriv->ampdu_enable == 2) phtpriv->ampdu_enable = true; Though it is probably more sensible to just set phtpriv->ampdu_enable without testing whether or not it's already set: if (pregistrypriv->ampdu_enable == 1 || pregistrypriv->ampdu_enable == 2) phtpriv->ampdu_enable = true;
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Shreeya Patel <shreeya.patel23498@gmail.com>, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Subject: Re: [Outreachy kernel] [PATCH v2] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions Date: Fri, 13 Mar 2020 14:21:57 -0700 [thread overview] Message-ID: <25a1aca2c993ecb70ba7cd9c9e38bce9170a98b0.camel@perches.com> (raw) In-Reply-To: <20200313102912.17218-1-shreeya.patel23498@gmail.com> On Fri, 2020-03-13 at 15:59 +0530, Shreeya Patel wrote: > Remove unnecessary if and else conditions since both are leading to the > initialization of "phtpriv->ampdu_enable" with the same value. > Also, remove the unnecessary else-if condition since it does nothing. [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c [] > @@ -2772,16 +2772,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channe > > /* maybe needs check if ap supports rx ampdu. */ > if (!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1) { > - if (pregistrypriv->wifi_spec == 1) { > - /* remove this part because testbed AP should disable RX AMPDU */ > - /* phtpriv->ampdu_enable = false; */ > - phtpriv->ampdu_enable = true; > - } else { > - phtpriv->ampdu_enable = true; > - } > - } else if (pregistrypriv->ampdu_enable == 2) { > - /* remove this part because testbed AP should disable RX AMPDU */ > - /* phtpriv->ampdu_enable = true; */ > + phtpriv->ampdu_enable = true; This isn't the same test. This could be: if ((!(phtpriv->ampdu_enable) && pregistrypriv->ampdu_enable == 1)) || pregistrypriv->ampdu_enable == 2) phtpriv->ampdu_enable = true; Though it is probably more sensible to just set phtpriv->ampdu_enable without testing whether or not it's already set: if (pregistrypriv->ampdu_enable == 1 || pregistrypriv->ampdu_enable == 2) phtpriv->ampdu_enable = true; _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-13 21:23 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-13 10:29 [Outreachy kernel] [PATCH v2] Staging: rtl8723bs: rtw_mlme: Remove unnecessary conditions Shreeya Patel 2020-03-13 10:29 ` Shreeya Patel 2020-03-13 21:21 ` Joe Perches [this message] 2020-03-13 21:21 ` Joe Perches 2020-03-14 11:28 ` Shreeya Patel 2020-03-14 11:28 ` Shreeya Patel 2020-03-15 4:32 ` Joe Perches 2020-03-15 4:32 ` Joe Perches 2020-03-15 21:27 ` Stefano Brivio 2020-03-15 21:27 ` Stefano Brivio
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=25a1aca2c993ecb70ba7cd9c9e38bce9170a98b0.camel@perches.com \ --to=joe@perches.com \ --cc=Larry.Finger@lwfinger.net \ --cc=daniel.baluta@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=hverkuil@xs4all.nl \ --cc=linux-kernel@vger.kernel.org \ --cc=nramas@linux.microsoft.com \ --cc=outreachy-kernel@googlegroups.com \ --cc=sbrivio@redhat.com \ --cc=shreeya.patel23498@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.