* [PATCH v2 0/2] Staging: mt7621-dma: Fix checkpatch issues
@ 2019-02-25 14:49 Bhanusree Pola
2019-02-25 14:49 ` [PATCH v2 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
2019-02-25 14:49 ` [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
0 siblings, 2 replies; 6+ messages in thread
From: Bhanusree Pola @ 2019-02-25 14:49 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman, Matthias Brugger
This patch series cleans up the following checkpatch.pl issues:
CHECK: Alignment should match open parenthesis
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
v2:
[PATCH 1/2]: commit log modified
[PATCH 2/2]: commit log modified
Bhanusree Pola (2):
Staging: mt761-dma: Alignment should match open paranthesis
Staging: mt7621_dma: Prefer unsigned int over just unsigned
drivers/staging/mt7621-dma/mtk-hsdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] Staging: mt761-dma: Alignment should match open paranthesis
2019-02-25 14:49 [PATCH v2 0/2] Staging: mt7621-dma: Fix checkpatch issues Bhanusree Pola
@ 2019-02-25 14:49 ` Bhanusree Pola
2019-02-25 15:00 ` Matthias Brugger
2019-02-25 14:49 ` [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
1 sibling, 1 reply; 6+ messages in thread
From: Bhanusree Pola @ 2019-02-25 14:49 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman, Matthias Brugger
Adjust "dev_dbg" parameters to match alignment with open paranthesis
Issue found with checkpatch.pl
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index d67a2504adb1..20c8879d4979 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -242,7 +242,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
int i;
dev_dbg(hsdma->ddev.dev, "tx idx: %d, rx idx: %d\n",
- chan->tx_idx, chan->rx_idx);
+ chan->tx_idx, chan->rx_idx);
for (i = 0; i < HSDMA_DESCS_NUM; i++) {
tx_desc = &chan->tx_ring[i];
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
2019-02-25 14:49 [PATCH v2 0/2] Staging: mt7621-dma: Fix checkpatch issues Bhanusree Pola
2019-02-25 14:49 ` [PATCH v2 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
@ 2019-02-25 14:49 ` Bhanusree Pola
2019-02-25 15:02 ` Matthias Brugger
1 sibling, 1 reply; 6+ messages in thread
From: Bhanusree Pola @ 2019-02-25 14:49 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman, Matthias Brugger
Replace 'unsigned' with 'unsigned int' to be specific with data type.
Issue found with checkpatch.pl
Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 20c8879d4979..7b2cdd2829a5 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
}
static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
- unsigned reg, u32 val)
+ unsigned int reg, u32 val)
{
writel(val, hsdma->base + reg);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] Staging: mt761-dma: Alignment should match open paranthesis
2019-02-25 14:49 ` [PATCH v2 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
@ 2019-02-25 15:00 ` Matthias Brugger
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2019-02-25 15:00 UTC (permalink / raw)
To: Bhanusree Pola, outreachy-kernel; +Cc: Greg Kroah-Hartman
On 25/02/2019 15:49, Bhanusree Pola wrote:
> Adjust "dev_dbg" parameters to match alignment with open paranthesis
> Issue found with checkpatch.pl
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d67a2504adb1..20c8879d4979 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -242,7 +242,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
> int i;
>
> dev_dbg(hsdma->ddev.dev, "tx idx: %d, rx idx: %d\n",
> - chan->tx_idx, chan->rx_idx);
> + chan->tx_idx, chan->rx_idx);
>
> for (i = 0; i < HSDMA_DESCS_NUM; i++) {
> tx_desc = &chan->tx_ring[i];
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
2019-02-25 14:49 ` [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
@ 2019-02-25 15:02 ` Matthias Brugger
2019-02-25 15:58 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Brugger @ 2019-02-25 15:02 UTC (permalink / raw)
To: Bhanusree Pola, outreachy-kernel; +Cc: Greg Kroah-Hartman
On 25/02/2019 15:49, Bhanusree Pola wrote:
> Replace 'unsigned' with 'unsigned int' to be specific with data type.
> Issue found with checkpatch.pl
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 20c8879d4979..7b2cdd2829a5 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
> }
>
> static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
> - unsigned reg, u32 val)
> + unsigned int reg, u32 val)
You could align to the open paranthesis as well?
Regards,
Matthias
> {
> writel(val, hsdma->base + reg);
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned
2019-02-25 15:02 ` Matthias Brugger
@ 2019-02-25 15:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-02-25 15:58 UTC (permalink / raw)
To: Matthias Brugger; +Cc: Bhanusree Pola, outreachy-kernel
On Mon, Feb 25, 2019 at 04:02:00PM +0100, Matthias Brugger wrote:
>
>
> On 25/02/2019 15:49, Bhanusree Pola wrote:
> > Replace 'unsigned' with 'unsigned int' to be specific with data type.
> > Issue found with checkpatch.pl
> >
> > Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> > ---
> > drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > index 20c8879d4979..7b2cdd2829a5 100644
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > @@ -191,7 +191,7 @@ static inline u32 mtk_hsdma_read(struct mtk_hsdam_engine *hsdma, u32 reg)
> > }
> >
> > static inline void mtk_hsdma_write(struct mtk_hsdam_engine *hsdma,
> > - unsigned reg, u32 val)
> > + unsigned int reg, u32 val)
>
> You could align to the open paranthesis as well?
No, please only one type of change per patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-25 15:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 14:49 [PATCH v2 0/2] Staging: mt7621-dma: Fix checkpatch issues Bhanusree Pola
2019-02-25 14:49 ` [PATCH v2 1/2] Staging: mt761-dma: Alignment should match open paranthesis Bhanusree Pola
2019-02-25 15:00 ` Matthias Brugger
2019-02-25 14:49 ` [PATCH v2 2/2] Staging: mt7621_dma: Prefer unsigned int over just unsigned Bhanusree Pola
2019-02-25 15:02 ` Matthias Brugger
2019-02-25 15:58 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.